From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Pavel Emelianov <xemul@openvz.org>,
Hugh Dickins <hugh@veritas.com>,
Sudhir Kumar <skumar@linux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@valinux.co.jp>,
lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org,
taka@valinux.co.jp, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [-mm] Add an owner to the mm_struct (v7)
Date: Fri, 04 Apr 2008 00:18:11 +0530 [thread overview]
Message-ID: <47F5266B.2060402@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830804031141o142bf8c2o1899ca78f8cd434a@mail.gmail.com>
Paul Menage wrote:
> On Thu, Apr 3, 2008 at 11:34 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> That is indeed quite bad. Do we have to retire the group_leader to init_css_set?
>> Can we not check for delay_group_leader() there?
>>
>
> That might have unintentded consequences, such as leaving a pid in the
> cgroup that can't be moved (since it's PF_EXITING) but won't go away
> until its threads have all exited.
> Maybe that's OK if the other threads are guaranteed to have started
> exiting by this point. We'd need some cleanup for when the group
> leader finally did exit.
Yes, we might be stuck with an unremovable group, but I am not sure how to
address the side-effect at this point. Not having that check could mean that
mm_update_new_owner() will be called very frequently and for thousands of
threads that could clearly become an overhead, if threads start exiting one by
one - lead by the thread group leader.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next prev parent reply other threads:[~2008-04-03 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 17:44 Balbir Singh
2008-04-03 17:58 ` Paul Menage
2008-04-03 18:11 ` Balbir Singh
2008-04-03 18:22 ` Paul Menage
2008-04-03 18:34 ` Balbir Singh
2008-04-03 18:41 ` Paul Menage
2008-04-03 18:48 ` Balbir Singh [this message]
2008-04-03 18:25 ` Dave Hansen
2008-04-03 18:30 ` Paul Menage
2008-04-03 18:51 ` Balbir Singh
2008-04-03 18:56 ` Paul Menage
2008-04-03 19:28 ` Balbir Singh
2008-04-03 18:59 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F5266B.2060402@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=rientjes@google.com \
--cc=skumar@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox