From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <47EA6F39.6020909@sgi.com> Date: Wed, 26 Mar 2008 08:43:53 -0700 From: Mike Travis MIME-Version: 1.0 Subject: Re: [PATCH 02/10] init: move setup of nr_cpu_ids to as early as possible v2 References: <20080325220650.835342000@polaris-admin.engr.sgi.com> <20080325220651.146336000@polaris-admin.engr.sgi.com> <20080326062725.GD18301@elte.hu> In-Reply-To: <20080326062725.GD18301@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Ingo Molnar Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tony Luck , Paul Mackerras , Anton Blanchard , "David S. Miller" , "William L. Irwin" , Thomas Gleixner , "H. Peter Anvin" List-ID: Ingo Molnar wrote: > * Mike Travis wrote: > >> Move the setting of nr_cpu_ids from sched_init() to >> setup_per_cpu_areas(), so that it's available as early as possible. > > hm, why not a separate call before setup_per_cpu_areas(), so that we can > avoid spreading this from generic kernel into a bunch of architectures > that happen to have their own version of setup_per_cpu_areas(): > >> 7 files changed, 43 insertions(+), 15 deletions(-) > > Ingo I had this before but I then discovered that an arch would increase (and possible decrease) it's number of possible cpus in setup_per_cpu_areas(). So I figured that setting nr_cpu_ids (and the cpumask_of_cpu map) should be a side effect of setup_per_cpu_areas(). Thanks, Mike -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org