From: Chris Snook <csnook@redhat.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] srat, x86_64: Add support for nodes spanning other nodes
Date: Tue, 25 Mar 2008 13:28:53 -0400 [thread overview]
Message-ID: <47E93655.10907@redhat.com> (raw)
In-Reply-To: <20080325171435.GA3313@linux-os.sc.intel.com>
Suresh Siddha wrote:
> For example, If the physical address layout on a two node system with 8 GB
> memory is something like:
> node 0: 0-2GB, 4-6GB
> node 1: 2-4GB, 6-8GB
>
> Current kernels fail to boot/detect this NUMA topology.
>
> ACPI SRAT tables can expose such a topology which needs to be supported.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
> ---
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 227fdb0..99eb102 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -880,6 +880,15 @@ config X86_64_ACPI_NUMA
> help
> Enable ACPI SRAT based node topology detection.
>
> +# Some NUMA nodes have memory ranges that span
> +# other nodes. Even though a pfn is valid and
> +# between a node's start and end pfns, it may not
> +# reside on that node. See memmap_init_zone()
> +# for details.
> +config NODES_SPAN_OTHER_NODES
> + def_bool y
> + depends on X86_64_ACPI_NUMA
> +
Is this hunk a leftover from your testing? You're not using the config option
anywhere, and there isn't really anything in this patch that would justify
making this a separate config option in mainline.
-- Chris
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-25 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 17:14 Suresh Siddha
2008-03-25 17:28 ` Chris Snook [this message]
2008-03-25 17:38 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E93655.10907@redhat.com \
--to=csnook@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox