From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
To: yamamoto@valinux.co.jp
Cc: Hugh Dickins <hugh@veritas.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
minoura@valinux.co.jp,
Linux Containers <containers@lists.osdl.org>,
Linux MM <linux-mm@kvack.org>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Subject: Re: [RFC][PATCH] another swap controller for cgroup
Date: Mon, 17 Mar 2008 17:15:16 +0900 [thread overview]
Message-ID: <47DE2894.6010306@mxp.nes.nec.co.jp> (raw)
In-Reply-To: <20080317020407.8512E1E7995@siro.lan>
Hi, Yamamoto-san.
I'm reviewing and testing your patch now.
I think your implementation is better because:
- the group to be charged is determined correctly
at the point of swapout, without fixing the behavior
of move_task of memcg.
(I think the behavior of move_task of memcg should be
fixed anyway.)
- the group to be uncharged is remembered in page struct
of pmd, so there is no need to add array of pointers
to swap_info_struct.
> - anonymous objects (shmem) are not accounted.
IMHO, shmem should be accounted.
I agree it's difficult in your implementation,
but are you going to support it?
Thanks,
Daisuke Nishimura.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-17 8:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 2:04 YAMAMOTO Takashi
2008-03-17 5:11 ` Balbir Singh
2008-03-17 8:15 ` Daisuke Nishimura [this message]
2008-03-17 8:50 ` YAMAMOTO Takashi
2008-04-29 22:50 ` YAMAMOTO Takashi
2008-04-30 4:09 ` Daisuke Nishimura
2008-05-22 4:46 ` YAMAMOTO Takashi
2008-05-22 4:54 ` Daisuke Nishimura
2008-05-05 6:11 ` Balbir Singh
2008-05-07 5:50 ` YAMAMOTO Takashi
2008-05-08 15:43 ` Balbir Singh
2008-05-14 3:21 ` YAMAMOTO Takashi
2008-05-14 3:27 ` Paul Menage
2008-05-14 8:44 ` Paul Menage
2008-05-15 6:23 ` YAMAMOTO Takashi
2008-05-15 7:19 ` Paul Menage
2008-05-15 8:56 ` YAMAMOTO Takashi
2008-05-15 12:01 ` Daisuke Nishimura
2008-05-19 4:14 ` YAMAMOTO Takashi
2008-03-24 12:10 ` Daisuke Nishimura
2008-03-24 12:22 ` Balbir Singh
2008-03-25 6:46 ` Daisuke Nishimura
2008-03-25 3:10 ` YAMAMOTO Takashi
2008-03-25 4:35 ` Daisuke Nishimura
2008-03-25 8:57 ` YAMAMOTO Takashi
2008-03-25 12:35 ` Daisuke Nishimura
2008-03-27 6:28 ` YAMAMOTO Takashi
2008-03-28 9:00 ` Daisuke Nishimura
[not found] ` <47ECB3B1.6040500-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>
2008-04-08 3:29 ` YAMAMOTO Takashi
2008-04-10 7:40 ` YAMAMOTO Takashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DE2894.6010306@mxp.nes.nec.co.jp \
--to=nishimura@mxp.nes.nec.co.jp \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=minoura@valinux.co.jp \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox