Re: [RFC][PATCH] page reclaim throttle take2

[Balbir Singh <balbir@linux.vnet.ibm.com>]

KOSAKI Motohiro wrote:
> Hi Peter,
> 
>>> +
>>> +	atomic_t		nr_reclaimers;
>>> +	wait_queue_head_t	reclaim_throttle_waitq;
>>>  	/*
>>>  	 * rarely used fields:
>>>  	 */
>> Small nit, that extra blank line seems at the wrong end of the text
>> block :-)
> 
> Agghhh, sorry ;-)
> I'll fix at next post.
> 
>>> +out:
>>> +	atomic_dec(&zone->nr_reclaimers);
>>> +	wake_up_all(&zone->reclaim_throttle_waitq);
>>> +
>>> +	return ret;
>>> +}
>> Would it be possible - and worthwhile - to make this FIFO fair?
> 
> Hmmm
> may be, we don't need perfectly fair.
> because try_to_free_page() is unfair mechanism.
> 
> but I will test use wake_up() instead wake_up_all().
> it makes so so fair order if no performance regression happend.
> 
> Thanks very useful comment.

One more thing, I would request you to add default heuristics (number of
reclaimers), based on the number of cpus in the system. Letting people tuning it
is fine, but defaults should be related to number of cpus, nodes and zones on
the system. Zones can be reaped in parallel per node and cpus allow threads to
run in parallel. So please use that to come up with good defaults, instead of a
number like "3".

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>