From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <47BD38AB.80408@bull.net> Date: Thu, 21 Feb 2008 09:39:07 +0100 From: Nadia Derbey MIME-Version: 1.0 Subject: Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem References: <20080211141646.948191000@bull.net> <20080211141813.354484000@bull.net> <20080215215916.8566d337.akpm@linux-foundation.org> <47B94D8C.8040605@bull.net> <47B9835A.3060507@bull.net> <1203411055.4612.5.camel@subratamodak.linux.ibm.com> <47BB0EDC.5000002@bull.net> <1203459418.7408.39.camel@localhost.localdomain> In-Reply-To: <1203459418.7408.39.camel@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Matt Helsley Cc: subrata@linux.vnet.ibm.com, Andrew Morton , ltp-list@lists.sourceforge.net, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cmm@us.ibm.com, y-goto@jp.fujitsu.com List-ID: Matt Helsley wrote: > On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: > > > >>+#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ >>+ > > > It's not quite the maximum anymore, is it? More like the minumum > maximum ;). A better name might better document what the test is > actually trying to do. > > One question I have is whether the unpatched test is still valuable. > Based on my limited knowledge of the test I suspect it's still a correct > test of message queues. If so, perhaps renaming the old test (so it's > not confused with a performance regression) and adding your patched > version is best? > Yes, you're completely right. I'll resend a patch today. Regards, Nadia -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org