From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: Mel Gorman <mel@csn.ul.ie>, linux-mm@kvack.org
Subject: Re: [patch 6/8] slub: Drop fallback to page allocator method
Date: Sat, 16 Feb 2008 11:07:55 +0200 [thread overview]
Message-ID: <47B6A7EB.8060005@cs.helsinki.fi> (raw)
In-Reply-To: <20080215230854.391263372@sgi.com>
Christoph Lameter wrote:
> Since there is now a in slub method of falling back to an order 0 slab we no
> longer need the fallback to the page allocator.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> @@ -2614,7 +2585,7 @@ static struct kmem_cache *create_kmalloc
>
> down_write(&slub_lock);
> if (!kmem_cache_open(s, gfp_flags, name, size, ARCH_KMALLOC_MINALIGN,
> - flags | __KMALLOC_CACHE, NULL))
> + flags, NULL))
Did you fell asleep on the tab key? The indentation looks pretty crazy
right here ;-)-
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-16 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080215230811.635628223@sgi.com>
[not found] ` <20080215230853.165783772@sgi.com>
2008-02-16 8:12 ` [patch 1/8] slub: rename slab_objects to show_slab_objects Pekka Enberg
[not found] ` <20080215230854.890557911@sgi.com>
2008-02-16 8:46 ` [patch 8/8] slub: Make the order configurable for each slab cache Pekka Enberg
[not found] ` <20080215230853.397873101@sgi.com>
2008-02-16 8:55 ` [patch 2/8] slub: Add function to determine the amount of objects that can reside in a given slab Pekka Enberg
[not found] ` <20080215230853.705338997@sgi.com>
2008-02-16 8:57 ` [patch 3/8] slub: for_each_object must be passed the number of objects in a slab Pekka Enberg
[not found] ` <20080215230853.942719945@sgi.com>
2008-02-16 9:01 ` [patch 4/8] slub: Update statistics handling for variable order slabs Pekka Enberg
[not found] ` <20080215230854.132617990@sgi.com>
2008-02-16 9:06 ` [patch 5/8] slub: Fallback to order 0 during slab page allocation Pekka Enberg
[not found] ` <20080215230854.391263372@sgi.com>
2008-02-16 9:07 ` Pekka Enberg [this message]
[not found] ` <20080215230854.643455255@sgi.com>
2008-02-16 9:13 ` [patch 7/8] slub: Adjust order boundaries and minimum objects per slab Pekka Enberg
2008-02-16 19:00 ` Christoph Lameter
2008-02-16 20:20 ` Matt Mackall
2008-02-16 22:09 ` Christoph Lameter
2008-02-16 9:35 ` [patch 0/8] [RFC] SLUB: Variable order slab support Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B6A7EB.8060005@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox