From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <479F8F83.2030809@qumranet.com> Date: Tue, 29 Jan 2008 22:41:39 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [patch 1/6] mmu_notifier: Core code References: <20080128202840.974253868@sgi.com> <20080128202923.609249585@sgi.com> <20080129135914.GF7233@v2.random> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andrea Arcangeli , Robin Holt , Izik Eidus , Nick Piggin , kvm-devel@lists.sourceforge.net, Benjamin Herrenschmidt , Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com, Hugh Dickins List-ID: Christoph Lameter wrote: > On Tue, 29 Jan 2008, Andrea Arcangeli wrote: > > >>> + struct mmu_notifier_head mmu_notifier; /* MMU notifier list */ >>> }; >>> >> Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a >> regression (a minor one though). >> > > Andrew does not like #ifdefs and it makes it possible to verify calling > conventions if !CONFIG_MMU_NOTIFIER. > > You could define mmu_notifier_head as an empty struct in that case. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org