From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A534C433E1 for ; Thu, 2 Jul 2020 13:37:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41ABD207CD for ; Thu, 2 Jul 2020 13:37:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41ABD207CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7DC6A8D001A; Thu, 2 Jul 2020 09:37:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78CD78D0002; Thu, 2 Jul 2020 09:37:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A1C78D001A; Thu, 2 Jul 2020 09:37:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 51B5B8D0002 for ; Thu, 2 Jul 2020 09:37:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A9C091DEB for ; Thu, 2 Jul 2020 13:37:36 +0000 (UTC) X-FDA: 76993238112.13.dime55_561689226e89 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 5F2C218140B67 for ; Thu, 2 Jul 2020 13:37:36 +0000 (UTC) X-HE-Tag: dime55_561689226e89 X-Filterd-Recvd-Size: 2645 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Jul 2020 13:37:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8D555ADE4; Thu, 2 Jul 2020 13:37:34 +0000 (UTC) Subject: Re: [PATCH v6 5/6] mm/swap: implement workingset detection for anonymous LRU To: js1304@gmail.com, Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Mel Gorman , kernel-team@lge.com, Joonsoo Kim References: <1592371583-30672-1-git-send-email-iamjoonsoo.kim@lge.com> <1592371583-30672-6-git-send-email-iamjoonsoo.kim@lge.com> From: Vlastimil Babka Message-ID: <47989e98-ecd2-3ea8-871c-88583e55a4dc@suse.cz> Date: Thu, 2 Jul 2020 15:37:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1592371583-30672-6-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5F2C218140B67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/17/20 7:26 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > This patch implements workingset detection for anonymous LRU. > All the infrastructure is implemented by the previous patches so this patch > just activates the workingset detection by installing/retrieving > the shadow entry. > > Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka > diff --git a/mm/workingset.c b/mm/workingset.c > index 8395e60..3769ae6 100644 > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -353,8 +353,9 @@ void workingset_refault(struct page *page, void *shadow) > /* > * Compare the distance to the existing workingset size. We > * don't activate pages that couldn't stay resident even if > - * all the memory was available to the page cache. Whether > - * cache can compete with anon or not depends on having swap. > + * all the memory was available to the workingset. Whether > + * workingset competetion need to consider anon or not depends competition needs > + * on having swap. > */ > workingset_size = lruvec_page_state(eviction_lruvec, NR_ACTIVE_FILE); > if (mem_cgroup_get_nr_swap_pages(memcg) > 0) { >