Re: [PATCH 01/10] x86: Change size of APICIDs from u8 to u16

[Mike Travis <travis@sgi.com>]

Mel Gorman wrote:
> On (13/01/08 10:34), travis@sgi.com didst pronounce:
...
>>  int update_end_of_memory(unsigned long end) {return -1;}
>> @@ -343,7 +346,8 @@ int __init acpi_scan_nodes(unsigned long
>>  	/* First clean up the node list */
>>  	for (i = 0; i < MAX_NUMNODES; i++) {
>>  		cutoff_node(i, start, end);
>> -		if ((nodes[i].end - nodes[i].start) < NODE_MIN_SIZE) {
>> +		/* ZZZ why was this needed. At least add a comment */
>> +		if (nodes[i].end && (nodes[i].end - nodes[i].start) < NODE_MIN_SIZE) {
> 
> Care to actually add a comment? This looks like a note to yourself that
> got missed.

Oops, sorry, missed this the first time.

Actually that was a note from someone else and I didn't address it. 
(Weirdly, I had removed it but some quilt refresh demon brought it back. ;-)

We found this error in testing with a virtual BIOS but I think we
never figured out if it was an error in our BIOS or a valid error. 
But in any case, I'll fix it.

Thanks,
Mike

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>