From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <478BA872.60309@sgi.com> Date: Mon, 14 Jan 2008 10:22:42 -0800 From: Mike Travis MIME-Version: 1.0 Subject: Re: [PATCH 01/10] x86: Change size of APICIDs from u8 to u16 References: <20080113183453.973425000@sgi.com> <20080113183454.155968000@sgi.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Jan Engelhardt Cc: Andrew Morton , Andi Kleen , mingo@elte.hu, Christoph Lameter , Jack Steiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Jan 13 2008 10:34, travis@sgi.com wrote: >> --- a/arch/x86/kernel/mpparse_64.c >> +++ b/arch/x86/kernel/mpparse_64.c >> @@ -132,7 +132,7 @@ static void __cpuinit MP_processor_info( >> * area is created. >> */ >> if (x86_cpu_to_apicid_ptr) { >> - u8 *x86_cpu_to_apicid = (u8 *)x86_cpu_to_apicid_ptr; >> + u16 *x86_cpu_to_apicid = (u16 *)x86_cpu_to_apicid_ptr; >> x86_cpu_to_apicid[cpu] = m->mpc_apicid; >> } else { >> per_cpu(x86_cpu_to_apicid, cpu) = m->mpc_apicid; > > You can do away with the cast while modifying this line. Thanks! For some reason I had problems with the 'inter-section' referencing and this slipped in while addressing that problem. > >> --- a/arch/x86/mm/srat_64.c >> +++ b/arch/x86/mm/srat_64.c >> @@ -384,6 +388,12 @@ int __init acpi_scan_nodes(unsigned long >> } >> >> #ifdef CONFIG_NUMA_EMU >> +static int fake_node_to_pxm_map[MAX_NUMNODES] __initdata = { >> + [0 ... MAX_NUMNODES-1] = PXM_INVAL >> +}; >> +static unsigned char fake_apicid_to_node[MAX_LOCAL_APIC] __initdata = { >> + [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE >> +}; >> static int __init find_node_by_addr(unsigned long addr) >> { >> int ret = NUMA_NO_NODE; > > No u8/u16 here? Good point. Thanks, Mike -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org