From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33501C369BD for ; Wed, 16 Apr 2025 14:39:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9EB66B0290; Wed, 16 Apr 2025 10:39:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4D716B0291; Wed, 16 Apr 2025 10:39:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C14286B0292; Wed, 16 Apr 2025 10:39:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A33CF6B0290 for ; Wed, 16 Apr 2025 10:39:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 16857160487 for ; Wed, 16 Apr 2025 14:39:55 +0000 (UTC) X-FDA: 83340166350.01.4659DD4 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id A53E04000B for ; Wed, 16 Apr 2025 14:39:52 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AryvKFhi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Dpf65gFj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AryvKFhi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Dpf65gFj; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744814393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RLi331sN5ip6RGEh/ki6qgktOXffAwJ91DpfOXL038w=; b=Il7WdSeXEKyS3L2zukJMqMpa25dLp33Jvf5ushiI17p3BYycnPtijK7xxvtHjmv56Urycq SXT1CDwURTmOBwZZfDW/tsHhFmCs0cwpBG2xwfQq2sWJxrDPR9TofXGEw7+stWZT/9t5R/ 7KHjfbRtyMeLQeDQY8D3ygbnpv0uJcs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AryvKFhi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Dpf65gFj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AryvKFhi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Dpf65gFj; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744814393; a=rsa-sha256; cv=none; b=QYYIff0iCBPj7ZW0MD96/Z6KCtt6dLZCWEoNFo6y851sGPhbuphMcvNVkCuMK1ifS/hdNA su6j0VcSVdpcWDA5z6fHT3SqFQtmBOJE2p+v0xLqdFbK6ghy7mhgDiFhbHs1K6rX3+6KuS Y0NLIo9WphZmKeI6LziYr1eDvg8QB6s= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C47941F6E6; Wed, 16 Apr 2025 14:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744814390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RLi331sN5ip6RGEh/ki6qgktOXffAwJ91DpfOXL038w=; b=AryvKFhitmo9kIsFuEaJ+YZkL3oFlpwFgazpBWpuW25HgCApUNGbdNoLpsQfI7CWgv5Tk3 lXtqjTWMBRQ94eD27QgQRX09Mrezbfxqe97WvWvgirlkr6NiVj/Vjmp6eoxAKmvyhGikJ/ QqcNKQzUeas2j8cAnzoyTKqZuD+zru0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744814390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RLi331sN5ip6RGEh/ki6qgktOXffAwJ91DpfOXL038w=; b=Dpf65gFj15PgpFO3N3gkjTIErz92k9TrTi5aM5179k0Th0QDJnBbDvxLRHKeqJs6SVtl37 gp5XsqiJ+AXwauCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744814390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RLi331sN5ip6RGEh/ki6qgktOXffAwJ91DpfOXL038w=; b=AryvKFhitmo9kIsFuEaJ+YZkL3oFlpwFgazpBWpuW25HgCApUNGbdNoLpsQfI7CWgv5Tk3 lXtqjTWMBRQ94eD27QgQRX09Mrezbfxqe97WvWvgirlkr6NiVj/Vjmp6eoxAKmvyhGikJ/ QqcNKQzUeas2j8cAnzoyTKqZuD+zru0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744814390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RLi331sN5ip6RGEh/ki6qgktOXffAwJ91DpfOXL038w=; b=Dpf65gFj15PgpFO3N3gkjTIErz92k9TrTi5aM5179k0Th0QDJnBbDvxLRHKeqJs6SVtl37 gp5XsqiJ+AXwauCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ADB39139A1; Wed, 16 Apr 2025 14:39:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BcsVKjbB/2e5UQAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 14:39:50 +0000 Message-ID: <4782b071-6008-4fd1-b762-65a575dc333a@suse.cz> Date: Wed, 16 Apr 2025 16:39:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: move mmap/vma locking logic into specific files Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , "Paul E . McKenney" , SeongJae Park , Shakeel Butt , David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: no4myajbjnxwfchciu3ftw3q5p3sq6yh X-Rspamd-Queue-Id: A53E04000B X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1744814392-649607 X-HE-Meta: U2FsdGVkX19X89YusLLzgQCkiXdzNrC6LEXPGSfXhJEnqOw3KETTSAZfVDYPm3foL8+8yd66v3WVGkODD4A2SsGUkqiPIGziaGQHHUguSxFi14eml1AIJb9nxc2eqASzcyM7HGmNDjc4s3FrBApsHcbI2O6snen21mONmXAIWq7sx/i90OlIqFzE2iYbCDnO/9lfvPNhlY6x8kIxaK5eOk9ORxuFYhexarq8QOdEexs7mw0zFqb3A2LvEkJ2vut0wXJdyWiQABNFYHmsKDgo883H//ixXygPT6NSHnw39ZYwpfu8FZdpKXDVWt44kn13M9faP7PabXRNr3ZqIr65OxN1ZNdgfXpQ7gssVAtBSiHTuz6pKC3iE27v86e08lGBj6IvspodNfmGevyVLAgD45rKNAp+5Bo8CEuVBaU14/xwSoUBLnRuarvyonAHCon0Jrlzutqp/IqafxLZJeTcAxjsXMGe+m6LJyZKTKkBf/BCUgmaBLhQ4G4wbbLbOerjUsOOQODNJe0tW4G6+R2pImQfxNx94vadcPA46XiVgWcpB6GCd1n6FxbSUQnZJ9pUt5LGvKqSVAekZ3UY+GsZsmdmbZlriJor/ArDbw+yOdX7MUywR+vIEUIiKmXySZSgX6wlGxEkNUOh9gPFzOaRIqLUvNWxClN0qKjy/c5pspxV8QbrfjcxdA7Ebv7Cgef8LMVH1aRYm+4ugEYZ/nPHoSiRlwAFiyQoKA9BLR86O7DI53/QrcycuEmpxiibYsNUt8fnOCKI5xFaTn15CgcQg5kODjDX1t8ZQ3Tw6oOb9GNM4aptcsfp8OhZP6FW16Yc/RXiP2Ieyaom6YZqF6htZMuYdQvSu9tKnMWeSzALDhB0y64RA1FYJKvM/xhZw7CFy88TEBTIevJjWFrv9NayCVAmfobgUGoT3MW+qEuS7Ry0SWEQEv+/dBxJg+5BHuVivytfR3fSXJWngDQjLUn /CA8uahw 5MUhMd+23mkPqIiT/mw+vzCvi4PtW1yPfDPHXEJ57wKgXPFhoSaaMJquj82QYPbGx1vXKvHCpD0NKGQaNZOaNKm/s2xF0hg+jxnGagDyvtAgHejCwB21bY31COfUoTBhpbAphhrThKF6sm1R7JB5STgT3EBIWmyc9fE5tw09vZpI55fowqoSqG/hlGqRwtf4fEKdDIJ1XrMDbC56l58fcabXxU8G5YHlo+2aVsQtSYg0DJd85O6dvLCSxZeXpPFNXDBgES06/C488OMW+uOD0XAZHBErrm5bOmhIwTvC7wDjiblOasndJ0b7aLrqQxTsfja1sN3R6+K8yiXJcqFdVgVauWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/16/25 12:38, Lorenzo Stoakes wrote: > Currently the VMA and mmap locking logic is entangled in two of the most > overwrought files in mm - include/linux/mm.h and mm/memory.c. Separate this > logic out so we can more easily make changes and create an appropriate > MAINTAINERS entry that spans only the logic relating to locking. > > This should have no functional change. Care is taken to avoid dependency > loops, we must regrettably keep release_fault_lock() and > assert_fault_locked() in mm.h as a result due to the dependence on the > vm_fault type. > > Additionally we must declare rcuwait_wake_up() manually to avoid a > dependency cycle on linux/rcuwait.h. > > Additionally move the nommu implementatino of lock_mm_and_find_vma() to > mmap_lock.c so everything lock-related is in one place. > > Signed-off-by: Lorenzo Stoakes > Reviewed-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka > diff --git a/mm/mmap_lock.c b/mm/mmap_lock.c > index e7dbaf96aa17..5f725cc67334 100644 > --- a/mm/mmap_lock.c > +++ b/mm/mmap_lock.c > @@ -42,3 +42,276 @@ void __mmap_lock_do_trace_released(struct mm_struct *mm, bool write) > } > EXPORT_SYMBOL(__mmap_lock_do_trace_released); > #endif /* CONFIG_TRACING */ > + > +#ifdef CONFIG_MMU > +#ifdef CONFIG_PER_VMA_LOCK CONFIG_MMU is implied by CONFIG_PER_VMA_LOCK so you could move the first #ifdef later to make only #ifdef CONFIG_LOCK_MM_AND_FIND_VMA nested in it. But doesn't matter that much.