From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D58CD1292 for ; Thu, 4 Apr 2024 11:23:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3B696B0082; Thu, 4 Apr 2024 07:23:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEB186B0083; Thu, 4 Apr 2024 07:23:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DA1E6B0087; Thu, 4 Apr 2024 07:23:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 804956B0082 for ; Thu, 4 Apr 2024 07:23:49 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 38CF61A1009 for ; Thu, 4 Apr 2024 11:23:49 +0000 (UTC) X-FDA: 81971614578.07.E1E4A4E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 77C411A0017 for ; Thu, 4 Apr 2024 11:23:46 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712229826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g8iQnTfzDJANg2JwCLMoQDhXzEv+8PES8GT9f90c9Oo=; b=dvSnnG9+DkIb/CdsmNnleeabQ0erli1BTkQC6muMLGohSBj5bBtMqKIWTqYdfPpJkue7R9 Nx8qpP9V+bkgTsMXuXTPohshYKMr7iTwqmHz8sTzIFBsALfzmDm5S1xda1raTrYkWV294G dvkAKWzeRruo6usxoaxhSHyKOn3/YYY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712229826; a=rsa-sha256; cv=none; b=AEt8JMMAB7uCrpKRtsZOuPIQZSyxs8KdWI3IUM+IGhMBRgkyuI8gvWZEciozc3ETL+uI5d tm7Vw69QmiTqX9XQJk5Hp60TejSieQUHnzzfOfifHgOxr6vvceNjfmSi9I0KD9B4dT/m/R uS3VNdQccK6Y90eOEl1/przTt6Y9BWE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 28802FEC; Thu, 4 Apr 2024 04:24:16 -0700 (PDT) Received: from [10.1.32.162] (XHFQ2J9959.cambridge.arm.com [10.1.32.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8FF333F7B4; Thu, 4 Apr 2024 04:23:44 -0700 (PDT) Message-ID: <476ef488-5f3c-420d-97ea-bb281f2891f2@arm.com> Date: Thu, 4 Apr 2024 12:23:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] WARNING: bad unlock balance in madvise_cold_or_pageout_pte_range Content-Language: en-GB To: syzbot , akpm@linux-foundation.org, david@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com References: <000000000000b92a9d0615433065@google.com> From: Ryan Roberts In-Reply-To: <000000000000b92a9d0615433065@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 77C411A0017 X-Stat-Signature: 3h7neickyiczn7h9shaqufuqu9du17b6 X-HE-Tag: 1712229826-422776 X-HE-Meta: U2FsdGVkX1/doCxoiohLUzS7KUZIMSJXyseuRSxG5VTc6DFa8BsGSTcpnImxs8RKXiga076DrRGuS1ZfPONgDqUfvcJWK6q7baq9WCRnGt3guqoL99JFPTqUJQqCMeahXRwH4dD3CETuKGAnWk2yJxNiEjdsvhve3wr/eY6WlwSTHrb0z2YjkymhM7wetFTX20Fe+9FCxE0ht/xcdxt9kiFp4iLx+HuHCbyw1BXaWtmBE8FRy83xn7Mvk3Ka76nBeZ0EFmTRXGc/+7pRi85d7nUb8wmEMLcArpW5ZKrULa6oXwU1u29DSWxRw8XJFJBHMnqQQ8nSQOyfrwlMzLJu/BOtgqeuHrerMai1viPfufAh7jIK+9AirVvJiO+dGC5vyIwfFIVrxijtyv4YJvs47dMtaeiaBKKuLpjrbHRzx+uQD9YmlJ3ZPhy79TcMAxFBDOk55oaNAf1d1NutLTYTBeKPM40INtdMpzp6+vasmxZta7/fJtqlZHdR8qNufNe9yI1ZMvHfmJOUXjz3bYefykScSMn9ldNMjLqouugIR83iWNf/GTsF2FxvMkHLiNt26pHDh7mDZDcD/bXtGvBX1YLkr4e9ofBFZ9wNDT8gUGfBeWKrgju+0jPrzBsj3wJdIDnB4fwX0bg206bx1BQ143KFlyPL3dRyNKi6ujJFtrZaE8p4/K3WfW4iCTW2VgLXNQkHGkU6y2klwDABQmH2hgngzzK/EH3lPhxYdTblPHNYomtHynJ+gJwGEg1aI1zNF29rlS4mqilWnSUzEE1lXWeIoIQv/QhW5urDbjXjM3PxLinaVrdTqXX3rSzzcPBgOZ9rPuN/S4gu/CBa7Sjsl6kTZCDbIw5YZwg3nqRiWRlGbVl0Wq34IqXZ33RTsZE+Ryhdd03dVxauzwcIXf1mUU4NJvWMBgycHcDvgbcRaqDinPNxEUOInJnTDKn4tna+VsE++mW6a8yJZbISY05 9nZbD+Jh bIDUdFyuvQukGZ0TcHovnZtN8YKEkwouf7rarSudCObh9oNcPRMISmmaE/7dee1w5cwr5w3svusKXq5bPg4ZyzEHWHTOYNF//QBSOLNwQKzkdguBnEJ4buEXU5Evsy9n3vZsG89m8yOUnXkX1970NPLKoRlGlrTcujpLET7CgXtoKKUOG2Or2iRG1hND+nsF1CRpDZQaYR0WxGX0K5cVk0163FcBDA7ink0ekmOZTFA/VRf6ZI5oUZPD8QQbwDHZFk0YGEc1q7y3W6bZuQtGgwdOxqS8uQ9YCZZsPnCTYyiVPDsdHl5SokRqjj9ejI0DVrapWQ5r05/H2572lzRGx6BvB27DGi/oe3MbnEw/O46lB6/Bx1UXyBXlqw01Nk/AFODeT7XfDsmnbSyTrdD8e1cJumbfsn0UrTRy/wE+/+SnTXmW8g6LKVWZaOW2de4qWrVOzQ2PQ52OOk92LjOAu45yI6SlyQBMdCjXx++eFZ9ta1g1lejDPXUF+e1jwBDjVRjr2JBG+kQ6CaYVouDsMTeYF6Fezz6X4uSjciLwNq2RdNQ7rCbby6WRz4y/8+nqmLonL6zt/iImnkRjKQqCSRgIG8jrdArOfa4dQK3grrHVA1Z4/P+YV0mYkhIgPoVhmZoFCarj76EaGlKQjH4tPF9HIod4d6R3mmcw0er+sIRCHdkQNhy4KijCTycBxmzD2PSaSspNws3dxWQ0oW6IPhBrdVaFVXE+GkcyKkmgFzDYVbcYTtqFK/VfzRhvw3QkIHvCdL5wjszMV+gmXADYEOPRA4FkJSmcQlPskk5OhUj7BD+WRz2ISxQCKWlDYX+tTHeZz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm mm-unstable mm-unstable now has the fix; let's check it actually fixes the problem. On 04/04/2024 11:56, syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit: 727900b675b7 Add linux-next specific files for 20240403 > git tree: linux-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=11f66223180000 > kernel config: https://syzkaller.appspot.com/x/.config?x=afcaf46d374cec8c > dashboard link: https://syzkaller.appspot.com/bug?extid=c641706ad4e9688cccdf > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12a62423180000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13764a3d180000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/f8fb4daa7a83/disk-727900b6.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/d2a6994aee53/vmlinux-727900b6.xz > kernel image: https://storage.googleapis.com/syzbot-assets/6759e5411c39/bzImage-727900b6.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+c641706ad4e9688cccdf@syzkaller.appspotmail.com > > ===================================== > WARNING: bad unlock balance detected! > 6.9.0-rc2-next-20240403-syzkaller #0 Not tainted > ------------------------------------- > syz-executor799/5099 is trying to release lock (ptlock_ptr(ptdesc)) at: > [] spin_unlock include/linux/spinlock.h:391 [inline] > [] madvise_cold_or_pageout_pte_range+0x170f/0x3990 mm/madvise.c:480 > but there are no more locks to release! > > other info that might help us debug this: > 1 lock held by syz-executor799/5099: > #0: ffff888015073a98 (&mm->mmap_lock){++++}-{3:3} > , at: mmap_read_lock include/linux/mmap_lock.h:144 [inline] > , at: do_madvise+0x481/0x44a0 mm/madvise.c:1429 > > stack backtrace: > CPU: 1 PID: 5099 Comm: syz-executor799 Not tainted 6.9.0-rc2-next-20240403-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 > Call Trace: > > __dump_stack lib/dump_stack.c:88 [inline] > dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 > print_unlock_imbalance_bug+0x256/0x2c0 kernel/locking/lockdep.c:5194 > __lock_release kernel/locking/lockdep.c:5431 [inline] > lock_release+0x599/0x9f0 kernel/locking/lockdep.c:5774 > __raw_spin_unlock include/linux/spinlock_api_smp.h:141 [inline] > _raw_spin_unlock+0x16/0x50 kernel/locking/spinlock.c:186 > spin_unlock include/linux/spinlock.h:391 [inline] > madvise_cold_or_pageout_pte_range+0x170f/0x3990 mm/madvise.c:480 > walk_pmd_range mm/pagewalk.c:143 [inline] > walk_pud_range mm/pagewalk.c:221 [inline] > walk_p4d_range mm/pagewalk.c:256 [inline] > walk_pgd_range+0xba1/0x1810 mm/pagewalk.c:293 > __walk_page_range+0x132/0x720 mm/pagewalk.c:395 > walk_page_range+0x58f/0x7c0 mm/pagewalk.c:521 > madvise_cold_page_range mm/madvise.c:562 [inline] > madvise_cold mm/madvise.c:584 [inline] > madvise_vma_behavior mm/madvise.c:1028 [inline] > madvise_walk_vmas mm/madvise.c:1256 [inline] > do_madvise+0x1e7b/0x44a0 mm/madvise.c:1442 > __do_sys_madvise mm/madvise.c:1457 [inline] > __se_sys_madvise mm/madvise.c:1455 [inline] > __x64_sys_madvise+0xa6/0xc0 mm/madvise.c:1455 > do_syscall_64+0xfb/0x240 > entry_SYSCALL_64_after_hwframe+0x72/0x7a > RIP: 0033:0x7f3928ac2419 > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007f3928a5c218 EFLAGS: 00000246 ORIG_RAX: 000000000000001c > RAX: ffffffffffffffda RBX: 00007f3928b4c318 RCX: 00007f3928ac2419 > RDX: 0000000000000014 RSI: 00000000dfc3efff RDI: 00000000203c1000 > RBP: 00007f3928b4c310 R08: 00007ffd7796b097 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 00007f3928b19064 > R13: 000000080000000e R14: 000000200000007f R15: 00000000dfc3efff > > ------------[ cut here ]------------ > pvqspinlock: lock 0xffff88802ec45b40 has corrupted value 0x0! > WARNING: CPU: 1 PID: 5099 at kernel/locking/qspinlock_paravirt.h:510 __pv_queued_spin_unlock_slowpath+0x241/0x2f0 kernel/locking/qspinlock_paravirt.h:508 > Modules linked in: > > CPU: 1 PID: 5099 Comm: syz-executor799 Not tainted 6.9.0-rc2-next-20240403-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 > RIP: 0010:__pv_queued_spin_unlock_slowpath+0x241/0x2f0 kernel/locking/qspinlock_paravirt.h:508 > Code: 85 0a 6e f6 4c 89 f0 48 c1 e8 03 0f b6 04 18 84 c0 0f 85 9f 00 00 00 41 8b 16 48 c7 c7 c0 26 cb 8b 4c 89 f6 e8 40 b3 cb f5 90 <0f> 0b 90 90 eb 8d 44 89 f1 80 e1 07 38 c1 0f 8c 26 ff ff ff 4c 89 > RSP: 0018:ffffc9000364f238 EFLAGS: 00010246 > > RAX: 9a7270b7f8439200 RBX: dffffc0000000000 RCX: ffff888023139e00 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > RBP: dffffc0000000000 R08: ffffffff81580152 R09: 1ffffffff1f526cd > R10: dffffc0000000000 R11: fffffbfff1f526ce R12: 1ffff11005d88b6a > R13: ffff88802ec45b50 R14: ffff88802ec45b40 R15: ffff88802ec45b40 > FS: 00007f3928a5c6c0(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000561c1eec8018 CR3: 00000000213dc000 CR4: 00000000003506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > __raw_callee_save___pv_queued_spin_unlock_slowpath+0x15/0x30 > .slowpath+0x9/0x16 > pv_queued_spin_unlock arch/x86/include/asm/paravirt.h:589 [inline] > queued_spin_unlock arch/x86/include/asm/qspinlock.h:57 [inline] > do_raw_spin_unlock+0x13c/0x8b0 kernel/locking/spinlock_debug.c:142 > __raw_spin_unlock include/linux/spinlock_api_smp.h:142 [inline] > _raw_spin_unlock+0x1e/0x50 kernel/locking/spinlock.c:186 > spin_unlock include/linux/spinlock.h:391 [inline] > madvise_cold_or_pageout_pte_range+0x170f/0x3990 mm/madvise.c:480 > walk_pmd_range mm/pagewalk.c:143 [inline] > walk_pud_range mm/pagewalk.c:221 [inline] > walk_p4d_range mm/pagewalk.c:256 [inline] > walk_pgd_range+0xba1/0x1810 mm/pagewalk.c:293 > __walk_page_range+0x132/0x720 mm/pagewalk.c:395 > walk_page_range+0x58f/0x7c0 mm/pagewalk.c:521 > madvise_cold_page_range mm/madvise.c:562 [inline] > madvise_cold mm/madvise.c:584 [inline] > madvise_vma_behavior mm/madvise.c:1028 [inline] > madvise_walk_vmas mm/madvise.c:1256 [inline] > do_madvise+0x1e7b/0x44a0 mm/madvise.c:1442 > > > --- > If you want syzbot to run the reproducer, reply with: > #syz test: git://repo/address.git branch-or-commit-hash > If you attach or paste a git patch, syzbot will apply it before testing.