From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25440C433EF for ; Wed, 6 Oct 2021 12:09:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B268561154 for ; Wed, 6 Oct 2021 12:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B268561154 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1C43D6B0071; Wed, 6 Oct 2021 08:09:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17572940007; Wed, 6 Oct 2021 08:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03C506B0074; Wed, 6 Oct 2021 08:09:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id E83086B0071 for ; Wed, 6 Oct 2021 08:09:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 951253232F for ; Wed, 6 Oct 2021 12:09:09 +0000 (UTC) X-FDA: 78665892018.10.667E1CC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 283FDF002417 for ; Wed, 6 Oct 2021 12:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633522148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jDEUDd9F1mbhCTF+9tuTd3gtq0vD73lOJfICp/hOhTQ=; b=M3WEkrrJivVbGlYA5OBt8pGKOemIzN3unuJwQhVZ6SZV+VHUztdxxtOJ0wW7jAV0ywCNbv 9/jHii6WzSCE3PJBRs0MTeWMvYwhdsOg1NrZbcEv89V0KfnB9LneUsBtTPKnnWXDIaDCr1 fYV3qwZWiVoSYGqIEiqx/ScsITbs1Es= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-MWOqM3ZfOSC2cKcdExxEZQ-1; Wed, 06 Oct 2021 08:09:07 -0400 X-MC-Unique: MWOqM3ZfOSC2cKcdExxEZQ-1 Received: by mail-wr1-f71.google.com with SMTP id r16-20020adfbb10000000b00160958ed8acso1849522wrg.16 for ; Wed, 06 Oct 2021 05:09:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=jDEUDd9F1mbhCTF+9tuTd3gtq0vD73lOJfICp/hOhTQ=; b=QVT82RaDMMBrradNxSHiXr0DH24tkOwpfNWK/qWIQjV67O9CNAd9LGJMeiWY+/f41t yHrlZDf43GukYlLa2plRFN4qthtJ/2tZ1kCkTwQNv2NYQTX8623tBxOzVcbEsUDwlgMs OZNrudTWM1fNsrtiNRQIcMYxei/dSNt1hmSl6xWqgediheD7usg2YR0m0JGoumv5nZ0u dX4+tqsMBRqr72lx021SR0aZK/vOj9FlsKx9sF4e/aX7glI/QGQEvY0FaU/qob1nkxZg i/p0t0wSV+VOL55BXIUtad/+Uy1a/DoRTj2KpfpATkX5sliDjg24rxx1Pc2FWHmf+lAM d3Jg== X-Gm-Message-State: AOAM530LiZcXvDtzo+D4i4YwMpbwtrsqtKMb68SMuBa4O0/AKvuY7Hyg KNyx7fkQJgLM9HWZmcucAotn0gS65k2sL3ZUirdvzToBPKiDPFEKTgFTIfEisgQEtdsPq7rgSLw TCOFTxHIiges= X-Received: by 2002:a1c:7910:: with SMTP id l16mr7955156wme.128.1633522146050; Wed, 06 Oct 2021 05:09:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4TYB1Jy2IgydUW9bzfNSEGzwXaUBnXnryugqaajvIbJbmW6pSZbAoUR1gTE+cTlIL/XV4wA== X-Received: by 2002:a1c:7910:: with SMTP id l16mr7955111wme.128.1633522145736; Wed, 06 Oct 2021 05:09:05 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6529.dip0.t-ipconnect.de. [91.12.101.41]) by smtp.gmail.com with ESMTPSA id r19sm4680282wmp.43.2021.10.06.05.09.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Oct 2021 05:09:05 -0700 (PDT) Subject: Re: [PATCH] memory: remove unused CONFIG_MEM_BLOCK_SIZE To: Lukas Bulwahn , Andrew Morton , Michal Hocko , Dave Hansen , linux-mm@kvack.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211006120354.7468-1-lukas.bulwahn@gmail.com> From: David Hildenbrand Organization: Red Hat Message-ID: <476ea5f7-53be-1a4e-c461-ff2e4a359bd0@redhat.com> Date: Wed, 6 Oct 2021 14:09:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211006120354.7468-1-lukas.bulwahn@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 283FDF002417 X-Stat-Signature: o9g6sypjbpwwqt8agq6iwt9omt4ii9je Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M3WEkrrJ; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf11.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1633522149-285373 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.10.21 14:03, Lukas Bulwahn wrote: > Commit 3947be1969a9 ("[PATCH] memory hotplug: sysfs and add/remove > functions") defines CONFIG_MEM_BLOCK_SIZE, but this has never been > utilized anywhere. > > It is a good practice to keep the CONFIG_* defines exclusively for the > Kbuild system. So, drop this unused definition. > > This issue was noticed due to running ./scripts/checkkconfigsymbols.py. > > Signed-off-by: Lukas Bulwahn > --- > include/linux/memory.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/memory.h b/include/linux/memory.h > index c46ff374d48d..a216829df280 100644 > --- a/include/linux/memory.h > +++ b/include/linux/memory.h > @@ -143,7 +143,6 @@ typedef int (*walk_memory_blocks_func_t)(struct memory_block *, void *); > extern int walk_memory_blocks(unsigned long start, unsigned long size, > void *arg, walk_memory_blocks_func_t func); > extern int for_each_memory_block(void *arg, walk_memory_blocks_func_t func); > -#define CONFIG_MEM_BLOCK_SIZE (PAGES_PER_SECTION< > extern int memory_group_register_static(int nid, unsigned long max_pages); > extern int memory_group_register_dynamic(int nid, unsigned long unit_pages); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb