Re: [PATCH] memory: remove unused CONFIG_MEM_BLOCK_SIZE

[David Hildenbrand <david@redhat.com>]

On 06.10.21 14:03, Lukas Bulwahn wrote:
> Commit 3947be1969a9 ("[PATCH] memory hotplug: sysfs and add/remove
> functions") defines CONFIG_MEM_BLOCK_SIZE, but this has never been
> utilized anywhere.
> 
> It is a good practice to keep the CONFIG_* defines exclusively for the
> Kbuild system. So, drop this unused definition.
> 
> This issue was noticed due to running ./scripts/checkkconfigsymbols.py.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>   include/linux/memory.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index c46ff374d48d..a216829df280 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -143,7 +143,6 @@ typedef int (*walk_memory_blocks_func_t)(struct memory_block *, void *);
>   extern int walk_memory_blocks(unsigned long start, unsigned long size,
>   			      void *arg, walk_memory_blocks_func_t func);
>   extern int for_each_memory_block(void *arg, walk_memory_blocks_func_t func);
> -#define CONFIG_MEM_BLOCK_SIZE	(PAGES_PER_SECTION<<PAGE_SHIFT)
>   
>   extern int memory_group_register_static(int nid, unsigned long max_pages);
>   extern int memory_group_register_dynamic(int nid, unsigned long unit_pages);
> 


Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb