From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DE1C77B76 for ; Fri, 21 Apr 2023 22:25:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E56686B0071; Fri, 21 Apr 2023 18:25:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E066B6B0075; Fri, 21 Apr 2023 18:25:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCDC86B0078; Fri, 21 Apr 2023 18:25:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BB9AC6B0071 for ; Fri, 21 Apr 2023 18:25:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D6A014045B for ; Fri, 21 Apr 2023 22:25:03 +0000 (UTC) X-FDA: 80706829686.23.B6E6B1B Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf28.hostedemail.com (Postfix) with ESMTP id 81FCCC0003 for ; Fri, 21 Apr 2023 22:25:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=oerIEMuV; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682115901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wtOk22wHsRTIJLakW5pQsLDvU50er+NeXN7SxTWy9qk=; b=YHOihpNTO+Nqst7TgJqRu8iSqcgtm2I4tl1FxVWA1gUYpfa59f/xnBwHEND5xYkC8yE7dA /IwfF8m8TB/5MpkWPXP4ZtaiZrxmP1vK+ZlJRa83w6VvnAWgNGzXNXgWj1nGo12LPc9q/g vOdSXJlzDhxlVHru8b7ok22nWblv4dA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=oerIEMuV; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.171 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682115901; a=rsa-sha256; cv=none; b=MZEfJrvV2NsMZ+QFV14ruPXRQt26XRCLyBPm13D4Jss2j0gg5yplXMo+1gKJ/Hd5BS4BrZ quJgir34MHLoWQ4DP5QbEpKkrkEiE+dOnhsVM8bEUOI6QElCvYOUSy2GZtjSAD1YFMPusW rizDvbLi/nYxmviUOfMzeesN6GiO/YM= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1a7111e0696so5461735ad.1 for ; Fri, 21 Apr 2023 15:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1682115900; x=1684707900; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wtOk22wHsRTIJLakW5pQsLDvU50er+NeXN7SxTWy9qk=; b=oerIEMuVGMo3tf7ainFnGShOU4ymhQn2JIZkQ5ZB4LQezPNmDezHZ74CsaeAZJQpD6 fBOri4QsdRMaGb2stkX1WSwEZwfrNh9aQZWqyNJoXurA5LawSG0y1G2Xv1oUcyhDfcMp 9sbYCkZuE9eli+qnK9IsSiSsdVJHCJSw/W3sMGWPje4NFX463I+v+t7Es1rrOVfCvCrD U9gO5mnakr3a3I+Qu1a4NVVPqGjSfvWoKTJthz4c4dgYea4zYEHowFeYEbZOiF95SR+K Jq4c5WzqI8i0UVXC3OJDP1Rl9oKvaB8DuqRz1pK4f1u8wkRZdFtR2Oi36akQy0CVWjt4 77tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682115900; x=1684707900; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wtOk22wHsRTIJLakW5pQsLDvU50er+NeXN7SxTWy9qk=; b=VCeA/kdYUlIb62UAzTwE647+4/pKfFPW9P0wEOqAuydpT/7M4WrF5HhjJTvYtUqL7t QdGL7WgH6OWvty4xfgVC1qL34O2IOWi+PsyiIXwoOxnoTqnEaW4hRjZ/me4WMF+yc5Sd SoOF3lEVEEBtXBCixk2OglPnU7Iw5qAU9GW78/hpiHjJjy4NaT7dW+AXp5TJgWQtStHJ 8TmQ5J02aIyBO24qfjIXRsv+nE4bEpde0wIxT7rYRAnoDqBDxssDiT3xInn1a+g7PO0s ePY7PjhEw7W9e8N2DjFtgph++NwWwrM3V2Q+eH0HVVzL1COXUHOaX2l8v8VOYz6M1oq6 IbDg== X-Gm-Message-State: AAQBX9fnq2ubdycvsfo/D5FSX47JECnOMXcIXepmtwiqYtKMol5RmYnn kBSi+5z4htTSnx4Lb4U1Nmop8A== X-Google-Smtp-Source: AKy350ab5zsgqMFX9gmLPlFbJI6JNwFXd5UcuHSryHmhAdUudcIDmmGg6bERrDL3LQkvBwimuDuVEg== X-Received: by 2002:a17:902:c94f:b0:1a2:1a52:14b3 with SMTP id i15-20020a170902c94f00b001a21a5214b3mr7699856pla.4.1682115900155; Fri, 21 Apr 2023 15:25:00 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id jn15-20020a170903050f00b001a945e7147asm1657335plb.231.2023.04.21.15.24.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 15:24:59 -0700 (PDT) Message-ID: <47688c1d-9cf1-3e08-1f1d-a051b25d010e@kernel.dk> Date: Fri, 21 Apr 2023 16:24:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Content-Language: en-US To: Luis Chamberlain , Matthew Wilcox Cc: agk@redhat.com, snitzer@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, hch@infradead.org, djwong@kernel.org, minchan@kernel.org, senozhatsky@chromium.org, patches@lists.linux.dev, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, kbusch@kernel.org References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-4-mcgrof@kernel.org> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: ez5xaok8erh7r7qqrmybh4si85hk958o X-Rspam-User: X-Rspamd-Queue-Id: 81FCCC0003 X-Rspamd-Server: rspam06 X-HE-Tag: 1682115901-895185 X-HE-Meta: U2FsdGVkX18mn2l2mLVOND+shIaNqmBk0O3rcTAvuetbhXYcGVLpgBOMAOLdj8EhE0KBxLCfqrz+M8OjfzWyTNCZMAZp3IETdGpgBQ6va++9LUxvVLU8Q74/TT9/TH2QIkPbZqvNUn4lEO1V26M/7P0FBFJl41IGsPdwlk63WUfZ8htUXEkaPN8bDDozgmgiaFUYovEXtTySn38zvahvoB76fZB/Me1Pv1V5v3BWRZ6olFckh+9AV+TKVC2tRTEwIZlpSexvo78QLp3q46pdgzFhlgxNT8KsJotx6YyUCE/noFLa7+9nFHiMtax0ESDY3HtW7YeE2gc5Q6BFAdkMsqQvx3TsY+KAaaDet4h3dnsoSNVKHFxt23lJ19Yjv4yVJmh3DgV4KqKjrTVsgRHp41nLFgQewt3kY0RqYoiNUSkwlXMunkdFlMWlquTX13HFnDVx79QcTqJaCAphalADr8T9Hua3l5JwA74iYI7Lw8SNSVGDtINeTxiYgr2ZdCyRYG+0NKJYw4BR/PROnrWsLwty1o40zDIAAxNtc0ceNRzaGTphGQullwhoAvDqnySy/pVdyCzUZo6yZm+D5fBmsF3L3GwtLjdMvr2zZsBll0DA5ZyaPeF8vZmQwSsswQg/iUT1fAGCY8B0z1dVW796/Omr/4Pqfld0KdMp+JgZ7kgvoWt/yG+b7LE0812JENZnZ11dtTuhncCHluVsCAZyoKM2JIICn8az1b88w747kbNsFsvXlsbtk7Ck4drehj7gn+jebKDhST6+tCtKxbHLfcAXmNoGhTVnNteiEd0t1dhUE0eUAUAj48aBAhv/S/CvwBwrdGvUQHGbYTluo49TmVXRdHCKT3DZ1kHj9Pl8llM4wDktWaV+TTDLvEe9gpx1tSDTSBsemlLBzzrzlKgPOIvRb/DJwnRaf+eVzTCIGt5+T5bcCkGy7r7nZhpJudnY/0EMY6cNOUcDl0OqiUK 5hZ+GcXH lEHb4BAoUQ8+BYT6XWk30IIlQo6j32O8g1mV3cS0C5YzkilACcWY6dURr+glSyUuXaGwtBZAz8l4Vzz0EE1PFOSEdxgMkAg5pyrnPt/Cs/aRf6Ilj037ysrGylxVFMKtCMJMQ6iA5wcS1TE1p+YwMSBkiwdXgXNFO3cdVOhM1zcDkhSKX31/d/ToOT713F1Hvyo4g/LrKOpOUwW+3Ps4m9bINfREZ0OFxkLjGeFjs6SB68BNi7Wlj1+VQTaIrEU9an4jK35wBiO/96IoyAvbqPHIp/09KTonvhMJumxZ0Wc/eEdjtB9xSIKf6JEQN/tGBrduutHtIJD7WlwQ2o5MFa1Q48ms56AFfzUJZarrAFtDoUQwp1ZJMJd2gsr0OESxXGRq/V7R8SW7AsfRdtAOBCDWjPlfoyWqhgOfOxOGt3O/LZV4v2nXZ2YzIpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/21/23 4:02 PM, Luis Chamberlain wrote: > On Fri, Apr 21, 2023 at 09:14:00PM +0100, Matthew Wilcox wrote: >> On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote: >>> Just use the PAGE_SECTORS generic define. This produces no functional >>> changes. While at it use left shift to simplify this even further. >> >> How is FOO << 2 simpler than FOO * 4? >> >>> - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), >>> + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2, > > We could just do: > > > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > + return bioset_init(&iomap_ioend_bioset, 4 * PAGE_SECTORS, > > The shift just seemed optimal if we're just going to change it. It's going to generate the same code, but the multiplication is arguably easier to read (or harder to misread). -- Jens Axboe