From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628A9CCF9ED for ; Wed, 25 Sep 2024 19:36:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B90306B00AF; Wed, 25 Sep 2024 15:36:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3FF86B00B5; Wed, 25 Sep 2024 15:36:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91CEA6B00B6; Wed, 25 Sep 2024 15:36:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 68A306B00AF for ; Wed, 25 Sep 2024 15:36:38 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8563D140A61 for ; Wed, 25 Sep 2024 19:36:37 +0000 (UTC) X-FDA: 82604267634.22.2E13348 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf28.hostedemail.com (Postfix) with ESMTP id 353A9C0014 for ; Wed, 25 Sep 2024 19:36:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hnOb4zJw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xFLSeCVt; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of sidhartha.kumar@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=sidhartha.kumar@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727292874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PXjXFyp42obO8swFTir6jVs6T2iWBVihEQhH48vhim0=; b=iGSxiKQn3aUrk3eCE+EM0Y/C7Y5aQma2eoG78qWwr8ePTB1xRiiCH4UzD6rj9gknvJoFwW LOVXGu4d1HR+gU9dkKwICCs41pkdFncWQvE9YyjtVnd7Jsl667ZJb7fLBxFd0lBpIdERaI TkUqTOZkNeT5H8C1IfZ9xCePejpy/FM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1727292874; a=rsa-sha256; cv=pass; b=Y8LrGakamjtXsNylu1kqqwbk+bQXMG6CC2YVCX/OioCyLg3i9z6SpnUK2FMi9L4S34Gl6j EHU5GVQ5vT3siByyXoWPkdydwYYPdHdRE3+Gi2h7oz8/JJ2VdPNNT3SombvUhxNuDzDDb1 G8gpXNUkG1iWHAPYh6sgnMpXYCHHt0c= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hnOb4zJw; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xFLSeCVt; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of sidhartha.kumar@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=sidhartha.kumar@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48PJBXUW028517; Wed, 25 Sep 2024 19:36:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= message-id:date:subject:from:to:cc:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=PXjXFyp42obO8swFTir6jVs6T2iWBVihEQhH48vhim0=; b= hnOb4zJwUuINxAvnYB20uO6yM1ydKxnsTmvR120BsvR0L4z6U92ClQ+2Z6Qw10hj auBmGRa95IDl3oVBGN95r2kKLBVZ4DE6LyrY81muwiYS1yUPI11M4WydF3O9YlM1 mcDSGUn7FjDjge6xwLv1DUDZ0QBbxrs4BGQfoThl9GQHoH5P9r1fBoTWfRJC8M07 t6FN2zKeY2odWwnrXABVXaJQTU3XjEGgNM6cAgbrhnPITsEiHPbBFoIGSCLg740r LLn74lRckm5zlHcYTgZI4wSqzWpUBsMbFBFDdpy7mXWGhBj7tWtvBC3xSql8L1ge l0Zllyu4FgDF/DgRK3E16w== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41smx38vbx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Sep 2024 19:36:28 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 48PI31Cl032880; Wed, 25 Sep 2024 19:36:28 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 41smkheby4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Sep 2024 19:36:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=swQaG2Q/VaAj+HPHDggYZx0zO398bpXADOLDNidxIrFNfyzOPcIKgawpukOJh93KD39ug6mfaExtS38cQS/mJDd/VR544xxguInPRQbEF1k1StOuTl56jEBEJvV6VSyiEcGCyzsxLSvDfUfjSiONv1MvqOP+flqoyX9C0x4U9OzNQjp7Qk4Vl74WtBzedyA607t9Nv8qK6UFekkEghsm6DlJBn0vYRwQqb3wOpHogepDoXRlsKBRzahNJFIa+DOjFd8iwaXLsGKbnrpu2L9d1H5WAqkBFGCgEwpHlQhWFPLYjVzE/crzDx/JP26/isfz9CM/WsEVmKcx4QkcZa1+cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXjXFyp42obO8swFTir6jVs6T2iWBVihEQhH48vhim0=; b=isThueIWKX90GxBMkbVtcDEFRQ53Oy0s7nnycsHuCB6tU6C7SRmtOa6LDHgTrikiYMfyKyMxSL12FqRRD4ocUyWEjvGhCx4mgwv6hkSxV+Ee/0GK4dsE0vhjhMJvTr/WDGyA9nfaXRzAoAwr5Na8As9ZCiQz4f/D6q3XHcFY5sJioagKs8wIJFOSqg+VsGzBj6zR8yQ8ZCEz0YM7o3mOmOek1Qy6CMnGyjQHGfsUjx7P4lPFc0+0Z+v5LAQZuSASKpy3ORnP1QOFVLMQ8fc0edAYVzoUzz0Z9AGfcmNzvOn2mq66EuHRryI5q0tZGHUVlw7V+OBV5a5MVkdFDkzkAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PXjXFyp42obO8swFTir6jVs6T2iWBVihEQhH48vhim0=; b=xFLSeCVtB1IcRDagg5IwNk914Xw+/1lvYGV23wl2gQP9RYZtMk6F/kDrLEcXYH0amPuusqEzm/2CxBQV4z2MG83u9SZApkQECfYyzAbQOGK0Jmu2z2kbP24dDwioo1JLWx0jxOO48X1B0zPmdt3q96rEIUhMa2XpbJVyt9+QFEw= Received: from DS7PR10MB5117.namprd10.prod.outlook.com (2603:10b6:5:3a6::17) by PH7PR10MB6650.namprd10.prod.outlook.com (2603:10b6:510:209::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.7; Wed, 25 Sep 2024 19:36:25 +0000 Received: from DS7PR10MB5117.namprd10.prod.outlook.com ([fe80::a2d3:a2e9:efcf:46e0]) by DS7PR10MB5117.namprd10.prod.outlook.com ([fe80::a2d3:a2e9:efcf:46e0%6]) with mapi id 15.20.8005.010; Wed, 25 Sep 2024 19:36:25 +0000 Message-ID: <47463235-bc45-46e2-8d9d-b62c201c6215@oracle.com> Date: Wed, 25 Sep 2024 14:36:21 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/17] maple_tree: introduce mas_wr_store_type() From: Sid Kumar To: Wei Yang Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com, willy@infradead.org, surenb@google.com References: <20240814161944.55347-1-sidhartha.kumar@oracle.com> <20240814161944.55347-5-sidhartha.kumar@oracle.com> <20240925020431.joykmu4zzahoglcl@master> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN9PR03CA0429.namprd03.prod.outlook.com (2603:10b6:408:113::14) To DS7PR10MB5117.namprd10.prod.outlook.com (2603:10b6:5:3a6::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR10MB5117:EE_|PH7PR10MB6650:EE_ X-MS-Office365-Filtering-Correlation-Id: b034dcc5-d9da-4e86-f317-08dcdd9957ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ODNZcnFRS2duNmU5bUhQc3BsWjZGb1oySzNPNHFnOUIxYzJGVTU3VUpTanpD?= =?utf-8?B?Q1Z1T1BvWTk1YlZZU0Npengya0dGUzlXUG81ZGFXSlI0Q0hCM2N4Wmc1T1A2?= =?utf-8?B?ZGtrVUpOSmVwRHVrWXdjMllocDR4SFJEMm1CeUdQY0NvbElxN2ZHUlFXOHlO?= =?utf-8?B?bU45QUFwQVUxU3ZQSERjVktoTHZOdG9xbjBFZ1MzSStNWElMRFRaajBQOFR4?= =?utf-8?B?aEx1WlkwcU4zeXRUM0V1WE5IMmFqWlFzNGFzY0wrekRsTG51bWxNZXpHVTV4?= =?utf-8?B?d2d5VGFwZ0ZzNGY2a2tsSjRzMldrQzRnWVRvYVU2Q1puUEt6UXB0TjRxVWdC?= =?utf-8?B?SG5WNzdFZWgrcmpWR3N3enZ1REZrbStYdSt6Slg3WW43QUZDOENqeVhwdUx0?= =?utf-8?B?SEhlelZCOHpHYVVHeEc2Mm9kaXBNeUg5RlUySzJscmFNVWNTL0VxMHVzYWJ2?= =?utf-8?B?cklDZk5vTWtWc3A2alJrK0tKODNMY2dRUlhwZjZZYTc5dVQ0V3hBUFZKbWdB?= =?utf-8?B?SDkxeHF3VEtPN2JxQy9uTmpYSUM2Z1hncCtqem9TTEdWNzhFb2pmYks1ZXdr?= =?utf-8?B?MVVYOFZOdW1zNEJsaTM2NVFpWjFqN3I2SlpyRDNRZ1E3ZnNyeDdVYkx4R0Rh?= =?utf-8?B?cXplbk5kWFJTN1ZINDY3WGRCaDExQlcxVUJzc1dGanM3cjdpNUxZVFlNT3VW?= =?utf-8?B?RzVOVHVBNU1WL0IxUWlQanljT0VWUkkvNlRJU0pHWEw0Z3JTZHllSitnWDhH?= =?utf-8?B?RXRzN2FFbjMyTTFnSmVxRHlJTCt4aFkwdUlEVVdHVk02cWlwc2d4RVQ3eG9r?= =?utf-8?B?Snc4TnluSWFYTXpoak92T2hYK3hnYmZTVGV6cUlkRTY3dFhCd3lLSkdzWUNn?= =?utf-8?B?ais3M25NN0Y5SkRseWZXdlczeGd3ODdaRVN6L0xMOWh2L2FlY3ZMM1RpNDZH?= =?utf-8?B?b1E0VzhMUnE3LyttUTdTbDhSZDJHQ0tIMFArOTYzS2hsQWpBU2tHSzZTVEtX?= =?utf-8?B?WENyT0syVnR1QVJWVnlHWVUzVVNsVlRNYU9zZGJzWUNrSm9MMjZ2ajhWWUYr?= =?utf-8?B?clZoa0pZeFMvTmxDT09FUjJLYklveWs3aWJ2VVhHcTdWZ3hyd2pLV3JuUDc5?= =?utf-8?B?NG96MHRhWFpBNzZZc1BQR2s3QXVRZlRDdERIS0F3OXB0TzNoVk5kd3F6VTlu?= =?utf-8?B?TG1qSmNJWllJUzJXSGFiRlV0cGsyMWRuTmo0UkxaNzlqczg4UHBXNEp3dGcr?= =?utf-8?B?a0FwaUI4eE9tcE9vck9lY1BlQVFCRllBcm5HOXlGdDVUaWFXQllnbUtOZGRS?= =?utf-8?B?YzJkTEpkaTJqVit5eWtGNFllU1hNWUNEN0ZYNkh5bnFEMXF6QkV6bnIrbDlv?= =?utf-8?B?WTM4M05XQ0RZM29YSzJzdHgyeGNmUHF1NSt4U08rZjBhbkRZbUcvVzRjSE5M?= =?utf-8?B?Z2lqQ2QzU1IxNFQ2cDlxOGpDdUlQQ2Z0L0ROM2JHUjJ0Rk80REc3cDZkZDVH?= =?utf-8?B?R0F1RE9JQm5KUERMVHE3VDhENEJGQkN3V2dWeVZ2ZXB1VWx5N21rZmJBM3dp?= =?utf-8?B?RUtuY3YyLzR4SFVkMStGR0JYUUdtMkdwQzdiNW0ycFFyY1VZZTdnVGVZNGs1?= =?utf-8?B?V2FzRzVvcFNCaTdJalZRTnhxUGt0elhqVndBYm1XN0xVUExtbWFMU1I0WFpJ?= =?utf-8?B?NUxOTFVqUlN3bmVpWDV6Z29ZMzlaT1BKakFDTVdGbWV2dGhyVGFZWGhBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR10MB5117.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXlsRmdUTmQxTmU0Ly96TFZ2d1dWZlJDVjI4TVB3bmtVWFovOWVvZk5pMnhx?= =?utf-8?B?SEtKSHE4QlA4TmgzUXppVklHN0ozL3ltT05hSlRuMzJJZEQ5aVBXYkErQytR?= =?utf-8?B?NWdkRmJuZDkvT3ZPV3RYRTZsR01RK0dkcDJiZFdPdHlpc1U1K1JMd04rSDQy?= =?utf-8?B?aCtXNElhdVEvZzZtNmNpQjJUbFVlR1FCMkVSNW5paTlIUEJZMWNDTWI4UVB4?= =?utf-8?B?L0VSRi9CdVpyaGc2ZDVmdDBtb2RUS1ZQZHQ1eGgzZlM2eGRTWlZCaDNsanJ5?= =?utf-8?B?Wmd6VGQ0WUNJUzBRdUtEby9KMjVqVndnTHBqRmFYOUI0QnhRNFIyazBESlZq?= =?utf-8?B?Qkp4UUxhNUF6UGkwdWlkb2pNS2I0Zkg0eHhpaUo2WjJvbFMzSDVSMWRwRGgz?= =?utf-8?B?NjNIYmtLV1Z1TWNhRy9vbEhNN0d6aWEwS3ZTL1d5ZHdWd254a0cvTlF0OWYv?= =?utf-8?B?dVdxUEdkYnV6OHlHWVJRQnNORXBMcG10MXdKNVUreWVVaE9rZ1MzVkVzRnFR?= =?utf-8?B?QW82clZoUldva003L0VpdUQ1cld0bTgxSmdHTENLSjlDOGxPWTNlRXExWlM0?= =?utf-8?B?ZUtLb2EyYmJwM3hlT0NSOUtJemE3a3VmTFpsZVRZZmpreVFsSlZrRm9XR3Bp?= =?utf-8?B?TXQ2YnN2NEpRQlUvckhBeEF6RFlzeWorbWlhTWtiZktxRTVtTHNUdDluTUdu?= =?utf-8?B?Rm1VNW9Ca0ZpQ29haUphQjRFQUI2WG5qK0FnQmZ0cmhzb3krdTNwbGNxSmtv?= =?utf-8?B?c0draVlMeWNTWjVZYlVpYU9pNTc5RUZBbkxkempPQi9GN0hRUEJSZ1JmcVhJ?= =?utf-8?B?Y2NGSndCRHhucXJOQ0VGOVJzVjJiTmZaU1pOY1dpL2Q1aFFETFo0K3p4cmpk?= =?utf-8?B?bUdMZm02VnVHLy9LSVR3RjkwWDBRMkVhN0RjZlJmM0VBYVI2cWNXVVk5VzhW?= =?utf-8?B?Y2VpUjN5WiswZWwxdzNMNXEvTGZKNGpCczRCQ1NITDBCYk1MZEhaQU8rVThM?= =?utf-8?B?TkpvUlhFOXo1MHlxWkdlRWRWUklpSFdlY3hCSXpnTHQwVkVKcEZwZ0J3UURs?= =?utf-8?B?NnhCQ0orWFpWRTIxaXFqY3JvZW16cHNKTHk4eXhLeENMQ1c1TE50SXVCbEFL?= =?utf-8?B?VlNNNXc3Tyt5UWl1SUl6eVYwdEZjbm01NXdqTUM3N3BVRGM5SkpsNmd1YmYr?= =?utf-8?B?c0U1ZFZDUHRvZDdvZEpCUCtwd3RaWk12ZHY0aG5qYitYUXBQUHBCYjEvNnpU?= =?utf-8?B?clpHeXdrajR3MU5ybFI4VWNVY2RCMGNNdTREakhhTERYZHoxd3Q3ZEVHYXN6?= =?utf-8?B?SmFTamRVVSs2REM4WXhlRGZxNDBvWEVGdDlDL0dLWlBkRnJvR3ZQQms0UU1l?= =?utf-8?B?dDZhdmRWWDVTTFJEMmZLVk9MVkhMWU5xREhRa1lFL0ZtUmhPNVNqdVFieVpW?= =?utf-8?B?ZVF3eitLTWFMMkYvNE82VkM4Rk56VlNmWmE5UWVEOVd1bTRzOEMzZ2dRN3lO?= =?utf-8?B?elhBaTdYUnFvN2w5eXlUVHZPc0NmOGNGa1RSWG9RdGdhcFlGZzA1QlZiWTlQ?= =?utf-8?B?cFoxOHZqWHFtSXFoUWtLWTBOcXlMMkRNeVp1MHo5emlIN1hHVHV5SmtWOFNp?= =?utf-8?B?aVc4VWxhK2dmWGFsYzRuaUNCRzJLYTlQdFNkVWJmYThjR3ROVkprMnRBWlRq?= =?utf-8?B?U1R1UldpYU1uMWFlRk1Sd3B0ZGVWVGQ4RTl1NCtEazBYSXBBVExkMG1HaGRT?= =?utf-8?B?NXA2UHFqNmdwTHExY2RFK3JLQURjTHVvYk5FT1locFZDK2xuNDNiSmFNQU9Y?= =?utf-8?B?dWhzV2xES2lrbFNoUVcrWnkwU1FiVTg1WEprK2l3T0NsRER1RXI5Vk1TejF5?= =?utf-8?B?d01DT012bnZpakg4cWlPcEkvMHVubGlVT0hNcytzcHFpQSsvamF2cU5qK1BR?= =?utf-8?B?TTFTcExCZ25BcUxEK3l6TUxiRHdRNERhZHFvOEphVjVSTzdoTitmM1VsMk5C?= =?utf-8?B?S1VFZ25XZDVyR1JHcTJ2M3M0czViZ0MyNE1zRWJaamlLOGdnTDNKRTdDZGRL?= =?utf-8?B?eFVTRmNETWJESm9oa0s4UGdabWJ0K09nMTkzV0loNCtvRjJoelhaZzlHY0xF?= =?utf-8?B?UlEvODgwdUIyWGFNQTEzOGwvUnJCQWRFMEpBN0xTSXhYOVU3MHp3MWFWRHBP?= =?utf-8?B?QUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: VaNFV7r/V5I5EeEUNGbS289XLQR3Zvym+EMppLYcSgUV23ojnOj66EaxRN/JKtH8t4yJD1+Vl9Am1wGOZ97r9nyJ1Ihb2WSCEDHtajl4HbYG93CP/yLPkUcyeiU2Thz0fRUMftxjHxhQjdtwzup4frUYnrLsoUN4KTplZbQrRh3R4wGDueHuGpvobFuom7uBuREZMkLdoRNmVyuLA5LuZCgq+5tCbJ9zyhR2Ho7fv3N8kscCVSQgK1/f9wN646X0TR/oJTgnCtYQgz34DPePpgzBfVwAJUWnVOeG6THwIUWICYroxYR51uP3uFXhMxtYRUQvhzNzbEXZZyVNxNMOysl7HH4XViEm/hwRVLeoHGK08dtnwfRkxPffgUeUq4oBSNZSG0Lxsl6yTqn9O0g/nV+91RD4z6Z7lq+Zr6QeaAwn2wcEl6XuMPDObCdNKWQ8HiXI10TEJF/vt7HYsaPbtClgHOBbyzuFa+LQcwo7w/lVakYUSoyGpIZXJbyCqn7YvA9Eel3IqRBPsOvr+4d2SzTNAtoT31xVC8RA8ddr7CjuPxiU94IwlYNAUu9N3asyNbTjRZDbsB6Ce6KtSo3a4I5WCJBSnELuSsaed0KLlio= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b034dcc5-d9da-4e86-f317-08dcdd9957ab X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5117.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2024 19:36:25.1593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 97IeDbEv/646VmZxFWgUHnOId70uGhB7+v9nAogkeTCtZm8FCKy+NSyWE+okLQJptY8kqodzqDcGqTa3hK0Ayvw7Qqqx0hgsuoWevlywcrg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6650 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-25_12,2024-09-25_02,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2408220000 definitions=main-2409250139 X-Proofpoint-ORIG-GUID: biJk65h4kQEWiXIgMpfyJLagK_8MTME6 X-Proofpoint-GUID: biJk65h4kQEWiXIgMpfyJLagK_8MTME6 X-Rspamd-Queue-Id: 353A9C0014 X-Stat-Signature: m91x89uu41jbiscu6wtpccjd9gwijhsb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727292994-905851 X-HE-Meta: U2FsdGVkX19P2fpfmDxLuM066BoN8yP4dyvG7ot6WMG6HjS+Sd9JoZ1eOah12dsorSd2B7Wd3InMntILCdJB7H+enxTfI3t+o2tIwWnqCisr2AODh7pYefHtz37jj0jnfBujRUK1FYHWGhCk9WUeSzCz84Fd7Pyc6fo+E18SIDllIdEeEgiie+wzPQbvI/TNohZqoMdvy4eOY9nRsqYzTgYhERmmA/mp6CNhciSXxmOTWwPQRjWcYS9OchgqXf+TuD0q+LwzAcxBtkvJoDx2BWXvnVIx4O01hTDGv04MqQYPDK16aSSo1CzduyDJBymKV1T+LOeZQ6A7TtTNdmjylAPw2SkEad2c/7gQCMlv7Z/Rc2DFXGKn2bdJQGkL3GwsehY6mcaYuQ3YSpAUSLvKNUMfrGci4TL9t4iEDu/jLL+eTIB+RSCOS2edYEnPctqGb8H4CsQadPc+1hm3s4mmFBSQ5bxYqeuOoMAnczvuRgIXfgHdb/TfZI3raminAW8GU6uFR/5Wc9+HWuGoHEh9UWOtCtvEu91uzCK5wOjBiqwuFxx6bMLECCRY+rwymy/hoox2qzCWgkY64SYFn2Mleg4ZczNp7mWfCSoY/u5p4Y/e/zKkggotd/HXbQv57jkQ3NcXijiF3kt04XNoFhnew0OAJVGgTHMvPl6HQmFNs/S9zgm1eR/DUVCqjawP4fmZBtTa06PCDXO4ffyXY2x6YqXVLEce5Y35yjJo5WZZiRsaHQrf+z+0o8OZuVjvV3gtHykirOcWcYF3pERoE8m7991frSTbXnC/GH+zZRR856JwbDUxZTMisvLpIXSxfv/LQeOzkpD0XRmpQEOukVt+tW/8KRGzDQoKJEvejzV1qd6OujSPJqDvYI21+a6oucGSKP8QM3ZUjgbRJxs1+4s8iZN6ItVEHn3Vto+ttPmuBw1yj2lFNqS4lirTaBAULQFbBmJSItvtnpfgSGCPFcO tcCVIIGS 52mIzAPConzD7O8wL+XZkUnO4PVzWIMyT4uC/XjlbhxJ54AW8sGSDLRyuN9oh/BdmmEvLYORmOJrto1aLWDXGi4ApQo2olwG9yLZG6ZkvKFzc6X3eRSvk3wS33/WlBzl5NNgq8eNqHED9DxrkTCMePU/jCDsM6ln8bg1CG6iisDpsnYQ5EUYRQhIxeehPrGkmopLerS3mq5J8nIuLL8YWw6Bsy3Lzv6N+cr7TelQ2ndVm2I3ToPqMwZEVBQSEXd2Bf7qMmE/ZpAHuYb9jZO6BxND6SWX3+jMjqKc689sS7Ty8krlmQDQ0Z2XQGWibz/ZMlhXsxceXKPUpKSDXa7eaczSWQthAULzI7/DV7gfnA9mFtz1YyBBRqTw21+KWnoCqBX+29M1kcJk09UHy+MOZrIzjFoXd6TfWt8lsJiwNhMizqwsb62BusgEX8YSxuaVwG13as8K7UxNTNLGZ4dJ6zwlN2LlmN/30qShbcugOSqSYVJiD5behaGP/4LdC6R+0ohGSdKIPxh4dpsOQCpD0GJjgDeEMA6uCp7qE+dSqI/4CqaxdywS0ceyzsI8bT9wwpBpwtU1bQr9eqBj6pfjFyA9JTx/VdxUtZlvLjzgSgvfme0fHYxj2uBOcVBrfjSmmC/wGf+Lu34atu/8UieBLpF8jb4sdjrTqoaicPnrRj2X78n7v3SQCImIIUeUrVo+rIQxK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/25/24 2:33 PM, Sid Kumar wrote: > > On 9/24/24 9:04 PM, Wei Yang wrote: >> On Wed, Aug 14, 2024 at 12:19:31PM -0400, Sidhartha Kumar wrote: >> >> Sorry for a late reply, I just see this change. >> >>> + >>> +/* >>> + * mas_wr_store_type() - Set the store type for a given >>> + * store operation. >>> + * @wr_mas: The maple write state >>> + */ >>> +static inline void mas_wr_store_type(struct ma_wr_state *wr_mas) >>> +{ >>> +    struct ma_state *mas = wr_mas->mas; >>> +    unsigned char new_end; >>> + >>> +    if (unlikely(mas_is_none(mas) || mas_is_ptr(mas))) { >>> +        mas->store_type = wr_store_root; >>> +        return; >>> +    } >>> + >>> +    if (unlikely(!mas_wr_walk(wr_mas))) { >>> +        mas->store_type = wr_spanning_store; >>> +        return; >>> +    } >>> + >>> +    /* At this point, we are at the leaf node that needs to be >>> altered. */ >>> +    mas_wr_end_piv(wr_mas); >>> +    if (!wr_mas->entry) >>> +        mas_wr_extend_null(wr_mas); >>> + >>> +    new_end = mas_wr_new_end(wr_mas); >>> +    if ((wr_mas->r_min == mas->index) && (wr_mas->r_max == >>> mas->last)) { >>> +        mas->store_type = wr_exact_fit; >>> +        return; >>> +    } >>> + >>> +    if (unlikely(!mas->index && mas->last == ULONG_MAX)) { >>> +        mas->store_type = wr_new_root; >>> +        return; >>> +    } >>> + >>> +    /* Potential spanning rebalance collapsing a node */ >>> +    if (new_end < mt_min_slots[wr_mas->type]) { >>> +        if (!mte_is_root(mas->node)) { >>> +            mas->store_type = wr_rebalance; >>> +            return; >>> +        } >>> +        mas->store_type = wr_node_store; >>> +        return; >>> +    } >> After this check, we are sure new_end >= mt_min_slots[wr_mas->type]. >> >>> + >>> +    if (new_end >= mt_slots[wr_mas->type]) { >>> +        mas->store_type = wr_split_store; >>> +        return; >>> +    } >>> + >>> +    if (!mt_in_rcu(mas->tree) && (mas->offset == mas->end)) { >>> +        mas->store_type = wr_append; >>> +        return; >>> +    } >>> + >>> +    if ((new_end == mas->end) && (!mt_in_rcu(mas->tree) || >>> +        (wr_mas->offset_end - mas->offset == 1))) { >>> +        mas->store_type = wr_slot_store; >>> +        return; >>> +    } >>> + >>> +    if (mte_is_root(mas->node) || (new_end >= >>> mt_min_slots[wr_mas->type]) || >>> +        (mas->mas_flags & MA_STATE_BULK)) { >> The check (new_end >= mt_min_slots[wr_mas->type]) here seems always >> be true. >> >> So the if here seems not necessary. Do I miss something? > > It is true that at this point new_end >= mt_min_slots[wr_mas->type] > must be true but if we remove that check we won't catch this > wr_node_store case if !mte_is_root() and !(mas->mas_flags & > MA_STATE_BULK). > > We could change the default store type to be wr_node_store and get rid > of that whole if statement entirely. > > This diff passes the tests: > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c index > 4f34e50c92b5..2ae0c4da9d74 100644 --- a/lib/maple_tree.c +++ > b/lib/maple_tree.c @@ -4242,14 +4242,7 @@ static inline void > mas_wr_store_type(struct ma_wr_state *wr_mas) return; } - if > (mte_is_root(mas->node) || (new_end >= mt_min_slots[wr_mas->type]) || > - (mas->mas_flags & MA_STATE_BULK)) { - mas->store_type = > wr_node_store; - return; - } - - mas->store_type = wr_invalid; - > MAS_WARN_ON(mas, 1); + mas->store_type = wr_node_store; } > > do you think this makes sense? > Sorry this diff wasn't formatted correctly, it should look normal now: diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 4f34e50c92b5..2ae0c4da9d74 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -4242,14 +4242,7 @@ static inline void mas_wr_store_type(struct ma_wr_state *wr_mas)                 return;         } -       if (mte_is_root(mas->node) || (new_end >= mt_min_slots[wr_mas->type]) || -               (mas->mas_flags & MA_STATE_BULK)) { -               mas->store_type = wr_node_store; -               return; -       } - -       mas->store_type = wr_invalid; -       MAS_WARN_ON(mas, 1); +       mas->store_type = wr_node_store;  } > Thanks, > > Sid > >>> +        mas->store_type = wr_node_store; >>> +        return; >>> +    } >>> + >>> +    mas->store_type = wr_invalid; >>> +    MAS_WARN_ON(mas, 1); >>> +} >>> +