From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B72EC5B549 for ; Fri, 30 May 2025 09:42:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B20086B00A0; Fri, 30 May 2025 05:42:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD0C56B00CC; Fri, 30 May 2025 05:42:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 998136B00DC; Fri, 30 May 2025 05:42:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 782FD6B00A0 for ; Fri, 30 May 2025 05:42:58 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1DAA4C2A99 for ; Fri, 30 May 2025 09:42:58 +0000 (UTC) X-FDA: 83499085236.20.34BA016 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 72CAD100009 for ; Fri, 30 May 2025 09:42:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xy9siocL; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748598175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zWtS7BX4jv3Md6oma03aZLTPAuckL46QoolFrxWb6FY=; b=QfJye2sXyh0ZzbraYYbhgj/oSJ4GxFtsGzu6ImSolTE5FQdZI0tp36UTr/kI/H7uLcHo15 KMGIp8f1JqQG74xo6274UaZdjZSKPQYXW/amO4nsqTHwLt2iC7IDcMXWhFe6mE1cG1aYdi D9kuDncklp4brVkEcBrz5kHGf6MpSoo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xy9siocL; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748598175; a=rsa-sha256; cv=none; b=7Cv1TUCDAqBID/rLJfOnxJSP7zDVCQKiQVKo8Yegx1VxgQ+tq0JkuSyFoJMzcC8wkcnOAe 1el/+Uz0VkgdnjClfZb7ekeWepLP9c+1Mc3UPT2Akxj6Qn+TdKWAT1ESiRUdMh4ZPOGg4Z 4goW1Jbl1crRC64Nm+yRR0OwOLGi3fA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748598174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zWtS7BX4jv3Md6oma03aZLTPAuckL46QoolFrxWb6FY=; b=Xy9siocLka+h+1OEd2m1Jn8Xf5oDrHB2xcKtClGkcunvOIYdtEluAjqBhWKVab36je8gUw XOeyyJ2y261lCyutyHfw54JoczHoyOWdl/X2YcS1Xb9h9Je/v1EuyqEZVqC/thsgiF038w qBWNj06r/oIGUb6fOiy1++axKycQwmY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-tngXIYgrPj2Pv7OLy3BXXQ-1; Fri, 30 May 2025 05:42:53 -0400 X-MC-Unique: tngXIYgrPj2Pv7OLy3BXXQ-1 X-Mimecast-MFC-AGG-ID: tngXIYgrPj2Pv7OLy3BXXQ_1748598172 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d007b2c79so14891065e9.2 for ; Fri, 30 May 2025 02:42:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748598172; x=1749202972; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zWtS7BX4jv3Md6oma03aZLTPAuckL46QoolFrxWb6FY=; b=N9rvxTss5/1GhFMTMKy3+L0o6m0RT8SNySt2xlBrZi0maR4aeCfSf8YFo5+otT3Z1b f85WwNKSfaHZptd0+6ysaRFwdAjSO9RCVwp2aen7p93zygNoEZCfvT0eS4V4AhfH8gnR VyEXaKaNzO7QjRIj0DaTOeOWfcP+PU+dKGVPly3VrEiLS8dMAVkIaXc+OkIg3t7WBfwp yquNuJhHfqJwjC4YmQdcv/N0guVC5/Zh6xwq3Cabucn5u8VNJphF32dOBS3+YR84SAyn gZQIDJz0vTRFVQEvOU0ES/qkwb5f3SHxMNbjpUs9VA02YIAGhyM4Igv4okssYSgEmEgL URtg== X-Forwarded-Encrypted: i=1; AJvYcCUFWYhQZGtTOTLHK7xaeSLBtFlInTTVMHI8Hzxk7xFHLOtyYoDt72AFPV6jFh60LCb+Imx52upitw==@kvack.org X-Gm-Message-State: AOJu0YyoqLw2DWRCUrR7mqZxp+W3FvaMx3lCc56N6Vhs46d49n4a4bkW OcRzgEYQ92XlV4JMd5VwjAkS4QMiNvwJiXU2n2NVFKn6BNutXBZM9KrAG7wOqQebl9lvAOl6CRE PclVYnjUW2mZqVF9BQ5Wth2um5TbgEBQawC6+O74GX4L31TQbqUGx X-Gm-Gg: ASbGncuN7uAOzBFhaVL5C35hA2Mi58zLCuHFlWbr7vtv6xJ8bUZ7W2901zfhSv5B2GX DJ9onNFnaiUpVO9+OIF2oGNn4GVkIN93w2gjyCtSY9QifVqmdxwnzk9oVH9rKOcWm4huZdkLWn+ +GxEW8RameogHSYW4s/glkuJ7y2P1e5B3IarFksWwke33IYUegZM99ahRQyJvnmmWMgsrFlL2KJ rOETgipWoDWcvUpVuZ7N3/hoUd6pEkueLs9dGu/nCmGy+0SMYIwOO8qzo/eXn6Zi5GdN54egwMP wd9bR5tTKfLBH7v1vqEoDzDqkblYFY+MZyivfYnlce/2P87xtjuuw0UhGLM3i0kDyYIVPFzNSpk slfYWDzMZmlqtSCxrBL0CEnXofr9jmWQPnQdD0mBbAlXFcIgidw== X-Received: by 2002:a05:6000:1ac6:b0:39f:175b:a68d with SMTP id ffacd0b85a97d-3a4f7a3e745mr1997135f8f.11.1748598172263; Fri, 30 May 2025 02:42:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEE2cC4rOgIu1Bk0E4HwZEgbfvuVj5Yx/rDkAqlZuc3fKNMuN3WR3Ck+7U4WmY934x7i63eYg== X-Received: by 2002:a05:6000:1ac6:b0:39f:175b:a68d with SMTP id ffacd0b85a97d-3a4f7a3e745mr1997108f8f.11.1748598171812; Fri, 30 May 2025 02:42:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fc24d7sm13138915e9.36.2025.05.30.02.42.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 02:42:51 -0700 (PDT) Message-ID: <473e974b-39a1-4ee1-b321-58f6a74c0155@redhat.com> Date: Fri, 30 May 2025 11:42:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk To: Alistair Popple , linux-mm@kvack.org Cc: gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net References: <1799c6772825e1401e7ccad81a10646118201953.1748500293.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1799c6772825e1401e7ccad81a10646118201953.1748500293.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gXXHh0Fec5KFfU_548qCmguzdcZ7b040CiIU1xPtGB0_1748598172 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 72CAD100009 X-Stat-Signature: owbd8hu79xwpy6ur9m6nfo5i394cq1hp X-Rspam-User: X-HE-Tag: 1748598175-633758 X-HE-Meta: U2FsdGVkX1/YFK9Z8PJAgknMmQDs8g9EbQ+g97+d2jjhEXW0LcrPSXNhEsw5wu7QoF3a1FApwiTL4TR3eDDpWb0KGxYfOEywdkZazNx1KvXiNwZjiBRJ9GJ8B12z/ew8q2Yj7emWEWvpBfqQvwZzQyvSDoDN+pDdT9jJWz3k15MLaS7tOqDUBbRdLYqpUQqmp+AITdrPBQ1RHyOywuX6JfLYb3UMJ7FNwdkc2uify48Wx+Owi6b4k7Caj4JgEvjDhuyB3WeUA4PwsPGBV5Gzdj5zJMAgOPNY08EP6ErtFc66EXHkK+/BxfsJeXd+XjviXmZ4nDBEiRKOJSlbNwOfxxB6OyutdQB79LajD4lY5gW6HTNrzcGvbmQ9pxfE8zDevA630YBGrfmqwpZN2zZ9lrQSpUlP0gy6nHiLj3/CqMSCWEyvzeek6f7NM/L/TvNt5Iq3bGHkmr4D2s8+NFLx+01d3kZJlOV2B1/QFTANTXKo9MzZ2Fsw5JgB1snpqL3SEsSTJCUOl5+uQo7NBq5sipFhhKpWRoBCghypk3iybHhgNegdYnjGfqldK1P9vAJqSwEBcUK9MRPDUjSEM/80td+GrQGIHaXyD+ygk94NdK5+tCFl/EahrwNPjhKU+c+jvXwgpvrilHrEYkglaPgtODjUl5CbARZxf6h9Cdgp/hy2BEarcYtjqm9MeDSpcyIZ7Q0vv5t5yRliZrUfsvdBNbqzzKmG82SWetE+6IimQ325QPg3z3kw/Vsb8eYPwr78KEnvcv4UJ8668F2YWhFRQVfbJLAubT7GUq6iTcrxQ5W0gE8h4O9C0uvFO20VtTaaNLtVctd2du/v5mY1GQ39gTBYBbh6GjhGEldAGR7v9QSst2h89jNziQ5ACTRljE3YppO98BjvayjZhrqqUCr3n/UvYTfsctZiS1/NKnd3FFXXMUYHK76Aneeq7Xgo4ngzXksiTjvHBqtKw2Rxq6J zldFKncB 0lNMkUQvoJHP0j2IQoF8HQ1sXnNAC/wbvADsRKR1mvSFS9LPJCIgX4FopPC4MC/GEMjsKy3RexHO8E+gHRh77Lpe7+6nbHNOdldSgMQQrGvTKpFy5QOs/CMBsQbuJiR4SvWUrX8aw45IvoH72OdSiT1rruc7exzp4Qy4zL+qJs7FRsXgXjNRA2PzLMUC00b5pwUVsxzmDP6ZSh1N9pmrXuinRt94oC4wZ29NoqId4lHZwU/fUS80i9AAz49k2y4WWzJCLGEk/2HXjaWqintgL09mk6/arKbSzox3UDK/DY4u2WUQPclVQlavQNXhOMLf3pRcTvp+RZcwd74sNPDGveDDvwGJm+4Af/WYhsHop0VSRxugvyXLewYH657x9VLiV9Z9Cmd3oeY2UEuF5BBqPHN084rLzczaE00/u1CK7+7ULL2x9dubXr0aDd6D/KJbhFTPntvpGj039Lyg3evKfj7O0Rbfb8TnkBr7zPkEtRYMPYT+iYZjb7wcadg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.05.25 08:32, Alistair Popple wrote: > Previously dax pages were skipped by the pagewalk code as pud_special() or > vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are > refcounted normally that is no longer the case, so add explicit checks to > skip them. Is this really what we want, though? If these are now just "normal" pages, they shall be handled as being normal. I would assume that we want to check that in the callers instead. E.g., in get_mergeable_page() we already have a folio_is_zone_device() check. > > Signed-off-by: Alistair Popple > --- > include/linux/memremap.h | 11 +++++++++++ > mm/pagewalk.c | 12 ++++++++++-- > 2 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > index 4aa1519..54e8b57 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -198,6 +198,17 @@ static inline bool folio_is_fsdax(const struct folio *folio) > return is_fsdax_page(&folio->page); > } > > +static inline bool is_devdax_page(const struct page *page) > +{ > + return is_zone_device_page(page) && > + page_pgmap(page)->type == MEMORY_DEVICE_GENERIC; > +} > + > +static inline bool folio_is_devdax(const struct folio *folio) > +{ > + return is_devdax_page(&folio->page); > +} Hm, nobody uses folio_is_devdax() in this patch :) -- Cheers, David / dhildenb