From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, containers@lists.osdl.org
Subject: Re: [PATCH 3/6 mm] memcgroup: fix try_to_free order
Date: Mon, 12 Nov 2007 10:35:34 +0530 [thread overview]
Message-ID: <4737DF1E.1020701@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711090710310.21663@blonde.wat.veritas.com>
Hugh Dickins wrote:
> Why does try_to_free_mem_cgroup_pages try for order 1 pages? It's called
> when mem_cgroup_charge_common would go over the limit, and that's adding
> an order 0 page. I see no reason: it has to be a typo: fix it.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Insert just after memory-controller-add-per-container-lru-and-reclaim-v7.patch
>
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- patch2/mm/vmscan.c 2007-11-08 15:46:21.000000000 +0000
> +++ patch3/mm/vmscan.c 2007-11-08 15:48:08.000000000 +0000
> @@ -1354,7 +1354,7 @@ unsigned long try_to_free_mem_cgroup_pag
> .may_swap = 1,
> .swap_cluster_max = SWAP_CLUSTER_MAX,
> .swappiness = vm_swappiness,
> - .order = 1,
> + .order = 0,
> .mem_cgroup = mem_cont,
> .isolate_pages = mem_cgroup_isolate_pages,
> };
Thanks for catching this, it is a typo
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-12 5:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 7:08 [PATCH 1/6 mm] swapoff: scan ptes preemptibly Hugh Dickins
2007-11-09 7:10 ` [PATCH 2/6 mm] memcgroup: temporarily revert swapoff mod Hugh Dickins
2007-11-09 7:11 ` [PATCH 3/6 mm] memcgroup: fix try_to_free order Hugh Dickins
2007-11-12 5:05 ` Balbir Singh [this message]
2007-11-09 7:12 ` [PATCH 4/6 mm] memcgroup: reinstate swapoff mod Hugh Dickins
2007-11-12 5:08 ` Balbir Singh
2007-11-09 7:13 ` [PATCH 5/6 mm] memcgroup: fix zone isolation OOM Hugh Dickins
2007-11-09 9:27 ` KAMEZAWA Hiroyuki
2007-11-12 6:42 ` Balbir Singh
2007-11-09 7:14 ` [PATCH 6/6 mm] memcgroup: revert swap_state mods Hugh Dickins
2007-11-09 9:21 ` KAMEZAWA Hiroyuki
2007-11-12 4:57 ` Hugh Dickins
2007-11-12 5:17 ` KAMEZAWA Hiroyuki
2007-11-12 6:56 ` Balbir Singh
2007-11-12 5:04 ` [PATCH 1/6 mm] swapoff: scan ptes preemptibly Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4737DF1E.1020701@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox