From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA7BC4332F for ; Mon, 7 Nov 2022 15:05:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51BD06B0071; Mon, 7 Nov 2022 10:05:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A4BD8E0001; Mon, 7 Nov 2022 10:05:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 345586B0073; Mon, 7 Nov 2022 10:05:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 205D76B0071 for ; Mon, 7 Nov 2022 10:05:52 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D312280E65 for ; Mon, 7 Nov 2022 15:05:51 +0000 (UTC) X-FDA: 80106970902.10.0D7F6BB Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf20.hostedemail.com (Postfix) with ESMTP id 5F9C71C0011 for ; Mon, 7 Nov 2022 15:05:50 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id k22so10879971pfd.3 for ; Mon, 07 Nov 2022 07:05:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z6Knqsiq6vna0ldkWZeA3B+r2w8EfWBBb6+KgxrzBHA=; b=y5bJcBbwgeikIPF6JX/HJKGom1C/1b8vdu258KUadd30brjgTfEZANG/Kha2t38TQH toLYQ7eFW6o+AHXG9o1jq0WPTZgycNxFn5XQmGLECXTRgTvXz4PX7LPQR4rt2nbf+hNd kEiL9x4LHcnbnTLDdM7p/NhjpWNi/nyS1o3XU22bjKGKXvZLy3Hu812y9FBfIuaVgheh lypU6gSFXnQbLjDQ3X5xhITKamz9+TwXrkfLObezI1qp8ZH3flkT16sHLsFlJvmWMpL0 qfXMg4Xltyu4i05vG3Ahc6sWCoy3dGRMnpiqo/g6mW8QcyuO+OAcMczFxVfeQv/ENO4M 5tSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z6Knqsiq6vna0ldkWZeA3B+r2w8EfWBBb6+KgxrzBHA=; b=31LbOP02lBWAO3tffFqA/sIN8wwLva36O6d2J6Co4cBUGiAJ++fQbZ5+FL16fKuMi5 WxTU4HwsOGV2vD2Dy/L1hLuJkjPX/KZA1WgjadLBwcKNli5C4Ey5P63I8zeVjeumwVjY OHV4huB8hmn1P0uJZyUfu8QNf46hAe+gBvQx1uZTPzRwuOuiw2FTShpezXBsnDdZfWUB RqBYis7jKzlngKLoFwWRzCSBHaEYejmlapUlK+kB5AhWZZgQsCty0kP4O7T0azcMVi5i Bd6IC4du+5uGaDiy5av1MX95RQINYp8mzaByIzyaHNmYFHmuj8FjFzNjBd+mFaUxxaj5 lN3g== X-Gm-Message-State: ACrzQf2H3XMNmWwXjasUP3XcWPHJgmQaLtco0iSeFF6WVIjl1/JokDjv 6eJlBfGzcEotdGrcy9FXrbF34g== X-Google-Smtp-Source: AMsMyM66R0V2WVVWJ13espn3QxPLwHi3aPrKR3wMyMlXVj+fZClycfNJHZWzhP0GEy0pB+sVPmO4Iw== X-Received: by 2002:a63:485f:0:b0:458:764a:2224 with SMTP id x31-20020a63485f000000b00458764a2224mr42765354pgk.620.1667833549288; Mon, 07 Nov 2022 07:05:49 -0800 (PST) Received: from [10.255.93.192] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id a10-20020a170902b58a00b00187033cac81sm5110920pls.145.2022.11.07.07.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 07:05:48 -0800 (PST) Message-ID: <4736d199-7e70-6bc3-30e6-0f644c81a10c@bytedance.com> Date: Mon, 7 Nov 2022 23:05:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr Content-Language: en-US To: Jason Gunthorpe Cc: dvyukov@google.com, willy@infradead.org, akinobu.mita@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org References: <20221107033109.59709-1-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=y5bJcBbw; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667833551; a=rsa-sha256; cv=none; b=1yYfkWnrFradCEzRIDXYOiwCUUCS3aW0peGQtmxwrzKOU7vpfi1d4fNQ0WoucVOgamMLTK HV8w8dtskI3aG+h100icuXuCKc0WD6Swb8dQe2Y3mG2TGYH3r1D+9DQkqn5qy1now70T26 5ifvZn68S0JkCqZn7ZsvNtPAcVejvjM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667833551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z6Knqsiq6vna0ldkWZeA3B+r2w8EfWBBb6+KgxrzBHA=; b=A9Gbo+lxDd67FZyoHwUO3PxJj4VDl+/ysIzKx9aCm3yY3VcfY1AQbPvzn1d/xJEqBPc0P8 ip58bz566j02ZOAegB59cB+OaMZZm1IrJjqrH9DAWxgIgO/Cy1hlQtdOJUTcH/J9Go1TNU w5iFZx6oXRNsuEwXdjW0A+fe8EJ7JX0= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5F9C71C0011 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=y5bJcBbw; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: 91qxm3ec8zwh9oyypf51gar3gqiit1ap X-Rspam-User: X-HE-Tag: 1667833550-169614 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/11/7 20:42, Jason Gunthorpe wrote: > On Mon, Nov 07, 2022 at 11:31:09AM +0800, Qi Zheng wrote: > >> @@ -31,9 +33,9 @@ bool __should_failslab(struct kmem_cache *s, gfp_t gfpflags) >> return false; >> >> if (gfpflags & __GFP_NOWARN) >> - failslab.attr.no_warn = true; >> + flags |= FAULT_NOWARN; > > You should add a comment here about why this is required, to avoid > deadlocking printk I think this comment should be placed where __GFP_NOWARN is specified instead of here. What do you think? :) Thanks, Qi > > Jason -- Thanks, Qi