From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Peng Liu <liupeng256@huawei.com>
Cc: <mike.kravetz@oracle.com>, <david@redhat.com>,
<yaozhenguo1@gmail.com>, <baolin.wang@linux.alibaba.com>,
<songmuchun@bytedance.com>, <liuyuntao10@huawei.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<dave@stgolabs.net>
Subject: Re: [PATCH v4] hugetlb: Fix wrong use of nr_online_nodes
Date: Tue, 19 Apr 2022 22:07:46 +0800 [thread overview]
Message-ID: <4734132d-bae3-d3ab-33b3-a4c3282ad5cd@huawei.com> (raw)
In-Reply-To: <20220418210352.1d1d90aeba477d598bd6f0be@linux-foundation.org>
On 2022/4/19 12:03, Andrew Morton wrote:
> On Sat, 16 Apr 2022 10:35:26 +0000 Peng Liu <liupeng256@huawei.com> wrote:
>
>> Certain systems are designed to have sparse/discontiguous nodes. In
>> this case, nr_online_nodes can not be used to walk through numa node.
>> Also, a valid node may be greater than nr_online_nodes.
>>
>> However, in hugetlb, it is assumed that nodes are contiguous. Recheck
>> all the places that use nr_online_nodes, and repair them one by one.
> oops.
>
> What are the user-visible runtime effects of this flaw?
For example, there are four node=0,1,2,3, and nid = 1 is offline
node，nr_online_nodes = 3
1) per-node alloc (hugepages=1:2) fails,
2) per-node alloc (hugepages=3:2) fails, but it could succeed.
I assume that there is no user-visible runtime effects.
> .
next prev parent reply other threads:[~2022-04-19 14:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 3:29 [PATCH v3 0/4] hugetlb: Fix some incorrect behavior Peng Liu
2022-04-13 3:29 ` [PATCH v3 1/4] hugetlb: Fix wrong use of nr_online_nodes Peng Liu
2022-04-13 4:42 ` Andrew Morton
2022-04-13 6:27 ` liupeng (DM)
2022-04-13 22:04 ` Andrew Morton
2022-04-14 1:28 ` liupeng (DM)
2022-04-13 6:29 ` Baolin Wang
2022-04-14 23:36 ` Mike Kravetz
2022-04-15 2:09 ` Davidlohr Bueso
2022-04-15 5:41 ` Kefeng Wang
2022-04-15 7:01 ` liupeng (DM)
2022-04-16 1:21 ` Kefeng Wang
2022-04-19 4:40 ` Andrew Morton
2022-04-19 8:54 ` Kefeng Wang
2022-04-16 10:35 ` [PATCH v4] " Peng Liu
2022-04-18 5:53 ` Kefeng Wang
2022-04-19 4:03 ` Andrew Morton
2022-04-19 14:07 ` Kefeng Wang [this message]
2022-04-20 6:17 ` liupeng (DM)
2022-04-29 9:32 ` David Hildenbrand
2022-04-13 3:29 ` [PATCH v3 2/4] hugetlb: Fix hugepages_setup when deal with pernode Peng Liu
2022-04-14 23:50 ` Mike Kravetz
2022-04-29 9:30 ` David Hildenbrand
2022-04-13 3:29 ` [PATCH v3 3/4] hugetlb: Fix return value of __setup handlers Peng Liu
2022-04-13 6:39 ` Baolin Wang
2022-04-13 7:55 ` Muchun Song
2022-04-13 8:16 ` liupeng (DM)
2022-04-13 8:21 ` Muchun Song
2022-04-13 8:45 ` Kefeng Wang
2022-04-13 9:01 ` Muchun Song
2022-04-15 0:01 ` Mike Kravetz
2022-04-15 2:24 ` Davidlohr Bueso
2022-04-29 3:02 ` [PATCH v4] mm: Using for_each_online_node and node_online instead of open coding Peng Liu
2022-04-29 9:29 ` David Hildenbrand
2022-04-29 11:44 ` Muchun Song
2022-04-13 3:29 ` [PATCH v3 4/4] hugetlb: Clean up hugetlb_cma_reserve Peng Liu
2022-04-13 5:50 ` Muchun Song
2022-04-13 6:41 ` Baolin Wang
2022-04-15 0:03 ` Mike Kravetz
2022-04-15 2:15 ` Davidlohr Bueso
2022-04-15 7:03 ` liupeng (DM)
2022-04-29 9:28 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4734132d-bae3-d3ab-33b3-a4c3282ad5cd@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liupeng256@huawei.com \
--cc=liuyuntao10@huawei.com \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=yaozhenguo1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox