From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,BIGNUM_EMAILS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3FD0C433E0 for ; Mon, 4 Jan 2021 12:06:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C348221E5 for ; Mon, 4 Jan 2021 12:06:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C348221E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D9886B00A9; Mon, 4 Jan 2021 07:06:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6631F6B00AC; Mon, 4 Jan 2021 07:06:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 551176B00AF; Mon, 4 Jan 2021 07:06:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 3AD2F6B00A9 for ; Mon, 4 Jan 2021 07:06:52 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 002EE824805A for ; Mon, 4 Jan 2021 12:06:51 +0000 (UTC) X-FDA: 77667966264.24.smile51_450a6ff274d0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id DC4371A4A5 for ; Mon, 4 Jan 2021 12:06:51 +0000 (UTC) X-HE-Tag: smile51_450a6ff274d0 X-Filterd-Recvd-Size: 2217 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 Jan 2021 12:06:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1F170AD26; Mon, 4 Jan 2021 12:06:50 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 04 Jan 2021 13:06:49 +0100 From: Oscar Salvador To: Dan Carpenter Cc: linux-mm@kvack.org Subject: Re: [bug report] mm,hwpoison: refactor get_any_page In-Reply-To: References: User-Agent: Roundcube Webmail Message-ID: <4720f0643fcd2e9b2e4b267780e34a13@suse.de> X-Sender: osalvador@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021-01-04 10:55, Dan Carpenter wrote: > Hello Oscar Salvador, > > The patch 8295d535e2aa: "mm,hwpoison: refactor get_any_page" from Dec > 14, 2020, leads to the following static checker warning: > > mm/memory-failure.c:1943 soft_offline_page() > error: '%pG' must be followed by one of [gpv] > > mm/memory-failure.c > 1933 put_online_mems(); > 1934 > 1935 if (ret > 0) { > 1936 ret = soft_offline_in_use_page(page); > 1937 } else if (ret == 0) { > 1938 if (soft_offline_free_page(page) && try_again) > { > 1939 try_again = false; > 1940 goto retry; > 1941 } > 1942 } else if (ret == -EIO) { > 1943 pr_info("%s: %#lx: unknown page type: %lx > (%pGP)\n", > ^^^^ > Presumably lower case 'p' was intended. "%pGp". See the > flags_string() > function for more details. > > 1944 __func__, pfn, page->flags, > &page->flags); > 1945 } > 1946 > 1947 return ret; > 1948 } > > regards, > dan carpenter Thanks for the report, I'll have a look! -- Oscar Salvador SUSE L3