From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C98DEE7716D for ; Wed, 4 Dec 2024 10:36:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E2896B0082; Wed, 4 Dec 2024 05:36:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 293776B0085; Wed, 4 Dec 2024 05:36:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 182556B0088; Wed, 4 Dec 2024 05:36:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EB7666B0082 for ; Wed, 4 Dec 2024 05:36:16 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F0A81A0A27 for ; Wed, 4 Dec 2024 10:36:16 +0000 (UTC) X-FDA: 82856921658.04.C249089 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id C3C97C000A for ; Wed, 4 Dec 2024 10:36:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=e998JeYQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w2uMWpFG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=e998JeYQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w2uMWpFG; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733308561; a=rsa-sha256; cv=none; b=C/my9Qau0j6LxM6ALzYWkgdjftpSvWxnEijm9Irzs0LN9JDWnrTQPwhWFzpprBH3WM3RB4 xQQoXaWX/pcoG5YnNJHlMKwKL6uYCjeep0WqrKXqy28GDoFPB4tdA4CORCU0B5w4qU9Sh7 iuwmiR6dL523Lschqe+Cb4T4BmK+Orw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=e998JeYQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w2uMWpFG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=e998JeYQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=w2uMWpFG; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733308561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2m5jeGrg4LvM4hZt/P3gKHkwfSrdc5CvOIMEK3DbxT8=; b=kAIKWZvUWwhPja/93TrXkyvcEAL3N4MTq19YvpwYl8MooFzJXUy0vvMc9gld1QGvXxT+v6 clIwQdRFr/v0r843EMbRoaa9aZ9Rdx8QPjNJbZKrxk5wS+GR5koSKF6WDGTMc+gYGXcK2x +kOx2ruxZdRDmM3XuKnf66gy+jxuiCE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 587111F365; Wed, 4 Dec 2024 10:36:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2m5jeGrg4LvM4hZt/P3gKHkwfSrdc5CvOIMEK3DbxT8=; b=e998JeYQm7Y3fzCO/PnijY71RPcveUGbTuA3JAAwfnFV6gOFmUI32SPQJhdbdpVulXavDc tzk+n624gtvehQOM6jI3n822YzX3vClhtLMDaahQhxJUb4N5nQH83DK8NMVRsiixq7nKJJ kQqoPHn+VAqlBDwVzesHcjJ18V1gIso= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2m5jeGrg4LvM4hZt/P3gKHkwfSrdc5CvOIMEK3DbxT8=; b=w2uMWpFGfvZckjigf5ewZ5XpH2O3Uy+fS/zgKwyx2GoGN1fMzOfMUc+kRmmtWzytyCDhXk bcGmsnUQNTldO4CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733308572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2m5jeGrg4LvM4hZt/P3gKHkwfSrdc5CvOIMEK3DbxT8=; b=e998JeYQm7Y3fzCO/PnijY71RPcveUGbTuA3JAAwfnFV6gOFmUI32SPQJhdbdpVulXavDc tzk+n624gtvehQOM6jI3n822YzX3vClhtLMDaahQhxJUb4N5nQH83DK8NMVRsiixq7nKJJ kQqoPHn+VAqlBDwVzesHcjJ18V1gIso= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733308572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2m5jeGrg4LvM4hZt/P3gKHkwfSrdc5CvOIMEK3DbxT8=; b=w2uMWpFGfvZckjigf5ewZ5XpH2O3Uy+fS/zgKwyx2GoGN1fMzOfMUc+kRmmtWzytyCDhXk bcGmsnUQNTldO4CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 48EC01396E; Wed, 4 Dec 2024 10:36:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Kdd0EZwwUGftAgAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 10:36:12 +0000 Message-ID: <4719a189-d770-4539-89a7-4cdc07e6f728@suse.cz> Date: Wed, 4 Dec 2024 11:36:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/15] mm/page_alloc: Move set_page_refcounted() to callers of __alloc_pages_cpuset_fallback() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-8-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20241125210149.2976098-8-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: C3C97C000A X-Stat-Signature: wrhrozy7dqzbab1ky56ae3zdnuqw4hwx X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733308567-899607 X-HE-Meta: U2FsdGVkX18fEAwGP0kz0SGEqaAm7fnouL1zUR2/oKg+2ofzPiXLgpEBqM4MSg6W18kP5bH1xddna6Eos/18mdP03O9SxsqOzxIKfaXkMRQsrZFxxJpQmMqlHP9ajuftfeSR24m9UJnSOl/RWMbdDB3s8zvdbeJpO5a5oVBYTLCWhWx7v+gKVYY8Cx9RFELqbKtXT2sc2AX3uSyRRihOLNvEjzRCyz/OgQdup6sH/peO3sKoddMJQY5fvdyG5tNvj/kLXrUBO9m9bQX0u9RXCtTsULWbUrP2fTrCi2e6Wo/M8OqH1rqcOhAHb7KBf18QZ/8sIAZez/o50TcA/9gqz1iLbMeDcZDXqJs9qepM81iy6U3W766iqnO0uHMRxQdTFAZ04+sVm0q+A6Cm5vJQg35TybW4xLvYnbCOZEk+XlBokfFTkZiTU1grNFxvMPx+Ql3b+HNTPMZ4gV+9llbbinxkv6Psw7czAHBMagowUA9pz0965l+OJ9QESt/TziX5yAGxCqBysEljo/AGvgE42ZU2mgVNiDfwKLwCW6qJapJ+w+bls/zY4Gjt6nsmFypND2iWgYzyBWVqiwEZOq8OJYZtkNbR9ZeOiwFoUUZj2ECiDeHLbcFTYD/S9mB4wiR3j5d4q5qSz06cv1R023Eq58eq1q0IhPJ6jf4xkK45w7erSHFerUebrTayuNnmmhmrbvicWmX+XAKPN3DXx2znDHWVhysz2oBUOWtZPV78icuRHNoB4H+2ZbI7Co4cnDi9KEeMh/LnsbXeKALdT0zhHyXZ8NwJxwIWedTG3kW2ZCzM8AOv9oqtUYSUll6wV7krKYQG6K5wwzFpAnJOfJUWIMYSSD1k0MuFVA7Q4FaBaXD+T1JdyI4TJy3xSAKauPRUY07rVAULPZoUTf6UzZw6Bvk/1ddXFO48gaDhBJTDobFLCDXB9iMBXQS8HrmaKvUKb6Df6qvxX0mJJgAE4V1 jkzYjWbD dYKqXXaWPzZ+yJmdyRaZ9aH6z2DELdilkAqkpCXUC+30HF8CfheHMjGpuO57LEppvL1s3mq3PK7vgdQ+873ozCzclyA6P8hi7/BkaoOOznPQl48TNpeiK7kiACvJaNw5T30cHdVrjaNCoeEwDGic+J7JQqPAdutS8wXHrRfLpAWtxiiQ2ZKO5s+cESoHbyHP6y3BtjNv9EH4NFksHinoQBqHqKVAUfRBE0Mgm3JIA7K+uD9jbMC810qCkBq23WGitUdC3HS2YyFjdcnfiUPg9RRr2Y7eXfRfsupy/chZn2NQXE0OftYrh8jkpLgp9h0NGPSgQI0E0QOPj4GFCkWQ8aejr64VFp3TPVHA0i7NUDbk7J1I/s4YVWm3ybdFyheLJpBzP2KCEPa6F9EE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/25/24 22:01, Matthew Wilcox (Oracle) wrote: > In preparation for allocating frozen pages, stop initialising the page > refcount in __alloc_pages_cpuset_fallback(). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 14fa6bf7578a..c9e5c69f0cb9 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3600,9 +3600,6 @@ __alloc_pages_cpuset_fallback(gfp_t gfp_mask, unsigned int order, > if (!page) > page = get_page_from_freelist(gfp_mask, order, > alloc_flags, ac); > - > - if (page) > - set_page_refcounted(page); > return page; > } > > @@ -3689,6 +3686,8 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order, > if (gfp_mask & __GFP_NOFAIL) > page = __alloc_pages_cpuset_fallback(gfp_mask, order, > ALLOC_NO_WATERMARKS, ac); > + if (page) > + set_page_refcounted(page); > } > out: > mutex_unlock(&oom_lock); > @@ -4517,8 +4516,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > * the situation worse. > */ > page = __alloc_pages_cpuset_fallback(gfp_mask, order, ALLOC_MIN_RESERVE, ac); > - if (page) > + if (page) { > + set_page_refcounted(page); > goto got_pg; > + } > > cond_resched(); > goto retry;