From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
"Andrew Morton" <akpm@linux-foundation.org>,
"Oscar Salvador" <osalvador@suse.de>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jerrin Shaji George" <jerrin.shaji-george@broadcom.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>, "Zi Yan" <ziy@nvidia.com>
Subject: Re: [PATCH v2 03/23] powerpc/pseries/cmm: remove cmm_balloon_compaction_init()
Date: Mon, 19 Jan 2026 23:44:47 +0100 [thread overview]
Message-ID: <47108ae5-fc73-432f-9942-c2fe5fbf4bb5@kernel.org> (raw)
In-Reply-To: <5ed94c8a-35ac-4635-aeac-3fe72d4f9c8e@lucifer.local>
>> @@ -573,11 +567,12 @@ static int cmm_init(void)
>> return -EOPNOTSUPP;
>>
>> balloon_devinfo_init(&b_dev_info);
>> - cmm_balloon_compaction_init();
>> + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION))
>> + b_dev_info.migratepage = cmm_migratepage;
>>
>> rc = register_oom_notifier(&cmm_oom_nb);
>> if (rc < 0)
>> - goto out_balloon_compaction;
>> + return rc;
>>
>> if ((rc = register_reboot_notifier(&cmm_reboot_nb)))
>> goto out_oom_notifier;
>> @@ -606,7 +601,6 @@ static int cmm_init(void)
>> unregister_reboot_notifier(&cmm_reboot_nb);
>> out_oom_notifier:
>> unregister_oom_notifier(&cmm_oom_nb);
>> -out_balloon_compaction:
>
> So silly, I assume before there was more that happened here?
Right, I commented that above in the patch description.
Thanks!
--
Cheers
David
next prev parent reply other threads:[~2026-01-19 22:45 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 9:19 [PATCH v2 00/23] mm: balloon infrastructure cleanups David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 01/23] vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating David Hildenbrand (Red Hat)
2026-01-15 9:56 ` Lorenzo Stoakes
2026-01-15 9:19 ` [PATCH v2 02/23] vmw_balloon: remove vmballoon_compaction_init() David Hildenbrand (Red Hat)
2026-01-15 11:20 ` Lorenzo Stoakes
2026-01-15 9:19 ` [PATCH v2 03/23] powerpc/pseries/cmm: remove cmm_balloon_compaction_init() David Hildenbrand (Red Hat)
2026-01-15 11:46 ` Lorenzo Stoakes
2026-01-19 22:44 ` David Hildenbrand (Red Hat) [this message]
2026-01-15 9:19 ` [PATCH v2 04/23] mm/balloon_compaction: centralize basic page migration handling David Hildenbrand (Red Hat)
2026-01-15 12:18 ` Lorenzo Stoakes
2026-01-15 12:57 ` David Hildenbrand (Red Hat)
2026-01-19 22:22 ` David Hildenbrand (Red Hat)
2026-01-19 22:25 ` David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 05/23] mm/balloon_compaction: centralize adjust_managed_page_count() handling David Hildenbrand (Red Hat)
2026-01-15 14:06 ` Liam R. Howlett
2026-01-15 9:19 ` [PATCH v2 06/23] vmw_balloon: stop using the balloon_dev_info lock David Hildenbrand (Red Hat)
2026-01-15 12:21 ` Lorenzo Stoakes
2026-01-15 12:26 ` David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 07/23] mm/balloon_compaction: use a device-independent balloon (list) lock David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 08/23] mm/balloon_compaction: remove dependency on page lock David Hildenbrand (Red Hat)
2026-01-15 9:19 ` [PATCH v2 09/23] mm/balloon_compaction: make balloon_mops static David Hildenbrand (Red Hat)
2026-01-15 12:22 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 10/23] mm/balloon_compaction: drop fs.h include from balloon_compaction.h David Hildenbrand (Red Hat)
2026-01-15 12:25 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 11/23] drivers/virtio/virtio_balloon: stop using balloon_page_push/pop() David Hildenbrand (Red Hat)
2026-01-15 12:28 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 12/23] mm/balloon_compaction: remove balloon_page_push/pop() David Hildenbrand (Red Hat)
2026-01-15 12:29 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 13/23] mm/balloon_compaction: fold balloon_mapping_gfp_mask() into balloon_page_alloc() David Hildenbrand (Red Hat)
2026-01-15 12:30 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 14/23] mm/balloon_compaction: move internal helpers to balloon_compaction.c David Hildenbrand (Red Hat)
2026-01-15 12:32 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 15/23] mm/balloon_compaction: assert that the balloon_pages_lock is held David Hildenbrand (Red Hat)
2026-01-15 12:32 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 16/23] mm/balloon_compaction: mark remaining functions for having proper kerneldoc David Hildenbrand (Red Hat)
2026-01-15 12:33 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 17/23] mm/balloon_compaction: remove "extern" from functions David Hildenbrand (Red Hat)
2026-01-15 12:34 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 18/23] mm/vmscan: drop inclusion of balloon_compaction.h David Hildenbrand (Red Hat)
2026-01-15 13:42 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 19/23] mm: rename balloon_compaction.(c|h) to balloon.(c|h) David Hildenbrand (Red Hat)
2026-01-15 13:45 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 20/23] mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION David Hildenbrand (Red Hat)
2026-01-15 13:47 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 21/23] mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION David Hildenbrand (Red Hat)
2026-01-15 13:52 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 22/23] mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON David Hildenbrand (Red Hat)
2026-01-15 13:55 ` Lorenzo Stoakes
2026-01-15 16:33 ` David Hildenbrand (Red Hat)
2026-01-15 16:50 ` Michael S. Tsirkin
2026-01-15 16:53 ` Michael S. Tsirkin
2026-01-15 16:56 ` David Hildenbrand (Red Hat)
2026-01-15 16:57 ` Lorenzo Stoakes
2026-01-15 9:20 ` [PATCH v2 23/23] MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON" David Hildenbrand (Red Hat)
2026-01-15 9:32 ` Michael S. Tsirkin
2026-01-15 11:21 ` David Hildenbrand (Red Hat)
2026-01-15 9:38 ` Lance Yang
2026-01-15 11:22 ` David Hildenbrand (Red Hat)
2026-01-15 9:39 ` Lorenzo Stoakes
2026-01-15 11:25 ` David Hildenbrand (Red Hat)
2026-01-15 12:01 ` Vlastimil Babka
2026-01-15 9:32 ` [PATCH v2 00/23] mm: balloon infrastructure cleanups Michael S. Tsirkin
2026-01-15 11:26 ` David Hildenbrand (Red Hat)
2026-01-15 18:49 ` Andrew Morton
2026-01-15 19:47 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47108ae5-fc73-432f-9942-c2fe5fbf4bb5@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jerrin.shaji-george@broadcom.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maddy@linux.ibm.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox