From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E9EC43334 for ; Tue, 21 Jun 2022 06:11:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3DBF6B0072; Tue, 21 Jun 2022 02:11:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEDD76B0073; Tue, 21 Jun 2022 02:11:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADC046B0074; Tue, 21 Jun 2022 02:11:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9EC8D6B0072 for ; Tue, 21 Jun 2022 02:11:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 671C5120EE2 for ; Tue, 21 Jun 2022 06:11:55 +0000 (UTC) X-FDA: 79601222190.23.E062F80 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf22.hostedemail.com (Postfix) with ESMTP id 499D7C00BD for ; Tue, 21 Jun 2022 06:11:54 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id c4so20597967lfj.12 for ; Mon, 20 Jun 2022 23:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/eWGanGXRvTxAEKEXyRihaY2pmewsuWfoiE7kWqZzJ0=; b=WVwPcq7Xs7ZNJvmdOwoL0VOQi8Mil0u7MwlIhaIoQcbaiMQUIm4+G94MZmxriqIY4j sV2HKZzyRbS6wVzIVm7eo1QgVhFOcaQyIx2eK+lNIVFRXHFowBHbJhOh1XLGsQIjRYEv KW2fQu5F2EqkKsoLxCiuG4vmvj3cnNFXD9yps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/eWGanGXRvTxAEKEXyRihaY2pmewsuWfoiE7kWqZzJ0=; b=Hn1st3ZSlvQzVUllOqhNWXRpxWV708iHbPZLDpAss27oHFx0ONL+gt/xvQLKeVa19W ot26pyLASNg4KWQ4uEEFu3FwIFnDZBYWgbYyME7fmrlybkksLTD7sbRNlRLuM35OjCio YieSxmH0JTytOsDY0zC4PYTOfa5t+7tMMBdj+Dzz8vVvwETVd4JBHN3qzOCu2eqV6ZNo EFfIn81QZh5mc2e+w3h3WafXoiv7jiLGUmlOFFyOo/DiClX0ed/RUkJ3af20ZlNlNytf sO5tASFRCM2o7UstJrC6SPfw51HugRoWstkbXqLV3fYZA5uzEUjznJw6Y2Ru+rQde+0I cPTg== X-Gm-Message-State: AJIora8xhwlEyd4IQQvl7RC+1fW3z/AsIwJ4BwUSio99UIZb1hVTL89t Ed1Y7vwccHbuedqcgKqUNVTMhw== X-Google-Smtp-Source: AGRyM1tWCSbAFWcWkf2MV6dy2EN4XakvOogG8V/zDwtSKUO4DFfYU461zGuKRDDUF8c74V6lnOxmJw== X-Received: by 2002:a05:6512:1307:b0:47f:67ab:4064 with SMTP id x7-20020a056512130700b0047f67ab4064mr6958436lfu.106.1655791912587; Mon, 20 Jun 2022 23:11:52 -0700 (PDT) Received: from [172.16.11.74] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id z16-20020a056512371000b0047255d21173sm2042889lfr.162.2022.06.20.23.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 23:11:51 -0700 (PDT) Message-ID: <46fcdf08-4646-afa0-c112-76d9335adb6c@rasmusvillemoes.dk> Date: Tue, 21 Jun 2022 08:11:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 00/34] Printbufs - new data structure for building strings Content-Language: en-US To: Kent Overstreet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com Cc: rostedt@goodmis.org, enozhatsky@chromium.org, willy@infradead.org References: <20220620004233.3805-1-kent.overstreet@gmail.com> From: Rasmus Villemoes In-Reply-To: <20220620004233.3805-1-kent.overstreet@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655791914; a=rsa-sha256; cv=none; b=chFZa43OiLTA7GtKW3LUz2bHSUFXNM3dw8DAseXWj8IiQWg9y7WJ7jZPCkCxECvrlIauks W0GwAYK3ENLqsKttzmDw68+ym+jwcSScejS+3ikAItpVwtkzWcQdxB7Wrx35m63JAgNk92 w3WNxw6ws51bcde0RD5ChK1NfW356pc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=WVwPcq7X; dmarc=none; spf=pass (imf22.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.167.53 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655791914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/eWGanGXRvTxAEKEXyRihaY2pmewsuWfoiE7kWqZzJ0=; b=7/9uOWKqowxTLRWoj0/Z6VZzBP5FFqN4x2YYlmca/puuAKOYHfvJTJeVASw7xpJWBTXums rfiYaYbNlyUmj0C5d3iaberOkyUzlPJm7NzGW8qPserdoRddd8hGUTFr1fKGhzeRIFPYa+ TYL7DUhHktrVYivW/sYmL7b1LGj3Z6Q= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 499D7C00BD X-Stat-Signature: d1if7f7gjkdxkad9hnarcsm8cdf46f8c X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=WVwPcq7X; dmarc=none; spf=pass (imf22.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.167.53 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk X-HE-Tag: 1655791914-943942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.018669, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/06/2022 02.41, Kent Overstreet wrote: > Rasmus pointed out that -fno-strict-aliasing is going to cause gcc to generate > nasty code, and indeed it unfortunately does but according to worst case > scenario microbenchmarks it's not a problem for actual performance. Well, that's not how I interpreted those numbers, but, except if they showed an improvement, how much is acceptable is of course always a matter of judgment. However, what's really annoying and somewhat dishonest is that you're not including those numbers, nor the methodology, in either the cover letter or commit itself. Rasmus