From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FEF0C5AE59 for ; Tue, 3 Jun 2025 09:38:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B52EF6B03E9; Tue, 3 Jun 2025 05:38:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2B416B03EA; Tue, 3 Jun 2025 05:38:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19EC6B03EB; Tue, 3 Jun 2025 05:38:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 826046B03E9 for ; Tue, 3 Jun 2025 05:38:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ED93AB6F25 for ; Tue, 3 Jun 2025 09:38:54 +0000 (UTC) X-FDA: 83513590188.12.3723F7C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 6077CA0004 for ; Tue, 3 Jun 2025 09:38:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CdZKRgAk; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748943532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KFpTr8HeZOjxbU6TrRNGcqfkxaxEB49nHh6nOqlW1N4=; b=gjjy01iHxIWTpoqTogXOypw+0thWzsVZI04uXtSkuL6342EZdu1CY774VQPPjj4XjsVNRp fokToppu41et02/FLJ5magMbsKf/pFK3mmaAR07FZukD2RiigxoRrj0YW50kHzrD83Lcbu N4AkUxlnGEAuC/JhYHDQigpkY2JUIW0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CdZKRgAk; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748943532; a=rsa-sha256; cv=none; b=nqwPOfdDmmBgAhKJEBRgG8+f3l2fY13hOC8zomRBSht9VZovN5dcRtGPALKgmOthy+hhnS rLyujvJ/2sNpO7MRniY1X+hck/ken9NtSrGHEwc1yeqcpi7BrvkRJcA7u+iw2+bUoUmR6P oANMlbZRtzDS3rjDGJMTzXYte9AH2B0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748943531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KFpTr8HeZOjxbU6TrRNGcqfkxaxEB49nHh6nOqlW1N4=; b=CdZKRgAkXlApMc2GY0iuA9vz8YrHOzD9+HUTQ0yMahPuuxrLzRjrcf4sM5ro6gHboWy02d /brTUTuf8TdkkqbR3dcCSD6aBPv/QwAPnC4cwAx8wcBZVXBT+WFD6FqAcvRYEQBZNVCsDz fRZzTGT6KlpOdJ0KJ/MVccEmEXfowRU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-d_RQsh8jMK--hKEFLRt8HQ-1; Tue, 03 Jun 2025 05:38:50 -0400 X-MC-Unique: d_RQsh8jMK--hKEFLRt8HQ-1 X-Mimecast-MFC-AGG-ID: d_RQsh8jMK--hKEFLRt8HQ_1748943529 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f8fd1847so1499412f8f.1 for ; Tue, 03 Jun 2025 02:38:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748943529; x=1749548329; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KFpTr8HeZOjxbU6TrRNGcqfkxaxEB49nHh6nOqlW1N4=; b=pMFcD7romZl6PkUYxZT1RLHR9n97SCTFFqbqHEvqtqwlK2EbrgPFl24+QgjhJYGT9J OUMbRwx1QrLT3Ipbatp7owOXcCWkDc3srqLDbdu/wAjb8HRCZDZjaSnDyr5FJ0VnAPDP UYi3F/D5YFWW/bwwkSxleZi1R+kiIrSghNkws4zMOPGqv823F/xOfcIvcGr7nc9wIx37 uvjlU5V3zlVyLmnCwmZYqomigyC5hNiyMy67xJEWJ8iRerRrjynv92cpfGyb2h1AMmG8 jso1Ipoj2ql/qoyJTwsajuJ/ZYhZXUtHPWptoV39GbWEWq/QQPmG5g02Nudfqo6ZuGNd sj6A== X-Forwarded-Encrypted: i=1; AJvYcCUBP3Vz0A173nIkHk9mV3mfCkNntsFbfSEY0VoLBsJ0jnyLL2h4Y5PBK6OD7Yy6ZvcoLBmKkSuhjA==@kvack.org X-Gm-Message-State: AOJu0YxtHwIxTGVeF15T862lOge2CLzYALrdwAw3Fm+i4ez9pdGBVQJx jGMG9AsaVaQW1bvHx8l7iwmGBiib7RX7dVAOJNKiGamNmXCeasjMLIhtk4wbm7l8R7uOEjc7qQv FSbe7CZDtTk8P9cr2E6i280b4grePGXsIAuUb3oH8PYsfmkBz6WbB X-Gm-Gg: ASbGncsqvITR/dN0Z7/cw0aG3xEm3uhMqBvxysjzknBgLptMOBYstluqsAnPaF6j3OW Cx16RbyRhBpsGcr5TozZkvi8bL+D7YN7R4L8XkAHCVTeW9VqeSmeXX+NZzgo8jBr9rnZ+aQULj7 9JDUseAW/sPNapvnoiNuA8aECkwtTO4WzINEMYwOHAKcKQimKkayDjGGrH/9a8TGHDM3XKEmhex zHGaYOXjFx5/hXz9N+wQACsyAKgApPCnUvIvzzcNQIWR78Q82Klr4KTlueVsz6Ir2vxbqJlzYI+ Opcs/tu+vSy17t7jf10zJC+n05UFFyvRHdrIZb0e/6Ealb6OAW0/6Qk5LbHJP1Tnu1VtDeZAIse QmkycsFPBM8xr6cANcKSBCvBKdihC8RhRr5FHSHw= X-Received: by 2002:a05:6000:26d3:b0:3a3:621a:d3c5 with SMTP id ffacd0b85a97d-3a4f7a4c833mr12168932f8f.19.1748943529299; Tue, 03 Jun 2025 02:38:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvrGT+MVWFvBAj/aPmTub2du8L7tph7l3unm0TX097OZ+50ELb55QUTdKDl4hIDEjG573PYA== X-Received: by 2002:a05:6000:26d3:b0:3a3:621a:d3c5 with SMTP id ffacd0b85a97d-3a4f7a4c833mr12168902f8f.19.1748943528913; Tue, 03 Jun 2025 02:38:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe7440asm17993567f8f.58.2025.06.03.02.38.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 02:38:48 -0700 (PDT) Message-ID: <46fc14be-d2ec-41ad-a01a-69cea0074021@redhat.com> Date: Tue, 3 Jun 2025 11:38:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description To: Lorenzo Stoakes , Paul Menzel Cc: Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Juan Yescas , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250603061303.479551-2-pmenzel@molgen.mpg.de> <05576df8-20a6-417d-a4f1-867c4d30a9ea@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <05576df8-20a6-417d-a4f1-867c4d30a9ea@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BFKbFs57Q-0RIRj6pkouehFyvjEs1m4FgjgR4nbZSzQ_1748943529 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6077CA0004 X-Stat-Signature: kxgjohhpey8b6hhw8u9brzdejrtj9gj4 X-Rspam-User: X-HE-Tag: 1748943532-826450 X-HE-Meta: U2FsdGVkX1/R7poDWBqIdkWj6KlOcPXzQrjzRMseUiwb56GsJiwH96qQPiBgVRr31RxN4afQGL/69uitV6JTGT5156Rf7etPY+apBQzIOLLni/aitMDPhhvs6aC8jx99sHcxPcce3KuMAlAfdLU0YEw2H88sU+x4/VNf4e894EwYsYoL9W5sQjzGUnY38WJWpbcjNtZRY5UC0CYGkKCctXlKaKCKfCqSeJvkNyU+Hahoop7r+SgP5pMBcij6k20EBtTeBotMNqrx5xecWxl2qnqSbkNYYFwGfE9W99i3M+6rj+YAVWHyE/12fWzszsyP3Sp/6TR9cRsHZY+Dn7zrSsgP+Mc2JMgNJNvM1rDpzSSC8dFuZ0V6QYjQqDOwH5J6wkEN48eyuwZthzzoGsQG8gO4ImXEDV+5x3XQD261HHEuDQmSkCMCjTwYnYJ4b5fp8qK/EK41IpXkQfuJEq4FWq84OQBi7ogE5bXsooB/Wg8+iQVMfwPkJ4kVp4zo8/gmq3/YGLmJ/IETJjjqdOqot4AaULHY1dRjnzo/aESxqbNS81dAYTDlR+YxcQU/N+a4Yawxq404zb3Xp5FVfw+cTULBcXWiLmN/DsESt12zF493TwSRcUT4zmWWexpPS9f+kc3cxhhOa3/kENF6ZTgdWo64feR9xLzdJJPKIuTqqC68vH2Zk4IfSPoggcQbH9DH/dWSsRUXTT9zmbMWHKtiLU6VC/xih4ONXMxutb6BuRS88NpTW88YbLDxGDRrmYY0CrPeAfFGslU0tm12RpolEKI7MPNoPD4lNy1/XpeBOXbrwyiNplQChM3IOuYJe/+uETHIg2kkAvPMA7uWrTD9tB/IO7ympk38oOWdjoNoFsJRyOkspkmchpkudFcfjurRIedTDrMnvnlNFv9FzR8sEbsDuP2roNPPOY6pEBkJEZrEZJ4LGo5S49zv/LgDcKua0OcB6PjiV8kKg2qpwNU bza8tdLZ xw1afb4ITE4xjlSXJY9yeUhW1WlzVYLp4Fx6SCFCZ/u084rFMtpIWXeclbTl+SjYcZ/idtsRf7z81yXKMaJiHYe/Y81kNOz5eQeDYKgvWkscL7R8RSDfJ8JJ+UNkEtiFB1z3RvzcCpuRkCqF/yplJdfD1C3DcKLw+OeDX6EwxOt99pAkzqWJ/An3hKZk1oUWoirCtcOxEMSd+ERHABPj8HWRD9arnWwEwmNaaEKtV0IAo/zD18hQ26ykOP06tTdYtvc9pDRjDLER4CXhF8K5eGMjBKKHMNJb952d8ounBvJorc6pgMTH7mgPBep18DufxoWqeSk2x1oizIDBDDhfBZPQ/xTR3hPVNNGhClLFbUTXoEc7xa8cyEG/lpo2vfjb7GM62fLkhSJmQDKOTO3yELmEgEWCGIwfejJXdutknc0fw0h0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 11:31, Lorenzo Stoakes wrote: > On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote: >> *workloads* is plural requiring the verb *use* in plural form. >> >> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order") > > I think a fixes is unnecessary here :) I mean strictly true, but we don't > need to backport a typo fix :P > >> Signed-off-by: Paul Menzel > > Reviewed-by: Lorenzo Stoakes > >> --- >> Reading the sentence it feels like, something is missing before the >> *please*, but I am no native speaker. > > Seems ok to me as a native speaker! Though I don't claim to be the most > erudite... > >> >> mm/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/Kconfig b/mm/Kconfig >> index f8bb8f070d0d..e3a07687ed0b 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER >> or MAX_PAGE_ORDER. >> >> Reducing pageblock order can negatively impact THP generation >> - success rate. If your workloads uses THP heavily, please use this >> + success rate. If your workloads use THP heavily, please use this Should this be "use THPs" ? -- Cheers, David / dhildenb