From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58422C021AA for ; Thu, 20 Feb 2025 03:29:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5A22280291; Wed, 19 Feb 2025 22:29:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE3C728028C; Wed, 19 Feb 2025 22:29:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E77F280291; Wed, 19 Feb 2025 22:29:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 686B728028C for ; Wed, 19 Feb 2025 22:29:23 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 10868B22AB for ; Thu, 20 Feb 2025 03:29:23 +0000 (UTC) X-FDA: 83138892606.22.B52517A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 873F2180007 for ; Thu, 20 Feb 2025 03:29:19 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i0BTlue6; spf=pass (imf24.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740022160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5RmLudMZbjhJs//q/v0HEJwcUpuvtvTaPYdXzzF2wAg=; b=EDawKxdcvotSssblymSemCWdwyWWre18k4pB+h/gpv4HKXdA6bdaCKwqJLOBiXG+PzBUrm 0sYPPzF6yx7ecjf+J1EOEc4yACFE7omz7p0xp0CTJz5KDPa4gJYvHGNjiBSwtQTMeaOmzZ uRkA4Dwfpp7iLyZb5SZ1H4clOeERW68= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i0BTlue6; spf=pass (imf24.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740022160; a=rsa-sha256; cv=none; b=dr2olnDFuXcCyQXC9/yG9qO6aXFEwsUQYZiCTl3e+379PiKaWcsbybEzPJDKqpsD6l8SSM l9IUvUf6vx69xRs/iQMCcaL/9BzA7yU5h//hoSQwz6BgC/oB9gJpOcys6foemA6+roD3As zQ6obDr1Ko8+CfY7zG4GYnMVmFxUOMM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740022159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5RmLudMZbjhJs//q/v0HEJwcUpuvtvTaPYdXzzF2wAg=; b=i0BTlue6Jb7YqlfHZP19ydhIUlwYZtl1ldoRjVr4zIv0zKKDUU2j7Ma4/5uyw0EOF6UzhO M7kGkGXO/aq9karB/SZZzYT2Uwlm/l8LH+BPowzEf3UldPjdHn3s6Y8u36NTJtxnCags/a qZu6bcLT0MU5QDVjr6DN3XlWFs0K3C8= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-LI6MrCoFN2WXv-1U4WCFiw-1; Wed, 19 Feb 2025 22:29:17 -0500 X-MC-Unique: LI6MrCoFN2WXv-1U4WCFiw-1 X-Mimecast-MFC-AGG-ID: LI6MrCoFN2WXv-1U4WCFiw_1740022157 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-5fa476d0372so156588eaf.2 for ; Wed, 19 Feb 2025 19:29:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740022157; x=1740626957; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5RmLudMZbjhJs//q/v0HEJwcUpuvtvTaPYdXzzF2wAg=; b=ALlTAK0pMk3jId4yjkbcFYIEkRNnc7YWK7QzFadmxgSgNmSgNZqB/fyi/OQPLLGAJJ IKL/hxV9d6V+wj+CxF0n46Khx4kzDJxRzESar+/8KyoeqrUeCXCeMta3Tp+X+46YR9Fq yvyCK/ncIyQz19bNL0pNPz3aODj4frDp9k/o4Y8ktJecNZ8U8nHpsvPsHFRWjq1kqzdP ApX52M1cfbe1nGNL7cmmWKrwrESnZ0NAwZgJbYw8g9k6w0dyQSx5VD+VGNFWUq8YShXv tcRL8WdUYb68j7RYvwS4gjDsxgWZjUKLHWTcI1RIIE90gan3j2Tvp0bVTzbvM6q3bN/V qDlg== X-Forwarded-Encrypted: i=1; AJvYcCVLgNpOf62gKNTb8h+cjhq1IHG76zwBeLIagC1LOlyb6S4YVij47lBK/uJW1sR2HJJ6NuM5lWfgLw==@kvack.org X-Gm-Message-State: AOJu0Yxl13uJdaUgGmaLV79bi1Ws57jaqyW4lJz6oU1YHIndav8tvuwn HZ9Lq+xbuU//Kc3VG+RC80rhUYO6frnnqL0pSLdRR5/R/NbS+f8TGpDriy2qXOu7wbxX/RychVS IhK1/iOgN6B+0tDHl6DzODXWoi813TrPhLwQQ/a/MU0LWtQrC X-Gm-Gg: ASbGncu//tLHDsJZlnHFhKVO5totgpsC7M7WCYwEJvAlXYvOiQjAIm4Qq67qxhpB52D QJqggQo3kstfWxHgoP95d7DNQ4RblXWKIARxv2Nr30bSi3pnST0aE6QU0bJU8q5HF2Bb5xtOF1P UrQ1fnFx8QwtRokRPiB7e05B9XDqHf6Ecqh2/Y1xYnMuMCgJLybnjlnoQAOwP0eOpAWgiP22Q7U A0nnlXs2zOI8rk1wi2ovSM7kF0qo67ia1BMKTNx+UpaeHQrmFsT0VvQQDOzPALl8QYA65PJJMq+ At6RkLaVDH4Y2ZmG6r/k7L1k2hIZLFYnZAmoA5rN6l0Q64s8 X-Received: by 2002:a05:6870:c47:b0:29e:684d:2739 with SMTP id 586e51a60fabf-2bc99d90c69mr14428295fac.32.1740022157026; Wed, 19 Feb 2025 19:29:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQ8CW05WOfmwhWbiIO3fslX6q4AOMbeOAGzVN+41OUPwv0UVPke0cvunK9HY7sRsYtXPchhA== X-Received: by 2002:a05:6870:c47:b0:29e:684d:2739 with SMTP id 586e51a60fabf-2bc99d90c69mr14428274fac.32.1740022156659; Wed, 19 Feb 2025 19:29:16 -0800 (PST) Received: from ?IPV6:2601:188:c100:5710:627d:9ff:fe85:9ade? ([2601:188:c100:5710:627d:9ff:fe85:9ade]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72732eba000sm1347259a34.61.2025.02.19.19.29.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 19:29:16 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <46eca355-930c-4f6a-97cc-6787b6041a0c@redhat.com> Date: Wed, 19 Feb 2025 22:29:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] hung_task: Show the blocker task if the task is hung on mutex To: Steven Rostedt , Waiman Long Cc: "Masami Hiramatsu (Google)" , Peter Zijlstra , Ingo Molnar , Will Deacon , Andrew Morton , Boqun Feng , Joel Granados , Anna Schumaker , Lance Yang , Kent Overstreet , Yongliang Gao , Tomasz Figa , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Linux Memory Management List References: <173997003868.2137198.9462617208992136056.stgit@mhiramat.tok.corp.google.com> <173997004932.2137198.7959507113210521328.stgit@mhiramat.tok.corp.google.com> <20250219112308.5d905680@gandalf.local.home> <0fa9dd8e-2d83-487e-bfb1-1f5d20cd9fe6@redhat.com> <20250219152435.35077ac3@gandalf.local.home> <20250220075639.298616eb494248d390417977@kernel.org> <20250219204153.65ed1f5e@gandalf.local.home> <9f9150b4-1cf5-4380-b431-419f70775a7d@redhat.com> <20250219212708.78b93a84@gandalf.local.home> In-Reply-To: <20250219212708.78b93a84@gandalf.local.home> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YsyFnOK1-sGWIOF1mOT6m-_4ffi1Olh0EBeOIW0d50c_1740022157 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 873F2180007 X-Stat-Signature: 13jqkeqttg8sr7y49xwnxizapcamsqq8 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740022159-488848 X-HE-Meta: U2FsdGVkX1+H/9bo1a2uO5BHSjpfMV0IDx2iPgPOyikL8LoBvpWYGKzuv+q8TdijX5iOYFvLCcULZTb2ccjHtqyoig3f2xoLOL9PPb89vMrgJOagQLbFVSjjBz14/heqDAJWhliOx23Y9e82HzugPh4LOi8LrRUSkLapZKY+lx+rB6GNGbi5094OSPQ0qTLdJ3zrGbw/U4KJ/rU6nD7aF4OmVt+WgaAeogikrRM849+aGM9ez5kMNv9I1O+hsO3qxxhohRYABjMI/VWr9/YvXj+nvQQADE3i4kKdAQ0o1/lXynSDseHwO79Ag9RmWZ3X9ZxvXItG8dJuPogMy6Q0xC8Fu48X8sJQaqkZF6XXBBKR82MA1f8Yr/4AgVmNqg29IZ39L41XKOxYqYUYm6n52BSqgXA4QpcgYmv5TymCUlpNtKpSHfGCVeodv2Rfv8nPu9a74Gsdw2OM/I/cuU0yn+okyV6pQ8xPKBEU2krVwOqgYqH7kt9SoZzjkNpTZ2tTbYoMePEQCLYkdl/LacG9jeghT1DOeVreZWwvuGLgqnLQWarFjTUsGD7zPykubmNgu6cE5EkXbCH/JwCNH2sc8OK9I6JRoZI6ciXxV+A7BOBcxm4eKBPAy4beitV2kuVpgxbS34p/9vpMrZOyUDpyzMjS7zSkshl1VuStZctmEThmWkSQdilrqXWGogRzMl0HB3M1EThKKuMS8mxDuOAnr0HG/aPa2xepQJwBzxgA41E1dJM58Ph029K7TLaDElzawe2JqY783YKUXFX5NkGfVLKNCv7PyyUUoblqxw6w3hx7Dcu/x/9Z7pcMLw5LeA44qUqtGtSRZ/rGFkV9tDwqZJ9Kgve88JsTeXgrJbNKzMXKKFlQBo01orPLDgK3qjs0rZ79eGnTrcl3FQhiXvel/FZscJaH1ZTsWpPQaWOd/UWESD84LztDWgAWB6vd2B/h6kZkOslSSuG8UaLQmPz NTm24WjR GK6AT4j+LxpU5zQcDTIjoJ9cmOsrhEDIzbv5McpES6pvIH6cOnttzzjJLcOxhJ4OBn/aOHLnzo/GXo8ojnIxZzG4siORDSqRHpaS2kmcoRrtfXhqdTrFhZMAufpv7scmvoTC3Qb/6173UelkYzft9bAYYdyrRzLbRr9yx5gzzrA95AbMOh+ilBgFDDXFRpn4A/+7el8z9z4AkR6cpUmwzjDw5DKhIQPI6fsB2wDowKPQ+2UmZF3BjyjusyqqJz9oNRyaPi84zbfusZ669Kdt1TI8KTnsblyQbE50jC4J5/paVEQQvsXSVE5Sa6vnxA1Z6hyUvSO66xIIMbCyvhtQSXYV+ycraivPyclbZBzyK39Q7AoIDtHXPbFzSnXoAUmOFXEYfP/bEn0weoFWsM7Ml4WEc8lXCO6LU5yNvY4adaaz5l3e6c9geDZ67nenP1YXalNKiPmEh8nkRnt3xoOytdWOVIUntxPGyovzB/UgvXx/2cHw9YIGeWWORzQAMolAuYCvHz6HAxwAWHT68JqFzOhFCm6h3umQAcdp9z0B2h5hjU+0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.006070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/25 9:27 PM, Steven Rostedt wrote: > On Wed, 19 Feb 2025 21:15:08 -0500 > Waiman Long wrote: > >> Writer - setting them: >> >>     WRITE_ONCE(lock) >>     smp_wmb() >>     WRITE_ONCE(type) >> >> Clearing them: >> >>     WRITE_ONCE(type, 0) >>     smp_wmb() >>     WRITE_ONCE(lock, NULL) >> >> Reader: >> >>     READ_ONCE(type) >> again: >>     smp_rmb() >>     READ_ONCE(lock) >>     smp_rmb() >>     if (READ_ONCE(type) != type) >>         goto again > Do you really need the READ/WRITE_ONCE() with the memory barriers? From > what I understand, the compiler can't even assume what it read is the same > after passing a memory barrier like that. So there should be no reason it > can reread the memory location after a barrier. You may be right. However, without using a READ_ONCE/WRITE_ONLY, a compiler can potentially break up the read/write into multiple smaller trunks resulting in partial data. So I will use them to be on the safe side. In this particular scenario above, we may not need to use them on type as we are going to reread it. I will keep them for lock though. Cheers, Longman > -- Steve >