From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B87C021B2 for ; Tue, 25 Feb 2025 16:31:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2D95280003; Tue, 25 Feb 2025 11:31:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DE46280001; Tue, 25 Feb 2025 11:31:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80A0F280003; Tue, 25 Feb 2025 11:31:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0D2D1280001 for ; Tue, 25 Feb 2025 11:31:34 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3EA5EA403C for ; Tue, 25 Feb 2025 16:31:34 +0000 (UTC) X-FDA: 83159007708.28.E7005E9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id BCEE74001F for ; Tue, 25 Feb 2025 16:31:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PEzPALzO; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740501091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KiHH6H+KruC7xciVnXHNTxqKXPhxem67ayxBxHk3Wss=; b=75euiIBYQb/6v2qF9waPbjx45f1TBySPMc/EzgheeOdx9nZ5v0BT0fJ7+4081lnKwfsL5b bnAUWFIY4ftJJ6UHs15fxJ+SzUuHRNcY0IbkHQ9csnlvxHqoWFR/zNeQHjKk3gIeBIQpjj s46xnZEW1vlgagOY8WQunp5PwE+l6OA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PEzPALzO; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740501091; a=rsa-sha256; cv=none; b=to26s4HFGbbLqKB/NOmUGo7iuKIiMngviW//wT9aN+3G+eTzgwms8lbEqVKat83R5Z8TYv DxjHKc44nNHfyNvHoQ7UV8qSlhxhqy8LTGBMUqUJ4brZGpNPMxv0pVlIAVF1nwNs/zd5pu GoJuqkv7sAGBUTIEI9UI+dSsnt4iiq0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740501087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KiHH6H+KruC7xciVnXHNTxqKXPhxem67ayxBxHk3Wss=; b=PEzPALzOsSR+bMDy/5wgJneXqp8nVcJUvnH60ajPnQh7GZ+PgMfTfTVZYkrVBnJNyZktMy Ki4tH8k9aqw+P2mY76UZbd9XeKnnNWgrOCXDa4OoEkiRDCPoyhwyJ9ANmqeCUuoL2QN7XE uxJEHUrmLk6cadQ3Ssa5ejO96yCO4hQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-KgQUjOG2N0mjywH_5vsd0Q-1; Tue, 25 Feb 2025 11:31:26 -0500 X-MC-Unique: KgQUjOG2N0mjywH_5vsd0Q-1 X-Mimecast-MFC-AGG-ID: KgQUjOG2N0mjywH_5vsd0Q_1740501085 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4393ed818ccso42637335e9.3 for ; Tue, 25 Feb 2025 08:31:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740501085; x=1741105885; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KiHH6H+KruC7xciVnXHNTxqKXPhxem67ayxBxHk3Wss=; b=vSraYgNug5gllsK8hOLAca9BFhUd8UwNzIewjZjVfn9lPmzxK6fUo40ab3Rqo8Rc3d vFRMvb8kASbS+MyBhjsmiidKO4by7zFyd6c3Gw5sDNsJq2l6cgfgcD4K8cyMh846hGZZ 1ce4qFc4MyUJHZ6CftTLIhK/8T/hlDqRXLQ9eKBLF7HZQgeR3c9SzzMZ5ErdrhaPcozq U2AGnL7wyfNrCFEdSOp/n9He7eaFwzQBFCTMXBS6mlqRRrVn3R3qYngHKtrbGbFVc3ga a5gXsVCR3l1rl6Ds/AdUQqUhSfFoXztCY/+0Hin5E67jyQ37fBNm3UURJbeHI4VuesmU 9wSQ== X-Forwarded-Encrypted: i=1; AJvYcCWGdMxMBLGn4XtOibH8GqIzuBL/86TjHpkoNQLhA3ayiFMrBwqa396p4Ufn+g6RPYqXjTx29GgHhQ==@kvack.org X-Gm-Message-State: AOJu0YzHFieyHBwQoMrfxMT9Foj7EGIoa2dVx4oj9o2GtBGHL60rP9zu F0V2letHugObZ6iMItDSN8bKfYk+CrFEQTnzvaLbFA54bKPImZ6RFLQ2jzOsIur2Nq4AGsqzGMh xS4OqbslKzDZId3Qc5No2GuGd13lJdvHrx43++BuhzTzz4NW8 X-Gm-Gg: ASbGncsKic6xl4O1NQm91I8M3BSzTbJKXu5NRf73Z7ZQMt+xtsZZ6tsY/kAaBYYX1TC Qt1GAlf3YX1V41Zg0+2PIhxjUDSrptxVA+jMLLJ7JYgxZCRqfmM/pMAMdUIDlFfu5p7Lf16vwVY MEdHe+2+h38cmZribXhq9koWXohIKhrhMv2+It8eZrEMcWHrNvFq2P7JYSNAt7F/UJE8/vCwAD8 glrFcQrHjtg3yjOJ8jv9qoJ0/7wqSJoNe+XsoRyTTgkR2ZxyZV08lWIiqjPkfIsA6auA9iW/zT+ VHtA3ZCmBm+v5KRvT+Sxd5QbunPeT6ZslNBUbN2Bncssnl4rxRMIJKJadjIHmho/ZQE6lcZF3I7 KUJctQ+Se+m4f/179WvZG96VoJ3uskjpPofP6IYYQ3p0= X-Received: by 2002:a05:600c:3149:b0:439:608b:c4ad with SMTP id 5b1f17b1804b1-43ab8fd04eamr1860895e9.3.1740501084912; Tue, 25 Feb 2025 08:31:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5Ovw/WhihL86X2X1dawQx5RxIIYBwFLzc+siqsP5BW2QibCH2cUB0d0keIJUhLiTfXwu2rw== X-Received: by 2002:a05:600c:3149:b0:439:608b:c4ad with SMTP id 5b1f17b1804b1-43ab8fd04eamr1860585e9.3.1740501084515; Tue, 25 Feb 2025 08:31:24 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:aa00:c9db:441d:a65e:6999? (p200300cbc73eaa00c9db441da65e6999.dip0.t-ipconnect.de. [2003:cb:c73e:aa00:c9db:441d:a65e:6999]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ab1533104sm32895065e9.5.2025.02.25.08.31.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2025 08:31:24 -0800 (PST) Message-ID: <46ebee03-b9dd-4500-9f07-60804d4dfd32@redhat.com> Date: Tue, 25 Feb 2025 17:31:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] mm: permit guard regions for file-backed/shmem mappings To: Vlastimil Babka , Lorenzo Stoakes Cc: Andrew Morton , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , "Paul E . McKenney" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org, John Hubbard , Juan Yescas , Kalesh Singh References: <8d643393-ddc0-490d-8fad-ad0b2720afb1@lucifer.local> <37b606be-f1ef-4abf-83ff-c1f34567568e@redhat.com> <0db666da-10d3-4b2c-9b33-781fb265343f@redhat.com> <62c0ba1c-7724-4033-b1de-d62a59751ca5@lucifer.local> <6eb33b5d-3040-4637-b627-48f8f78e4e28@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7LulJr5X6k1Sa9ZFcFc2zLRFeHxm4yFq7AXzFKA9ivs_1740501085 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BCEE74001F X-Stat-Signature: zsogpj9bz5sb15ya9k7fcbgoy7yozc8f X-HE-Tag: 1740501088-599065 X-HE-Meta: U2FsdGVkX1/Iiydjk/xDItKoUO4fp/nr+XxNhXhhs/d2b2qOWq7Rz1nfYhBalUyvsNsGv2bsynuBM1X42gE0c70RCzVrwKy7+2y+FhiRP2nw4FmZeYLDkshQ8D5ScHWyuw+F3iPxJKE1LGwU/aDa0o5N7Z6l3XKi4n7RNeIaz9W42pTwfhCZ8xpJbpPxuv9d+/M+mxYPqg2q7vpZz94NRF6enScxjGJEHJ+UUvXky64TbJhtOAuNu8IrSXHUKP9a8B+cNKrNlCfa6bT7D4ETJ2H55i9u9KBaWD4AewgNCg5DKOu3L9N08DHqlIlwEfIObWhA2NNmbG/E4imZil1fMVuSt0FXrjRhdib64g6I8LLTKt2hAOwwN93h+RjU0cqyqLcoaX4P95rnJXEFHXJplrGMlVzEON5cryp7QysoVlXnBF6tYd3lzQetm5tBAXgSdXw38Aj6sakLVVwmwtPsk26dUOhy6h87yFbaGmw4CAqscKZU62fSVhjzmBRo3pLOgEEH2HT9tNmu1kKadA6eUoUJuxweaEVK0k/s4RxDWWup0AeGrV/R9n/PLRQ9oDDlHdAzMxuTAtvAbU+S65w6LZMKvZZYqpb8K+4RwVeedNagKhzevuwWTHoPx2D2Z67R2WJqZuYTRlXIuIretQ0dHOfkYYN0lsYTWBjGpRvYzp7cAGr3FM3ahsNPEzlQHuRLvYI5f7jzOZhZkYVLEV2/bq3gPPzveVkIt0r8dGo+mC7i55pXetKh9Pi3ZRtO0NKrz3FLgcQDHd1O9sWyD14hDqGWEh0FhZbVkcRyFXoVjnyqdLlg0mxKq01rcAtHJ2e9pB/1BndjImKt5vG3R1yhig8vrolFEX/PT/R7U/Cb7z8bP/uIUyw490bTMia0KPsDQDA+7PWZLzj5YfvVfYhaxMzaXX/RNeFrh04aBza/zdMP/kZgMoK824ShjUoWLufxcRw5j7AmlLndw13U/TS JCLsy9DK pyRfr8jj7ohq74Dk1bLqgtW5MSMRar2jpsxWHBMCDSXyeZlOGEaJhev3jW6t8NtspsEs+6UgSJ7Qdre32MhkgPWLVSvywhkJlb8fjqstN9+8zY3acX35/xZpiFKysDDaKrxOBIZYE4YKcSUmCBVaJG+L2MXJOOCSt1PeVQ20vhO1omI86ke8m+8C2X6e1x0uY0GQd98pnwASbpiI1JVx/TMjnNyIXqACSw2y5EBeaNAxwMZ9bLq8b12JiH5QX+1q/G/y+zSWP/Djec4LWEa1zuB/EBy/UvH+JmLpQRPkJWQx2PrUo8woR/VPEQNKkiY2eVuFJYVB//B8LTJvesxg48bA4ORyFRCRWooeWqNumw/CO/yKx6dZ+xAQ+pbD0IzQTgy7afjJmAW/1FWAg7tcLHaIe2AQtW+p6TbmF/J+wNLdJp5EeVdZ6P4bsmR8DRnTbt85p2SjQxZsHwpYMGluKv3xxiedwPPk0O08bIceeRC64NgA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.02.25 16:54, Vlastimil Babka wrote: > On 2/18/25 18:28, Lorenzo Stoakes wrote: >> On Tue, Feb 18, 2025 at 06:25:35PM +0100, David Hildenbrand wrote: >>> >>>>>> >>>>>> It fails because it tries to 'touch' the memory, but 'touching' guard >>>>>> region memory causes a segfault. This kind of breaks the idea of >>>>>> mlock()'ing guard regions. >>>>>> >>>>>> I think adding workarounds to make this possible in any way is not really >>>>>> worth it (and would probably be pretty gross). >>>>>> >>>>>> We already document that 'mlock()ing lightweight guard regions will fail' >>>>>> as per man page so this is all in line with that. >>>>> >>>>> Right, and I claim that supporting VM_LOCKONFAULT might likely be as easy as >>>>> allowing install/remove of guard regions when that flag is set. >>>> >>>> We already allow this flag! VM_LOCKED and VM_HUGETLB are the only flags we >>>> disallow. >>> >>> >>> See mlock2(); >>> >>> SYSCALL_DEFINE3(mlock2, unsigned long, start, size_t, len, int, flags) >>> { >>> vm_flags_t vm_flags = VM_LOCKED; >>> >>> if (flags & ~MLOCK_ONFAULT) >>> return -EINVAL; >>> >>> if (flags & MLOCK_ONFAULT) >>> vm_flags |= VM_LOCKONFAULT; >>> >>> return do_mlock(start, len, vm_flags); >>> } >>> >>> >>> VM_LOCKONFAULT always as VM_LOCKED set as well. >> >> OK cool, that makes sense. >> >> As with much kernel stuff, I knew this in the past. Then I forgot. Then I knew >> again, then... :P if only somebody would write it down in a book... >> >> Yeah then that makes sense to check explicitly for (VM_LOCKED | VM_LOCKONFAULT) >> in any MADV_GUARD_INSTALL_LOCKED variant as obviously this would be passively >> excluded right now. > > Sorry for the late reply. So AFAIU from your conversations, guards can't be > compatible with VM_LOCKED, which means e.g. any attempts of glibc to use > guards for stacks will soon discover that mlockall() users exist and are > broken by this, and the attempts will fail? That's a bummer. > > As for compatibility with VM_LOCKONFAULT, do we need a new > MADV_GUARD_INSTALL_LOCKED or can we say MADV_GUARD_INSTALL is new enough > that it can be just retrofitted (like you retrofit file backed mappings)? > AFAIU the only risk would be breaking somebody that already relies on a > failure for VM_LOCKONFAULT, and it's unlikely there's such a somebody now. Exactly my thinking I didn't have time to phrase during that conversation. IMHO, we were careful with MADV_DONTNEED because it was ... around for a little bit longer :) -- Cheers, David / dhildenb