From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A244BC27C53 for ; Fri, 7 Jun 2024 21:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BB7E6B00A4; Fri, 7 Jun 2024 17:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29C336B00AB; Fri, 7 Jun 2024 17:28:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BC9E6B00A9; Fri, 7 Jun 2024 17:28:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DB3F16B00A2 for ; Fri, 7 Jun 2024 17:28:05 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9585E1C2AD1 for ; Fri, 7 Jun 2024 21:28:05 +0000 (UTC) X-FDA: 82205380530.29.4AF27F0 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf09.hostedemail.com (Postfix) with ESMTP id E4946140014; Fri, 7 Jun 2024 21:28:01 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QdNlDfQp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=fjgbey5B; spf=pass (imf09.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717795682; a=rsa-sha256; cv=pass; b=OAKRI9JEjygdDzz+VK4080tbl35e0mkBLUdIScmvgqvmECTN/dDnEWtvAxD0AgMLcU6YH9 69aBBPzRphvFMrWETxfuuMw9VUlrPIPu1WSubM9yCJMg7dkm+ciyWyb/C1E+McXNHJTCNN pwlmUP/LIG5GjXaypAyeqK+jY78REoY= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QdNlDfQp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=fjgbey5B; spf=pass (imf09.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717795682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3MuQsedq3TOrs2b17oTI/UvIzVD55qL/zhnxoAjQ3FQ=; b=sz5mlrXGhF6D8eqUEUbQPXk5OV1IMyec3i9NhUkGZlv+LL6o0tvKK5T1QBrShSKMz1BfFn MkwUk3JlTno2bKpXcs/V0kVx/j2Udv6baIyJKXSG8ujsIN8zO8vtkVQ8AJZRs4L5a8NI7V z20A0Kjp9c4HEqJXywxFES8+/gB9Pi8= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 457CudZD029379; Fri, 7 Jun 2024 21:27:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=corp-2023-11-20; bh=3MuQsedq3TOrs2b17oTI/UvIzVD55qL/zhnxoAjQ3FQ=; b=QdNlDfQppqIftLEds1PjCx5F13LFThlJ3jU5yNVtDEJOynLc0/TZ2SpKkRWcl7D28x1f XlBR4644c/qlmgQCaO5nGyh3MsTVedAWrQ+lEsXfMe/zzQgu+kSZrkVD0eQqIQE9dI1c NskGF5OTtmlhUVGMFXhjUMjrHChUtX0nrmqhGiBuI7s7zX/s+IiN9SXbakbhPXdh3fS6 egQp0m84n0+QPful8KxTW5BThMs7mr3IbrY191nmRJPKSYWV/ZLd5mVlS2K9EQoHxOCu 7H1Z2DKPmx0hRVch3wGTGSglK7GM6scs1eudTCvQN1tKvzWdMWl/pNyMHF9soQBaDbFk /A== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3yjbusxfaj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2024 21:27:48 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 457K0DSH015605; Fri, 7 Jun 2024 21:27:47 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ygrjh5d9c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2024 21:27:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=axsxIW9kgUqZxDv1HoiLsOkkz7fZw82ovW3MNVbw6v1sMhYt5dYMoRcpCkrwI57GmszJJC1glCGKu89wzHP9aDyJYVIB5RM1EEMPRqOcLZqYlHwJNtb8cNHW898L0o1EcWUcmcz33LXMzWXFA75C2AE6lVzFpPKd6vkJrmvDebgikjxF6SnzSU1jy4FdzH/DsMZ66zQ1rutxus14q1iZ8pTjZZm60CXx8MW30Ny4lXlfGQBULjFdfmD9dzdnMYRgcpY027gSxW0pEAbK16GptsK96JlnYR1+FBIek0sjoyUyF5pUaiaoq72Q6rs4eMWbBGS16MMBYijCoF17Xfgifg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3MuQsedq3TOrs2b17oTI/UvIzVD55qL/zhnxoAjQ3FQ=; b=LjvnjNFGSWgmQHE9PbaxUDdhpfCoIoIT/4g0mV4mhtshvPKRm3xR2YiJ086oIio0xumNB3r8z2svI6gIBLmE0Kg8UDhNhROBV8F+Yvw/P4ZkE/lmuZ76tRSE41F7kzxQqBeDBCcPsHU5ZD4HMsFZUdhMnVqkWflORXlOCOo5tyEZ8FvExp14hi+08f03B1MgbrEUaGMpdLCQUZ6ecStCHPK7U3C4YJU4uiC/fM9P1wTzF3KfEUc3kU53p7QtdwU5HLRGncnkDGnx98pAXsbmqTxEOYlxhbgDH+KTGO5K+VtKyqH5dZYoES1BqM9dtHKTKUWb1H90XXgA0kxIBGyfnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MuQsedq3TOrs2b17oTI/UvIzVD55qL/zhnxoAjQ3FQ=; b=fjgbey5BRp+zJdxPyZxpTuThz3PI+7jiyM4l+m7pfkyPkG1ttN1s1oWnGptqZeVaTbw/bF04Tr6IiuCiuKEhDh1+LXIeLYQ1ZVcMt8BDsyV78kAryrXiw/eHEOHw93a/Ft0pjf5cjtzElo7Q/WFPgeVBRsdSkzR2i31W67jhxAU= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by SJ0PR10MB6325.namprd10.prod.outlook.com (2603:10b6:a03:44a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.33; Fri, 7 Jun 2024 21:27:45 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3%6]) with mapi id 15.20.7633.021; Fri, 7 Jun 2024 21:27:45 +0000 Message-ID: <46d42404-b54e-4679-b1c2-3e4aee3b9c2f@oracle.com> Date: Fri, 7 Jun 2024 14:27:43 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] mm: remove MIGRATE_SYNC_NO_COPY mode To: Kefeng Wang , akpm@linux-foundation.org, linux-mm@kvack.org Cc: Tony Luck , Miaohe Lin , nao.horiguchi@gmail.com, Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , jglisse@redhat.com, Zi Yan , Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple References: <20240524052843.182275-1-wangkefeng.wang@huawei.com> <20240524052843.182275-6-wangkefeng.wang@huawei.com> Content-Language: en-US From: Jane Chu In-Reply-To: <20240524052843.182275-6-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR03CA0149.namprd03.prod.outlook.com (2603:10b6:a03:33c::34) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|SJ0PR10MB6325:EE_ X-MS-Office365-Filtering-Correlation-Id: 7df3e181-55a9-4914-070c-08dc8738abe8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|7416005|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RzJyakJFUnJkRDk3UFNXUEtxWWJxdVhGU0VYY0FjVlZjb3AxdGx4WGViN3JF?= =?utf-8?B?K2lpNHlZN1hLbmdJZDgvaERlZi9RWHBPNnVDWGtLOGh5RHN3ZnB3dkw0ZGsx?= =?utf-8?B?ZmdLSkt2aFFmcUJvMTZ1NEpsZHc0UHZVTkFBTEErd2RRdHZuOUdXbkRDWlpV?= =?utf-8?B?aDM5dnpyaUQrbFEvdVVxcEsyVitaaXVCeEErNk1CMy95UllYaTJFUGx3SWZM?= =?utf-8?B?NHA1RlZYSGVXZVhtWHZKWXVBWHdGZVp0cWJSc25GZzExWlZkQ29lejJISVRU?= =?utf-8?B?dDlrWnUybjV6YUVkWHJBM01VL0NvTFJIbVNnTUhKOGpUNGxtL3JCK2RuTzJ2?= =?utf-8?B?ZzMyOGlvU3VqVnUxcHZqVVBpYjA5RWRZejdTQ2VVc0dzUnJqQ0tSMnZuTHJ6?= =?utf-8?B?RUNlTjFsN2llSlE1Uk0wNlVyUjgyQ2JoNzAwbm95eGZxcmNDRXAvQVFCSWkz?= =?utf-8?B?aFJHVkxqVERNb1NTK2tGQVVlaTNkdTd2Rk44OUxsSERjU1l5b204SzIrZFdH?= =?utf-8?B?TWRUQUpTVVFDMVpTN25oWDdDSkZKU1VLdWxYaGdkWUF6aVpjMEc4V0x0aE1N?= =?utf-8?B?NW50UW5EMjhNRGNhcGhmZjZuUXdsWWtJS1h1MEVLaGJTOU9yY2xDbHovdnJV?= =?utf-8?B?aWNiV2ovMWptcEhaemtkVks5ckJmMnFWSTNrMmIwOU1NTXhKa0VQZ0EzVU50?= =?utf-8?B?Z0M1T0lsdksrYVl2eUt0bDF3NGh1TklrSjdYbjVCY3dISWRwUG4rODlyQWtI?= =?utf-8?B?QllpN3JpMkdxWC9YT0w3VW9GTFJaWnpuZHNiYjY0TkpaWXVwYlNHQ3duNGF6?= =?utf-8?B?T0pSTmNSKzNQZ1VEc0JXNUZmcG94NU9nWFlpeE1FTVoveE1OYW0xTzQ3bnlY?= =?utf-8?B?N1VXTXRBeUtIZmlOeExtVUtnRXpJVUNxcExUdTBtTWZKcnRnRVdzZkdDYzVw?= =?utf-8?B?UXFCM1h6VlAyM1hGNmV0OTF5U2MyelFTYXg2SXcrWnNvcnRYVEJINmNxSDdV?= =?utf-8?B?aUJLWkRLa0dTdEUrb3J0N3AwUC9rbml1YzVNVWxWVW1GaCs5eDVDNld4Z1hT?= =?utf-8?B?a1paejd3Qjl2SEp6Vjc4Y01jUzFSNkl6YUFOUEVPYTdPeUtURXRNM2NwRTZr?= =?utf-8?B?ejhYeXdndldWNWYwbGxXcjBIdHhzWDExQzhaYWoxQkFPNHdqaTlNZTFNUEdh?= =?utf-8?B?enBtY2dLcEsyY0tKV1F4WVVkOXlWb09seitIamZENmV3UVBNc2xLeHdnL3RI?= =?utf-8?B?V3NOYWljc0JLK0RGTmp4dVlkTHFGMUFMMnN5Z0I5Z3JzN016eHFBRnBKbmdN?= =?utf-8?B?cmlIa1B6Zm1hNCtwTnJ1VU16bHBvVGtYU1F5Mlg2YXJCNXZxSGNDR1pMaGpV?= =?utf-8?B?OVdwZTdUR3BuK25Yb1E2aGxXV1BybWh4SHNLMlcxTm5CcytjMjJjSlVJVkJS?= =?utf-8?B?T3FUcFNaZ1lyaXFwYktoTDYveTNWQlZrYnV0eEJPWTlKcDZNVFdFZmVXczBM?= =?utf-8?B?TENMRWVDM1BYQlBtaDNWeFc5QUM1amFoUU9VT1dJaStzbGFGL3JOem53ckpQ?= =?utf-8?B?eFRoUVJEa3phdnBsdXJDUnlSSnlYYkEwTmtjWktUNHM4eUR2TlBsZWVxVXND?= =?utf-8?B?TUVoblV2S01Pc1FGOUJ2V1YzaHJJdjVsNFhXVHByQm1NZGgzZ2krZUcwdXNj?= =?utf-8?B?R1I2a29ZUjF5SC9SRitPY0ppVWFMNEhwbWhHMU01MzlDd2lzMjF5TWxrV0lF?= =?utf-8?Q?Tgyja4L8fC5zh26Dvl/IxVdHrhc+Muat5PZ4Ay4?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(7416005)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFRxeWlGWkxwb2hBYWNrQjJRbjlTZ0poQUY4MGU5bEZvUzQ1TjZ1ZDhiZXJI?= =?utf-8?B?V2RRTUJIS1ZQS2h5dVdWK3FpVXdRNUJHbnhNWXdPN3g2N1VKOGovS2VWSmQr?= =?utf-8?B?Qi92NkxJRFN0ejk4ZVlWV2xTUEZXdURCbGFQWHd5Q2lWU0JiM2xUZ3IrZHNv?= =?utf-8?B?MHlUTHFpZ0RsVWZKNzZVb3J4TWc0amVrbHk2NHFMcGFYb09ZSUg4dEIvSlph?= =?utf-8?B?YnlWRzlNQ2F2TGxUSEx4R3RoWUlwcU93aGFkcEZqaThaT01QSG1lRFhwSGF3?= =?utf-8?B?U1VxQ2h4V0xpVVZCSWxHTU9tVm52ZWdvT2FXb0FjdW1KczR3WmRPWmQ3Tlh0?= =?utf-8?B?b0xuNE5Ldlc2YkxVc1gyMmhKN1VGVlNMQ1FQVUZNbHhxL1pSNTBURzV6Nzlr?= =?utf-8?B?d0VYUVRiWVoya21JV0Q2U29jVWpPbUFiVnlUNzJobmt2QWg0dWtUVmFrbzZh?= =?utf-8?B?UzlTazBHVHp2c0RjdkIzRlRyaEh5a0Y0K0UvdEhEMlNLVUNld2cxYWpIQVpo?= =?utf-8?B?Q1A5Q0NKQ0lkVWpqcjMzektqUkRvS2lDUDZoUlNGOFpxb2lQREU2Zm56Ny9r?= =?utf-8?B?TDVWRU9PcGxBVjZySkRvR2tKZk1KT2lnZHVKdHV6dFNEZ2NqZWJBM3hOcUxz?= =?utf-8?B?UUlTRzdkS3BIUXd4MGFrdmpwN2cvbGhObU4xVlc5VFVMeTBGSlJVVDRHTm9W?= =?utf-8?B?SlpCSGdGR0EzTG9FUG1TbUxPTDExOVZMQXc4YmJyaVhBZWlMdEJlYlIyaXNR?= =?utf-8?B?L25XUEpueXZyd2Y0S1gvaXZ5Y3ZCSk5jL3k0ZTJZQW1GT1VjODYzejBoY1RI?= =?utf-8?B?cVhJSmxwOVhXOVE1dGx6eVp6c2RuS1dzTCtFRExiUG4zbVJxekRNa0c4Q2RL?= =?utf-8?B?N0JKSDRLNkcrODVIT0pzbDZveDdGOUN2RWg3UGhUN1hCRkM0anhLOTVENnRm?= =?utf-8?B?bHZNa1BpUG55blRodFBqRjBjYVdlazBqQUdMbEl6WEZ6Y1dwU0lWZW1YU2hZ?= =?utf-8?B?MWFPOXVGblhReXZZQko4ODRxeThqQ1J1L0RFdGxsOHBTaCtMbVYyVzZPdVUy?= =?utf-8?B?dnFmUVUwRnlGRjNGMlhMdkJGTFBaalBHUk1sZlNMa0hhclpBUUxnK09oVWFY?= =?utf-8?B?NDVROG4xR2lER0NPU3FydndwTjIyYUIxNjVyZWlKS2Z0dkRLcEUxN3FyZ3ho?= =?utf-8?B?akp2ajg0a04zLzM2RTIrTmlvSG8rTWp5YXRhc3ZJcnp4R2dvb3JiQ2FWZ05j?= =?utf-8?B?ZGY0b1pUT2drWGNBNWFjS3RMTzFyOGxQcEwwWm4zdjZMaEgxVnNCa0FuMS9N?= =?utf-8?B?a3FaT3hDUGRsOTlXdVg3NW5qNG81Yi9mNk5VZFdjOU5Vek82NWJJNWdUeEcr?= =?utf-8?B?Z1p5YWZETUxEZVRKSGlZOTl1UjhRWmpsRmpuZDQvNFlMTmovNUhMWWo4MG9B?= =?utf-8?B?VTdJTUgxRE9aWE1VNEJUc1I0RC9BUlNza2hwSVVibU1udWlPc0hZVUN0VUJV?= =?utf-8?B?UmxXQWlIUW9ORjR5S1JEQW1LTFNiR0RneTZrWExkRUl6czM4TE5vUEZsVFVY?= =?utf-8?B?UVNCcXA1dmhYbERHQ0VzVjJzMUY1dUIzQ3dGR3JJeXRFMFpvMWVkaWowYUpo?= =?utf-8?B?cWdCdFJjR3MvQ2FkN3BHQUkyb1Ewa0ZEa3g3bEZ0N1p5UytzUE1JaWltMEYr?= =?utf-8?B?SzZEelZIdE9PVXp6Y0trbm1pTHRkeGJ6QnRMWFdWTVIxL1pob1MxY29NTEhZ?= =?utf-8?B?cDVQTTNGVXhlRjczQVV0bDE0ajRUUnBOK0VSZDVWUk9hQjdCU0F2bk5vMldU?= =?utf-8?B?WFM4RThGNTViU05aOEpMQXFIeHVwSGdDMDB5NDVQejZJRlZHUXdzanBiR1dM?= =?utf-8?B?VjVha0loYjV5dTZPWTJ1blVhb0pSVG5SUWxQd3NzemNrd2VKenJuOFhnVjdw?= =?utf-8?B?RFBiTGNKUmp2dC85aFNaZzRZcWxSWkJCMjRWZ2lyU24yZjV5R1BGWGZnSzMx?= =?utf-8?B?anAzZ2ZDUzc4bEZ4cjFySEdVb0VQU2FlTjhZTy9nVW9DS05iZXc5d0JZNkVU?= =?utf-8?B?V2toM3ZTNGdVREhOQkFnQmV4azhNUytJRmRybkNWaXZKNUtKZjM4cy9lUnhZ?= =?utf-8?Q?ZgCo8CvwOnczRI8vCJAmJrF6z?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jx4tNE3hfukw2BVkqyVWBlmpSLqarnI82X71qBA3zeuMlcH7aPfBJH7PoxM99BmEKN3L7OgWoBm0XDVM9o6RhC3RZufLvb20Qf1LiSJ74LRIEFVsLkqSQdXKbP7dsEaX2/3Acv7jfG8RvPJd9SoJsxazXQRrALOmcTX+BJje4cYHWcwETXXfytGPM+NEq/JBkzg8AQcbvCo5eYeRpExQTSbwiCcfRgqrgx7y/Khx+Yjuvm9j9VgYkDfGUFaYnZfzy9Pcx8BiwpaQyBIUM2wxSeoXUhh5pURzbP/Yr6kgjWNcRhXTPonl5X+tpXoDcVcxT5K68Qj2/3obW6A8RDvnGMyhak87JCbRKsSvfZiJfQmhOzAZKVZgp3L3Bl/rP7a0asKfDD0toTDL7T8uFiwlHnWLjHePcvscx0BZ8f3q1clkqGDqN9FXA6c2EL4q/lpUfCCD0qjZjY71iLvn0KTyI6xqWcslpzPZvOTzcM7rlzgkwXXTNhXDCzi05zmlP44zMncwEQukZnroRVuZVmfJtRHE1mWXTh8RY35EcGUfXRSpZPm7i38AQNt5fPaWHuzS9dATou8vUsYZDcD1ZSoFi1yBMAbVgVb+U58zhc5D9Ec= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7df3e181-55a9-4914-070c-08dc8738abe8 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 21:27:45.2787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1saDrQIK8CccUl3B0lheT5Lkj+cMQsNNVlvJ9OZxRB9LkXHlIf6M9paOX+sZmCjAqMi+CofTnf8aJBm5llaalw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6325 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-07_13,2024-06-06_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406070158 X-Proofpoint-ORIG-GUID: UwBS6MMaLnUJx1xivIQn4LWzM4dltZTG X-Proofpoint-GUID: UwBS6MMaLnUJx1xivIQn4LWzM4dltZTG X-Rspamd-Queue-Id: E4946140014 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 1cxc1usnoyt3e5xukbfno67ixmtkmr8f X-HE-Tag: 1717795681-803679 X-HE-Meta: U2FsdGVkX1/sv07smh283ZzCrUXfFI//m6jsV0FMvWQnw90l1f9/meecsOaqpm/v0cFzdKPj/hFwfTpuZ+PEJaGa/xQw15k1aXelFKQDykcfvpteMJj0o9F6NfLrr841JgehztqFkPGqFml55iWHOBij0Y39M1VAVEz011gWCUuveeQ/fWMRcemEbixtn0v4WCl2oFD/NR+BW4afxAbQ/fN05hMq5qZ3KdCIl9NBVbYsQ6iKP+uxbh/XYpK48rGtH9ChtRe4tb+zMrpYzLO37qwv4GUZQX4fVinqg+S6xdLhSVkfpVjZ86L2qeP0N8HwTQx+8DGxVO5U9rhnjTv2hUcTZaP2Kpl29z30MXNFxzHHFzBLHqGBTpxJxIOVchzhz83tPPQlGuKKS5YnQeKiBiYpGPfm5AT/QCyfEx3PXmaDZPYYi1MXydcfDgwavGQP/cpdtGBRqJJs+ByuWsIIAFE7iVYmWUczimsPDFtXR3sGvuSua1C9Eq908Hh5pp1UNANMHd7WJsI56t4U/O4wAggMU/xC1pzdM6Pbh7lJxFsLNZdbVuYupwyafhvp6xflYDbCEOQB/UfWt76yjuU3QaecmaxNurOG73ES+TJRnQSiRLQQfYPH/ixJlMWKbw6UeuP8dXaKTXuZEyuF+YyD0g7/NzHFJ4saHCQPwAT8RPn6/7PF1dv68hgivn0eZFPVVZxIsOgn7jmn0M2VgBevoNh8peUYp2ZBRFxVsr3IzmTs4q2OTYHjdLNHlOmkMFqRpj768wUs7/u5z3YWeA+Rfa+xbpjbjqhHoDNipwDNzgPFY+RE84BMMBuUmL0pcK9xYJUk0cnFvofH8942dslgb3AssRalscHUC4xvQc1bbSCSplUfngctBt7QSMq+O3f095WPqxPcnKexWw2qoaNCT3JUokV5Ke5jm6D1MuTwNqMmgaxsHAmGS58kK04D0E/JP/AK86alK/Q4FtVO4GA IYByfUaX U/scxlZicSt9j811Uc1fQtWEAn7QKFo1C5dk8Q7ovszRWP0LJ1vgdfmhL3iCuRaJd9dLE6RY2IkvvE/lHzrfY19ePf15a+/K2AZ79dmIT5y2QeCpAKdTM8Q+QjHQZ28VPbObgHPPsL1vHgC2gQkWYO1JlL0W91f2kcK0FrTunHOp9ZdfngHqfsxa2LZv0JQrOboEjTkG4hV6OR59W2bsS3XI834Puk2DWKvR17kKavyQqiUMIkQ0a9Jejpxg/tElZQ8X05yVxU+DidjGD08h8hdSFTCX+pSnc6dQt4i3MY6O3lHM67oQ1qU+G/RCeUbrhNN8nmcXbvq4juUR/wzMfymyXWL4FMj66o7A9LhMGPxxCzni24Mog7S6+32KzdZ8YxKN99U/TCCRsbEC+OjIK6rY0vpLjD+Ey/a5fPOf6+fxsmg/wWH8tnlnaljvKqBOla5fPM+il2bSl4mbFNqK0eCgb4zMgWrdC4sCLKEA6jp9tAHeGz0RpLcb55I/DKLg80fitwfRAXXpFr9aDNW/nqX99o+QpBAyB7Cot5b1MavQwc/63TC59E3fPBN1kA2Ad4mdL/5esZoum37BdqNWHhrf54mpSpcOxWrzx1nWmT+tBXz9Izt6WqGIbO5R2wJmXRP3ahWp8cFvN7JGRGiZuLjCVxCiuUMRuwrM2jyR4+mg5ZK51GFnYnWLYzfSN+V4uUbPue5GRYJQ4tEycwgxlFxOuOAZ2UxaADoR0IJJm9qXf7TA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/23/2024 10:28 PM, Kefeng Wang wrote: > Commit 2916ecc0f9d4 ("mm/migrate: new migrate mode MIGRATE_SYNC_NO_COPY") > introduce a new MIGRATE_SYNC_NO_COPY mode to allow to offload the copy to > a device DMA engine, which is only used __migrate_device_pages() to decide nit:  s/only used/only used in/ > whether or not copy the old page, and the MIGRATE_SYNC_NO_COPY mode only s/copy/to copy/,  s/mode only set/mode is only set/ > set in hmm, as the MIGRATE_SYNC_NO_COPY set is removed by previous cleanup, > it seems that we could remove the unnecessary MIGRATE_SYNC_NO_COPY. > > Signed-off-by: Kefeng Wang > --- > fs/aio.c | 12 +----------- > fs/hugetlbfs/inode.c | 5 +---- > include/linux/migrate_mode.h | 5 ----- > mm/balloon_compaction.c | 8 -------- > mm/migrate.c | 8 +------- > mm/zsmalloc.c | 8 -------- > 6 files changed, 3 insertions(+), 43 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 57c9f7c077e6..07ff8bbdcd2a 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -410,17 +410,7 @@ static int aio_migrate_folio(struct address_space *mapping, struct folio *dst, > struct kioctx *ctx; > unsigned long flags; > pgoff_t idx; > - int rc; > - > - /* > - * We cannot support the _NO_COPY case here, because copy needs to > - * happen under the ctx->completion_lock. That does not work with the > - * migration workflow of MIGRATE_SYNC_NO_COPY. > - */ > - if (mode == MIGRATE_SYNC_NO_COPY) > - return -EINVAL; > - > - rc = 0; > + int rc = 0; > > /* mapping->i_private_lock here protects against the kioctx teardown. */ > spin_lock(&mapping->i_private_lock); > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 412f295acebe..6df794ed4066 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1128,10 +1128,7 @@ static int hugetlbfs_migrate_folio(struct address_space *mapping, > hugetlb_set_folio_subpool(src, NULL); > } > > - if (mode != MIGRATE_SYNC_NO_COPY) > - folio_migrate_copy(dst, src); > - else > - folio_migrate_flags(dst, src); > + folio_migrate_copy(dst, src); > > return MIGRATEPAGE_SUCCESS; > } > diff --git a/include/linux/migrate_mode.h b/include/linux/migrate_mode.h > index f37cc03f9369..9fb482bb7323 100644 > --- a/include/linux/migrate_mode.h > +++ b/include/linux/migrate_mode.h > @@ -7,16 +7,11 @@ > * on most operations but not ->writepage as the potential stall time > * is too significant > * MIGRATE_SYNC will block when migrating pages > - * MIGRATE_SYNC_NO_COPY will block when migrating pages but will not copy pages > - * with the CPU. Instead, page copy happens outside the migratepage() > - * callback and is likely using a DMA engine. See migrate_vma() and HMM > - * (mm/hmm.c) for users of this mode. > */ > enum migrate_mode { > MIGRATE_ASYNC, > MIGRATE_SYNC_LIGHT, > MIGRATE_SYNC, > - MIGRATE_SYNC_NO_COPY, > }; > > enum migrate_reason { > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 22c96fed70b5..6597ebea8ae2 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -234,14 +234,6 @@ static int balloon_page_migrate(struct page *newpage, struct page *page, > { > struct balloon_dev_info *balloon = balloon_page_device(page); > > - /* > - * We can not easily support the no copy case here so ignore it as it > - * is unlikely to be used with balloon pages. See include/linux/hmm.h > - * for a user of the MIGRATE_SYNC_NO_COPY mode. > - */ > - if (mode == MIGRATE_SYNC_NO_COPY) > - return -EINVAL; > - > VM_BUG_ON_PAGE(!PageLocked(page), page); > VM_BUG_ON_PAGE(!PageLocked(newpage), newpage); > > diff --git a/mm/migrate.c b/mm/migrate.c > index 1d1cb832fdb4..e04b451c4289 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -671,10 +671,7 @@ static int __migrate_folio(struct address_space *mapping, struct folio *dst, > if (src_private) > folio_attach_private(dst, folio_detach_private(src)); > > - if (mode != MIGRATE_SYNC_NO_COPY) > - folio_migrate_copy(dst, src); > - else > - folio_migrate_flags(dst, src); > + folio_migrate_copy(dst, src); > return MIGRATEPAGE_SUCCESS; > } > > @@ -903,7 +900,6 @@ static int fallback_migrate_folio(struct address_space *mapping, > /* Only writeback folios in full synchronous migration */ > switch (mode) { > case MIGRATE_SYNC: > - case MIGRATE_SYNC_NO_COPY: > break; > default: > return -EBUSY; > @@ -1161,7 +1157,6 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, > */ > switch (mode) { > case MIGRATE_SYNC: > - case MIGRATE_SYNC_NO_COPY: > break; > default: > rc = -EBUSY; > @@ -1372,7 +1367,6 @@ static int unmap_and_move_huge_page(new_folio_t get_new_folio, > goto out; > switch (mode) { > case MIGRATE_SYNC: > - case MIGRATE_SYNC_NO_COPY: > break; > default: > goto out; > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index b42d3545ca85..6e7967853477 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1752,14 +1752,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, > unsigned long old_obj, new_obj; > unsigned int obj_idx; > > - /* > - * We cannot support the _NO_COPY case here, because copy needs to > - * happen under the zs lock, which does not work with > - * MIGRATE_SYNC_NO_COPY workflow. > - */ > - if (mode == MIGRATE_SYNC_NO_COPY) > - return -EINVAL; > - > VM_BUG_ON_PAGE(!PageIsolated(page), page); > > /* The page is locked, so this pointer must remain valid */ Except the nits above, patch looks good to me. Reviewed-by: Jane Chu -jane