From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292AEC433E1 for ; Fri, 21 Aug 2020 06:54:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77C7B20748 for ; Fri, 21 Aug 2020 06:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Bj0Y0Wto" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77C7B20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE8BF6B00AD; Fri, 21 Aug 2020 02:54:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9A556B00AE; Fri, 21 Aug 2020 02:54:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A887F6B00AF; Fri, 21 Aug 2020 02:54:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 92AC36B00AD for ; Fri, 21 Aug 2020 02:54:13 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 355F53632 for ; Fri, 21 Aug 2020 06:54:13 +0000 (UTC) X-FDA: 77173661586.03.beast22_350f9ca27037 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id E8A0A28A4E9 for ; Fri, 21 Aug 2020 06:54:12 +0000 (UTC) X-HE-Tag: beast22_350f9ca27037 X-Filterd-Recvd-Size: 9066 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 06:54:11 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07L6VsaW106348; Fri, 21 Aug 2020 02:54:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=JfCVa6u8ZV0vVGELmaiUOueR6O9KLufx2oCEI1ijkrg=; b=Bj0Y0WtoP6sLSug+3Gp0TBWmT+k99ljYmOR4gyNWBAo6RsPORllyciRlHtG5DgvcSkpU 8/okaZbyfNAAYzDZ1H4tdpUq4yD2Y3Gc/zCvuw7LriSyShF/W05JCIkpnPiI3gAIzBJb Eg2G/roSgBEkgXp+QNZYHCAsoQseelNvO8WBZyrlwBYhoyG+oXMzKtJVO0kW+yfnyNTQ QjITp+V53tS6WhOROADkXPWgyWKRGr2zj14Se1GdemJ2kQ3rxo71hG/6gNkghNz0BAjJ FIxUAWH4V25RbzPQ1dvqjhuFMGYH/N7rkZncp/kCIzGoz4YXxgP/+W0y3+k2mpFv7tXd 6A== Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 3327nejsbu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Aug 2020 02:54:03 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07L6itQg013477; Fri, 21 Aug 2020 06:54:01 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 3304cc41s6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Aug 2020 06:54:01 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07L6qTVA459446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Aug 2020 06:52:29 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E08D7AE053; Fri, 21 Aug 2020 06:53:58 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D9416AE055; Fri, 21 Aug 2020 06:53:57 +0000 (GMT) Received: from [9.102.2.201] (unknown [9.102.2.201]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 21 Aug 2020 06:53:57 +0000 (GMT) Subject: Re: [PATCH v2 00/13] mm/debug_vm_pgtable fixes To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org References: <20200819130107.478414-1-aneesh.kumar@linux.ibm.com> <87tuwyvjei.fsf@linux.ibm.com> <856eb6d7-9c09-728e-b374-d787145ac052@arm.com> From: "Aneesh Kumar K.V" Message-ID: <46cc2987-0d1e-f8e8-ecaf-2d246b33413e@linux.ibm.com> Date: Fri, 21 Aug 2020 12:23:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <856eb6d7-9c09-728e-b374-d787145ac052@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-21_05:2020-08-19,2020-08-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008210057 X-Rspamd-Queue-Id: E8A0A28A4E9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/21/20 9:03 AM, Anshuman Khandual wrote: >=20 >=20 > On 08/19/2020 07:15 PM, Aneesh Kumar K.V wrote: >> "Aneesh Kumar K.V" writes: >> >>> This patch series includes fixes for debug_vm_pgtable test code so th= at >>> they follow page table updates rules correctly. The first two patches= introduce >>> changes w.r.t ppc64. The patches are included in this series for comp= leteness. We can >>> merge them via ppc64 tree if required. >>> >>> Hugetlb test is disabled on ppc64 because that needs larger change to= satisfy >>> page table update rules. >>> >>> Changes from V1: >>> * Address review feedback >>> * drop test specific pfn_pte and pfn_pmd. >>> * Update ppc64 page table helper to add _PAGE_PTE >>> >>> Aneesh Kumar K.V (13): >>> powerpc/mm: Add DEBUG_VM WARN for pmd_clear >>> powerpc/mm: Move setting pte specific flags to pfn_pte >>> mm/debug_vm_pgtable/ppc64: Avoid setting top bits in radom value >>> mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify hug= e >>> vmap support. >>> mm/debug_vm_pgtable/savedwrite: Enable savedwrite test with >>> CONFIG_NUMA_BALANCING >>> mm/debug_vm_pgtable/THP: Mark the pte entry huge before using >>> set_pmd/pud_at >>> mm/debug_vm_pgtable/set_pte/pmd/pud: Don't use set_*_at to update = an >>> existing pte entry >>> mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP >>> mm/debug_vm_pgtable/locks: Move non page table modifying test toge= ther >>> mm/debug_vm_pgtable/locks: Take correct page table lock >>> mm/debug_vm_pgtable/pmd_clear: Don't use pmd/pud_clear on pte entr= ies >>> mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 >>> mm/debug_vm_pgtable: populate a pte entry before fetching it >>> >>> arch/powerpc/include/asm/book3s/64/pgtable.h | 29 +++- >>> arch/powerpc/include/asm/nohash/pgtable.h | 5 - >>> arch/powerpc/mm/book3s64/pgtable.c | 2 +- >>> arch/powerpc/mm/pgtable.c | 5 - >>> include/linux/io.h | 12 ++ >>> mm/debug_vm_pgtable.c | 151 +++++++++++-----= --- >>> 6 files changed, 127 insertions(+), 77 deletions(-) >>> >> >> BTW I picked a wrong branch when sending this. Attaching the diff >> against what I want to send. pfn_pmd() no more updates _PAGE_PTE >> because that is handled by pmd_mkhuge(). >> >> diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book= 3s64/pgtable.c >> index 3b4da7c63e28..e18ae50a275c 100644 >> --- a/arch/powerpc/mm/book3s64/pgtable.c >> +++ b/arch/powerpc/mm/book3s64/pgtable.c >> @@ -141,7 +141,7 @@ pmd_t pfn_pmd(unsigned long pfn, pgprot_t pgprot) >> unsigned long pmdv; >> =20 >> pmdv =3D (pfn << PAGE_SHIFT) & PTE_RPN_MASK; >> - return __pmd(pmdv | pgprot_val(pgprot) | _PAGE_PTE); >> + return pmd_set_protbits(__pmd(pmdv), pgprot); >> } >> =20 >> pmd_t mk_pmd(struct page *page, pgprot_t pgprot) >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index 7d9f8e1d790f..cad61d22f33a 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -229,7 +229,7 @@ static void __init pmd_huge_tests(pmd_t *pmdp, uns= igned long pfn, pgprot_t prot) >> =20 >> static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t = prot) >> { >> - pmd_t pmd =3D pfn_pmd(pfn, prot); >> + pmd_t pmd =3D pmd_mkhuge(pfn_pmd(pfn, prot)); >> =20 >> if (!IS_ENABLED(CONFIG_NUMA_BALANCING)) >> return; >> >=20 > Cover letter does not mention which branch or tag this series applies o= n. > Just assumed it to be 5.9-rc1. Should the above changes be captured as = a > pre-requisite patch ? >=20 > Anyways, the series fails to be build on arm64. >=20 > A) Without CONFIG_TRANSPARENT_HUGEPAGE >=20 > mm/debug_vm_pgtable.c: In function =E2=80=98debug_vm_pgtable=E2=80=99: > mm/debug_vm_pgtable.c:1045:2: error: too many arguments to function =E2= =80=98pmd_advanced_tests=E2=80=99 > pmd_advanced_tests(mm, vma, pmdp, pmd_aligned, vaddr, prot, saved_pt= ep); > ^~~~~~~~~~~~~~~~~~ > mm/debug_vm_pgtable.c:366:20: note: declared here > static void __init pmd_advanced_tests(struct mm_struct *mm, > ^~~~~~~~~~~~~~~~~~ >=20 > B) As mentioned previously, this should be solved by including >=20 > mm/debug_vm_pgtable.c: In function =E2=80=98pmd_huge_tests=E2=80=99: > mm/debug_vm_pgtable.c:215:7: error: implicit declaration of function =E2= =80=98arch_ioremap_pmd_supported=E2=80=99; did you mean =E2=80=98arch_dis= able_smp_support=E2=80=99? [-Werror=3Dimplicit-function-declaration] > if (!arch_ioremap_pmd_supported()) > ^~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > Please make sure that the series builds on all enabled platforms i.e x8= 6, > arm64, ppc32, ppc64, arc, s390 along with selectively enabling/disablin= g > all the features that make various #ifdefs in the test. >=20 I was hoping to get kernel test robot build report to verify that. But=20 if you can help with that i have pushed a branch to github with reported=20 build failure fixes. https://github.com/kvaneesh/linux/tree/debug_vm_pgtable I still haven't looked at the PMD_FOLDED feedback from Christophe=20 because I am not sure i follow why we are checking for PMD folded there. -aneesh