From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CE4C83F34 for ; Thu, 17 Jul 2025 18:30:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4536A8D0010; Thu, 17 Jul 2025 14:30:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4036D8D0006; Thu, 17 Jul 2025 14:30:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27CDC8D0010; Thu, 17 Jul 2025 14:30:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 15DE58D0006 for ; Thu, 17 Jul 2025 14:30:21 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9757FB5E66 for ; Thu, 17 Jul 2025 18:30:20 +0000 (UTC) X-FDA: 83674596600.17.FCACBFF Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf22.hostedemail.com (Postfix) with ESMTP id 739C3C000F for ; Thu, 17 Jul 2025 18:30:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=Xu+B5dJY; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=IlXFhuOR; spf=pass (imf22.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1752777017; a=rsa-sha256; cv=pass; b=VWzfnoTHEH5HxmQWZxxuz4fkGT2xVRwoMzJ0QclDsWHrB3LdIiTmcnO1ascONJgZAIUEXD ywk1Dt1agTH/Qe14PY6vgfYmTSprLorHUE8dE9uPceR8shRF19A0JNRIlt7qj26llCQp6X NCKfXWkt+Xlv/U+hMA6f9xSKX3C2XgI= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=Xu+B5dJY; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=IlXFhuOR; spf=pass (imf22.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752777017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jCVErSjY9j4kFQZZhZJn1T4o4Xhqna9iwJ7QJxdvbnA=; b=pMDYqlg9SRRZh4kCQXXpmtI6a7N0vxs8ryYboqvyrHfq8hGOH4fvfpnTDNG9Lskb9VLPjX afRf7k+I7FZieRHOEjg8uGeEViWZiScWUn9MhPpfI3/glSEBrN6c6KlcbeGdBVnnQtSLEu v2DT5fvyDeFXP+AIyXnXQSDyx7f9B2U= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56HH0hQU027480; Thu, 17 Jul 2025 18:30:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=jCVErSjY9j4kFQZZhZ Jn1T4o4Xhqna9iwJ7QJxdvbnA=; b=Xu+B5dJY0rqxVbmEatL2Zk/SCsGCi7jAMo eEGAbrGy6TTrncddyttVXwhT5QH7PRVTwanKMzYNrRAcIT6/h1ItP/h5dkWfZEKA iYsCKTHID3EJ13oXlBH3Psqt2mG4qKxssN2P0kNz3mAz3Wsmv/OSoiiyV373h2EI UlTOm8fMUxAae2VT2tzIo8WMb9UTuoMAgyvauTAr/yPULg2vnyIlmnMl/CIhK4Mh WOSgduUvFNx7W3iZx5+/ceRErGjOv/YNO2KdteoyAbbjtPPdXDDaicdHD+N7g5St ZcYt79ASTJMIpXEe8zyItXkqsXfpo27+saF6LB1p0XJa0qQxlEoQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47uk1b3rqy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jul 2025 18:30:02 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 56HGwQVR011697; Thu, 17 Jul 2025 18:30:02 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10on2073.outbound.protection.outlook.com [40.107.94.73]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ue5d4tmv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jul 2025 18:30:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TDUwLNegLO3WA7ev2di7RW/Ze+OHAe2KsMagOR5sXAOG0YHmixySnOgeq4vDysIsqn5xAHmvGeuphumOUBMcjjQeERCgXr1yzWkzzUZCguNvd8C/0GVwh1MnyVw8QYSeZGQG7umLi+6frnST5hc09McIEIwbAZ+AwJlYr1uCMLLUA5bM12cHdQL6inIGuK4MmV5PPH55gkR3xtv+1tHBNEVn6v9EBMRPwQppmSYNOVSFu2BYW+QkyayAKBGB1bIjEaJY+BkqpoIdPTFt4gCmn8Y/iOmomMWMuWr2oUefBs1I1/z4F86Zsb6V2QwWelwMFI5O2Q0qI+0uBxVTLQjrQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jCVErSjY9j4kFQZZhZJn1T4o4Xhqna9iwJ7QJxdvbnA=; b=esGv4De2HhYkE2sdKomGP5bxWWCEkGknwRbu01I+GzFxMgJ5b5Tv8efU1eubBGuuOJzdIJjr9GC/o8UZIGTOt3OPUAUnoIvUQvtMwlwSWozPtgiAQldjtDzWKJ6g49HpeX2v/cnR+XgseTEx4Qq8MeG9dSoSb+kJ/G20a2wVY3z107GwsCGbWvKHMENLlCRnQM3JvE9pzHU7fOEGOZcsVZGyexG3wf02VbkB7CL0DHcWsRwp3oyTjSq8KSFz+/LKSiXezVeOjTmMgKZTwP3GoBPyGdPZdFnNctHcWSFFwFzdbw566tUnDuKXyiVTU6f5XvGwTf3eP7Iq4cQ0VvBJrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jCVErSjY9j4kFQZZhZJn1T4o4Xhqna9iwJ7QJxdvbnA=; b=IlXFhuORjRtSAokVQQCv7rARKMO5xKUzKkCeiOpOZwyUNP1gTzHA+OHl1JuKd+EMFdLAB4mUY3LID5HY99HyUvXLeBytj0GP2EOMWQTmbDv0esp/PGpvwKwCmo1oncWVv8sfqPaEUab7NVZYkoSXlxa6/jnt9DlmwYxH2KNziN8= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by SJ1PR10MB6003.namprd10.prod.outlook.com (2603:10b6:a03:45e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.35; Thu, 17 Jul 2025 18:29:58 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8922.037; Thu, 17 Jul 2025 18:29:58 +0000 Date: Thu, 17 Jul 2025 19:29:56 +0100 From: Lorenzo Stoakes To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Oscar Salvador , Lance Yang Subject: Re: [PATCH v2 5/9] mm/huge_memory: mark PMD mappings of the huge zero folio special Message-ID: <46c9a90c-46b8-4136-9890-b9b2b97ee1bb@lucifer.local> References: <20250717115212.1825089-1-david@redhat.com> <20250717115212.1825089-6-david@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250717115212.1825089-6-david@redhat.com> X-ClientProxiedBy: LO4P123CA0431.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::22) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|SJ1PR10MB6003:EE_ X-MS-Office365-Filtering-Correlation-Id: 92932ffa-bbd5-4cd1-6429-08ddc55fef61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Z/OOzy1ici6d48CfXV4ndQGX4YLevG1P1YmrqOdKMgbYJeEtxjuoKa7VCdPN?= =?us-ascii?Q?Wix2kMipLcooemHLbN/djIc8fS5iTtZNkkTFINyL8hbC9iMPWtQdOjjIITkC?= =?us-ascii?Q?+SJ3lifaNvvlRIjHuDBacOLPFCEeFKZU9x6LAuev7KEfO+4AgMn80O8YSvNi?= =?us-ascii?Q?TispwwgoedZSRYi5UOSN8cQhTRMhOrLn0N9u/6Pf2jk4440wI0Gp46PPanSz?= =?us-ascii?Q?wfCP4Px4P8jmo/cZMqfGd95NfTLS3j9FOpZnEzu+h/JzCSzNNM3rLzpVf7ra?= =?us-ascii?Q?gS4sff3Hf713VUQNraA+9ee19NNeh481LMFwOAD+BDqDvVY2jJZW4YMfdRUj?= =?us-ascii?Q?neY2cHGy6UgCpZ4eNkHJ20dEciynxszZvw5oRw8hDpqMpVD99RIUMCGUlQEG?= =?us-ascii?Q?Utt55wkrZwB8vijfoOeUcyq47SC3uOBPcUjkAQiXBwh/rcijSLO959mLH9On?= =?us-ascii?Q?To6Li2rAburMLln1rPSuxTI9hYaeYCdwTRP4tN7oOAowsnMvxz9qyYQIGTkV?= =?us-ascii?Q?kcOpip/PKLEOJHGzK7iWt4Gm3hKqqVarXIGqXDQS9YVHyvOYb5NMFxUgjk7J?= =?us-ascii?Q?ZU6j8GyAPte0TifcoPDE8E6j9PNId3kA6o0x8JgsLuiYICaoi53Dz1h+dj4w?= =?us-ascii?Q?r2E/ZHG8XyXWaiGp73ktX9rp4Ryub7BvFnqThXeD4NSzyr5mUxv2hKn2vkWh?= =?us-ascii?Q?JPGU87W8AXbIYm32nshN2DsWfjO3L1q7SMdeEEkauQUcmEB/7pRag5MYQhhh?= =?us-ascii?Q?IBZ7EAIVc01OJW2woWpuHPUZEhw9hDPcQ4GH76gQA7Oh5FfNPJwXhOrLHVT+?= =?us-ascii?Q?Xz9Gtv5NwYAYnvZVOdJiJbFPaYbK3C5HS1tcwzjw8S3m6HeEK7NVMHktODy6?= =?us-ascii?Q?x4NAIRJos6/1+t+jATqdY+TpZQsOAZSPA6y9H+Otkv2uNDgVNteidM4/yEy6?= =?us-ascii?Q?v8yn0dDe/oD6fkM1eKqJqFCb39Xi4EOtEOsPaBRW70IB8cY2vU0DNmfJ42E3?= =?us-ascii?Q?4bD7yCKjyfgXf2/Sqgj/GPhX19YM4mCtnPIsA2jmEo7d47lpYIMr5CnrvYka?= =?us-ascii?Q?UjRIZ2oQWvBXhJ90kFTSH5y2DiWgExHXSGqjFQ8AZqM63Bwd1l8fUrJR+lsf?= =?us-ascii?Q?B5zHn5O5DUdTglTT6/G+OAnfnH8Fq0e8iVKszJGmgpWPcaGKJRAJWjNUDokD?= =?us-ascii?Q?SQYPx37eXrKgpgS+ZPxb7kocXc1SFF40KJdmlpVtP8BFp54/aYFw9MsTHf04?= =?us-ascii?Q?loSH5lUsJUxw7qi072VWzhwgUOan4dKzbBvKO2bcCu5OtI2N42F1+uHXlw6g?= =?us-ascii?Q?/VSzB7I/h8NArAgOREMxh3gxB8pIGDYG3uLLxPVEJpoGc1tq4atB0vkcieuR?= =?us-ascii?Q?bOeKTJP45SqpypsuuEVKD2JnI6W40R1cm7TgIz/mrjg9eYq78s4baX12fSva?= =?us-ascii?Q?a7c/JGhfL1I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AieGuzgInfjR5HttSH1zrzh48dT8ae9m6bxGzLQc8zmUyHYaIWlqsJTjY3zD?= =?us-ascii?Q?j3Jfti0YhJBlMK9UlebFPr0qeFaz0nxAZg39UHwmIeZeHtbaiNU6eULJtmN7?= =?us-ascii?Q?h2+0rbbilozkcnKnH5UtsrdPDPdxY5lb6ak6oSE2YGMKn1FiQjqc2iucYczq?= =?us-ascii?Q?pDEM+pQVZnXwwfNVJdB+CSnn+3/LfvMKCDhJOn7HoJjAHyDhvhI+yMnWVp7j?= =?us-ascii?Q?K6XVyPXwckCO8swBuCZzCsE/RyGOYCl8WyTVI0cUO8XNbzHbxq853yH6NP6y?= =?us-ascii?Q?G9Ep1Jbq85qJD/TheiqOQ+0rf5rsH2BJYjUF49Ak2iG6dMqJHYSAD8pQFtQ9?= =?us-ascii?Q?XvwS5dcxfrcCoUbJ3bq5aQsSX8Z0x7fDe9mpsek43YUKjDReJyfNqgc1eDFc?= =?us-ascii?Q?2v2RxVa9QzHHd3BwdJKN8rXFwFjbyZ9my4uL6ovkBpyghxizRmY8NhiOrC1/?= =?us-ascii?Q?qCRvEJ6SUBFNKM6wtSLL3vVIxq+PncUnRkiflWCS5VPPIkoROWoH4pnEg/nY?= =?us-ascii?Q?ECvV0Hxbk3rrKNEw2jVo1iE+D8FqklfSlBdQHTGC8J2ysWMyc1NGVSne06aq?= =?us-ascii?Q?RgIkckEoQAvGH8LLWOk/Vqgb4Bg2LHCW0tKhlUNWewRvusUekeSHc1ThfWt4?= =?us-ascii?Q?lj1HHRqwivEeSnNiw1FbHAmAmRTKGyOB9IuHMiCUbcEljQ7Mt8Q5l4I7lzoE?= =?us-ascii?Q?4g/hihntaFhz2b5mpEE2El1GibUpTFg6+1OhH3VuTK8NulgVAcgTkddLnLDX?= =?us-ascii?Q?o/nJYOOOqU1fyMfnJ2SY2iPk5k9AdpAwmVuLgkH39uEKh6eKCe3BA2vPH84F?= =?us-ascii?Q?LgWRWHMgK0RDtdsBTi9cLIuaNujX2sxz4iCu6jWgV3MOjTuoZTEZxRGuKLv9?= =?us-ascii?Q?d1jg6NyNBQzyC3zxOGy9BKBmpZcXEYbx6zrTSRQ5ATXvymZ5uZYJQ84umiUP?= =?us-ascii?Q?CAxWxOgvIYmfzUd0ScHJI4oyelIo4khA54t2fQNGfJpubpjTZZqEIakNAuLX?= =?us-ascii?Q?hefD0DAoX/LENUDj/mdXJUySutjJlz9AeHupRszlLTdsLm+XZuXLx/GSfsLs?= =?us-ascii?Q?9iFK8QG5BHGfUvUg8GgnfRqWZtPNdZMw+bYTfyuhbQH3fDEnfFbTpzSfWrJk?= =?us-ascii?Q?qOYyap7T5rS5AdHw7F6nl/Ois9symvGJm4OSwzSVpXGB+IfkvOSHFNfG3F6a?= =?us-ascii?Q?UPoG00q3hEkXS4N3m8VCIbALq3S2xKWcs369CuWcbCxtFEO3MnwQlRrHBzHp?= =?us-ascii?Q?Xe0IVkC+2mVBCkUVAVKONCgIb0YPkBLX3D98CXnbMj9K+CJnxPgrq9ln4ZCZ?= =?us-ascii?Q?J2OE2HczrspLa49j0E3UrvtehLtwyypJw1lT0KHO8kLWpgOFS8GqF+OiYF+I?= =?us-ascii?Q?lTXTiJ1jvHy155yspdvJrZXhciNvU/vW9XLIiCqecU+d6rh3l3zX/dk6eoWr?= =?us-ascii?Q?hSvkSnbgyi7jwSr5AfBAyil1bKy6r5RnBR9nE5VrY3CmbI3DEyTqzUv+EalK?= =?us-ascii?Q?+arWBUXEeBMhk2h1j9o2U9XaIIwLma8Q1LHGkWBPzXQZRGhrae4bI2h4TI+l?= =?us-ascii?Q?BEjFReDUkr3JR+t7I6a695V9QBwiLjitPVW5Q6WgTFhSZ7XLgy1px/VEBDv8?= =?us-ascii?Q?Pw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: spdu9VDNlzyRjfMSeHPGGHKIK2gTKLU3Qu/q62IjHS8wb+rcDIcNeHSA4CImIbdJFYL6/wdr5DGbEI5KhP7GIMTeC6QWSkP0hmMIkBxW6iYFbK24rK4QZheFBWCShhjSn56nYuKSX2qhw10ngYIAh2q28qlLXrNq0Kvde9RhGMoV7S6DCKdJO7sNadvMKZjL2jgEtxP6bD2JXamrQ0aAESboaTjQgqKxzDjzoXpM29Nkkl+8Ye2BPdSdBWF2lhL5s91AcGBwrbVvBaa2zzGmjOPfyNtqguD/TPLe2IOsggjri8zuZftBDbvlzptgJoQcFJTPWspNJdAtjxMa1JuDEWZF40JSD2GlYBv2fe/BaUXfLJXeWfRn65rk147+MuMaZTlpk5QSiSS6akNSZJ4iJeNvgzXGAJ8UoiN96pD91gIMrf3joxHRbBDYALO8ztL9NcvZQvb9XrACSQOGeb3PpKi9m09VSVfX4HSyZU2EaG4V4MoHQrfgMYqYjrkAUW9lCAwuGCyIJZTiKdgIBEGRazTT334RcUdTahT50Nf5LeOablafYj41wuJFJuya99sEe0hHCw5EMvsS/zHFWGQDEucw3y8xYINt6zsalz2rlPc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92932ffa-bbd5-4cd1-6429-08ddc55fef61 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2025 18:29:58.5916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pUiQNQqwTLadDSu0aNmOgERetYJFkEI5ypnBJCi4PNlxmjaFxJAUoGUxGhbNy5SaYs/ecVcX9685I8U3chHanMkVpq348MiKvlkx7zyl5NM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB6003 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-17_02,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507170164 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE3MDE2MyBTYWx0ZWRfX64v4kNMaEMa/ USq/ZNIk8I9xfyGWGTN/zmg5u8J0S0HmRwdm6o0BJAMn4oJaRld47Owvsnt6xGjNxg8fSNNlOKj piSvi4T14+Ls4Ed3TO6eciiDQ2Xl4zjWDkGubE0zZblqcERvdo9V3M2P4seloEzbFMV9JKB3rrx Kuh8cMLQlpczduj4hUdvtKKN9cZdjH6ay2XRijOso/vTefnll1yesF29w4WrlbMaKdzdN1Go8Xb Vr97fE9pmIwnMWTONnAm7BgXb2PhYTa5X4H/ob7ivVLtg2YnDCXwgFqWGodx+Lk3EXpDlv9lEsU V9H4Oy74O37NpXcyEWI+AKpSmPHhxcf4i+Dxyq6tZQVytLxWo3Qkr17S8QrOEW6/wua4kQFqc7Z twOxTuQUWiKIPnSuOQui/1gmKvMav/jZHiVUvD9Qo1lap9FwhSezMScxcXvJtG7ajhqO9Kmh X-Proofpoint-GUID: xNVMpZd53jc4LKesR0lqIi54vB6JW6FT X-Proofpoint-ORIG-GUID: xNVMpZd53jc4LKesR0lqIi54vB6JW6FT X-Authority-Analysis: v=2.4 cv=J8mq7BnS c=1 sm=1 tr=0 ts=6879412b b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=NB37xtsDAAAA:8 a=20KFwNOVAAAA:8 a=yPCof4ZbAAAA:8 a=jxEKDuIVVPS2-SOLZhgA:9 a=CjuIK1q_8ugA:10 a=IlkzfGtsIyjWS4YjqO81:22 cc=ntf awl=host:12062 X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 739C3C000F X-Stat-Signature: h3pjn6taww14gh9mmyw46e5rzguhw4io X-HE-Tag: 1752777017-247096 X-HE-Meta: U2FsdGVkX18dZz2VNKDWhR6X7EUMC7KyVQSSr8a391K1AvN06q/5DN69bNfGvkP+ukZ75eP7nPCejZLR0ZEs8q0vBcM58P+cf0W48higtsKYnfuuGm4Jyq6ZJ8HMgcafVGIYaa0raMfJD39V6OTLP0JGbg1YY1Et6tIeYOw+sF5L0DBwyIkyoq10lh/eaL59yQwNoYOzHdNpV0EHDuqwrglh1IZA8UXM/mSnNAh1/prjO+JFfKmQcXUHbVX788VlxKiM7dTiE8R4r2mhBl+unkd6Ezr/iJTPh5qNda8umQpIDL/jEspK1aIgIfkOXYktzsdcA7A20Y67o/wX49Hg6ZN3VrftyOyqi8K5rwmcaRdejYaKyWI2EbwJoSXeZ8rnyn3GJYJq/Ni7dLwMg3HoRBBFdIf0xWwOLv/8cSEH8SlTEvOzHlFH49fHonYlhq6JLGn2T758yN0NQSV9vx+A3nHn0RojGcpTJbphGGj4XzWfUgdkciQD44I3/hwbg+BFnpuaCquUpOoMDH2VRqenBfJqCBxq1lcC9B3W6EsIEmxYjkiNaj4yanuyLNCOJby3cxkw0TfoiI+qJmR9h4HBu2h/A2mwZSXn4bnGGjvi5TGcnGHxofaiZG9idqkiwOjxXT1Y8Hv0XiO3eNLy4RfWJmSY5L0hAMq4Y1vcOlIInSs9EjdXBaMN9/FxrQWT3Sf30e3YAMNZfc+qK08KD1VUQ6OTbIuZsOwQtlmXUmHQ6xAfAGQDTF1SmKzXcExcpoTDXmuZE1Ii6DnteTlhSf2EA52sZSr8N4RNHhSbv6s0k10fg+zYIVzdD3sJU9gla625MzS3QkuTL6Dpr3lI8+czcVARdM4aWwC0PdCbOFFmvF/xUZsQEtuFlLmofkpWN+mP5ZJS+GxrSc4FSAOuYuyEGmCI8TIAnpYRNLxjwHtsvB3kCJXyOJx99/hbBGpnZKlmxozzST1KRp5kUuoCBxX P7lOnzue gzv/67UpEWI1XpIDT9K96tjbf1wkZNMug48LMV4Sy/q4QkzTgSAasm4krdDZbJDHCikY3fphCr6Au29NwXjAqjVDgDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 01:52:08PM +0200, David Hildenbrand wrote: > The huge zero folio is refcounted (+mapcounted -- is that a word?) > differently than "normal" folios, similarly (but different) to the ordinary > shared zeropage. Yeah, I sort of wonder if we shouldn't just _not_ do any of that with zero pages? But for some reason the huge zero page wants to exist or not exist based on usage for one. Which is stupid to me. > > For this reason, we special-case these pages in > vm_normal_page*/vm_normal_folio*, and only allow selected callers to > still use them (e.g., GUP can still take a reference on them). > > vm_normal_page_pmd() already filters out the huge zero folio. However, > so far we are not marking it as special like we do with the ordinary > shared zeropage. Let's mark it as special, so we can further refactor > vm_normal_page_pmd() and vm_normal_page(). > > While at it, update the doc regarding the shared zero folios. Hmm I wonder how this will interact with the static PMD series at [0]? I wonder if more use of that might result in some weirdness with refcounting etc.? Also, that series was (though I reviewed against it) moving stuff that references the huge zero folio out of there, but also generally allows access and mapping of this folio via largest_zero_folio() so not only via insert_pmd(). So we're going to end up with mappings of this that are not marked special that are potentially going to have refcount/mapcount manipulation that contradict what you're doing here perhaps? [0]: https://lore.kernel.org/all/20250707142319.319642-1-kernel@pankajraghav.com/ > > Reviewed-by: Oscar Salvador > Signed-off-by: David Hildenbrand I looked thorugh places that use vm_normal_page_pm() (other than decl of function): fs/proc/task_mmu.c - seems to handle NULL page correctly + still undertsands zero page mm/pagewalk.c - correctly handles NULL page + huge zero page mm/huge_memory.c - can_change_pmd_writable() correctly returns false. And all seems to work wtih this change. Overall, other than concerns above + nits below LGTM, we should treat all the zero folios the same in this regard, so: Reviewed-by: Lorenzo Stoakes > --- > mm/huge_memory.c | 5 ++++- > mm/memory.c | 14 +++++++++----- > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index db08c37b87077..3f9a27812a590 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1320,6 +1320,7 @@ static void set_huge_zero_folio(pgtable_t pgtable, struct mm_struct *mm, > { > pmd_t entry; > entry = folio_mk_pmd(zero_folio, vma->vm_page_prot); > + entry = pmd_mkspecial(entry); > pgtable_trans_huge_deposit(mm, pmd, pgtable); > set_pmd_at(mm, haddr, pmd, entry); > mm_inc_nr_ptes(mm); > @@ -1429,7 +1430,9 @@ static vm_fault_t insert_pmd(struct vm_area_struct *vma, unsigned long addr, > if (fop.is_folio) { > entry = folio_mk_pmd(fop.folio, vma->vm_page_prot); > > - if (!is_huge_zero_folio(fop.folio)) { > + if (is_huge_zero_folio(fop.folio)) { > + entry = pmd_mkspecial(entry); > + } else { > folio_get(fop.folio); > folio_add_file_rmap_pmd(fop.folio, &fop.folio->page, vma); > add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PMD_NR); > diff --git a/mm/memory.c b/mm/memory.c > index 92fd18a5d8d1f..173eb6267e0ac 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -537,7 +537,13 @@ static void print_bad_pte(struct vm_area_struct *vma, unsigned long addr, > * > * "Special" mappings do not wish to be associated with a "struct page" (either > * it doesn't exist, or it exists but they don't want to touch it). In this > - * case, NULL is returned here. "Normal" mappings do have a struct page. > + * case, NULL is returned here. "Normal" mappings do have a struct page and > + * are ordinarily refcounted. > + * > + * Page mappings of the shared zero folios are always considered "special", as > + * they are not ordinarily refcounted. However, selected page table walkers > + * (such as GUP) can still identify these mappings and work with the > + * underlying "struct page". I feel like we need more detail or something more explicit about what 'not ordinary' refcounting constitutes. This is a bit vague. > * > * There are 2 broad cases. Firstly, an architecture may define a pte_special() > * pte bit, in which case this function is trivial. Secondly, an architecture > @@ -567,9 +573,8 @@ static void print_bad_pte(struct vm_area_struct *vma, unsigned long addr, > * > * VM_MIXEDMAP mappings can likewise contain memory with or without "struct > * page" backing, however the difference is that _all_ pages with a struct > - * page (that is, those where pfn_valid is true) are refcounted and considered > - * normal pages by the VM. The only exception are zeropages, which are > - * *never* refcounted. > + * page (that is, those where pfn_valid is true, except the shared zero > + * folios) are refcounted and considered normal pages by the VM. > * > * The disadvantage is that pages are refcounted (which can be slower and > * simply not an option for some PFNMAP users). The advantage is that we > @@ -649,7 +654,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, You know I"m semi-ashamed to admit I didn't even know this function exists. But yikes that we have a separate function like this just for PMDs. > { > unsigned long pfn = pmd_pfn(pmd); > > - /* Currently it's only used for huge pfnmaps */ > if (unlikely(pmd_special(pmd))) > return NULL; > > -- > 2.50.1 >