From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B303C021B3 for ; Sat, 22 Feb 2025 02:37:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEDB76B0089; Fri, 21 Feb 2025 21:37:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9D966B008A; Fri, 21 Feb 2025 21:37:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D65346B008C; Fri, 21 Feb 2025 21:37:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B97706B0089 for ; Fri, 21 Feb 2025 21:37:20 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4B8F0A3103 for ; Sat, 22 Feb 2025 02:37:20 +0000 (UTC) X-FDA: 83146019040.21.5DD2F98 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf21.hostedemail.com (Postfix) with ESMTP id CC4121C0006 for ; Sat, 22 Feb 2025 02:37:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740191838; a=rsa-sha256; cv=none; b=ECTvGCt5rezAxZxd490ozVSezSRJNXsV4o0xzac+P1hpvppl+ZUIkooyqzYxf+JGUjGKUB CWmgZR3r4vlSIvhIp+al0eNs4EdEX+GP7LnPNVl8K+ZyqaHkmH5W1feo19Qpce35GgCh5o 0SgwccLgvAW+JyVHArK5g9c//vRoaxo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740191838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8JQ79Cj1dMR5Y3ZkJCOhcWPss8Pp2mi2FAZg5JzvQ1E=; b=XOqyWFAo5WpQU+6exJamGDyS2GmZUk1IEsOFvJ41Fyg8FlSFTDqGLV0R9Kg63WdqdgAZ/h pysNYBkXYpzMdNMLOL2H2YsEI4jeGgY3x/UcuCbAJykGEqPz3xy5qW6yIFfGk1NdsGusS1 xFl+iZoPWNeN2txsceDk0anQKAVCqiM= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Z09yz4xwfz1ltY1; Sat, 22 Feb 2025 10:33:15 +0800 (CST) Received: from kwepemk500005.china.huawei.com (unknown [7.202.194.90]) by mail.maildlp.com (Postfix) with ESMTPS id A89D81A016C; Sat, 22 Feb 2025 10:37:13 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 22 Feb 2025 10:37:12 +0800 Message-ID: <46a48eb4-5245-81ba-9779-ace8f162c31b@huawei.com> Date: Sat, 22 Feb 2025 10:37:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH -next v2] uprobes: fix two zero old_folio bugs in __replace_page() To: Oleg Nesterov CC: David Hildenbrand , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Peter Xu , Ian Rogers , Adrian Hunter , "Liang, Kan" , Masami Hiramatsu , , , , , , , Guohanjun References: <20250221015056.1269344-1-tongtiangen@huawei.com> <20250221152841.GA24705@redhat.com> From: Tong Tiangen In-Reply-To: <20250221152841.GA24705@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemk500005.china.huawei.com (7.202.194.90) X-Rspam-User: X-Rspamd-Queue-Id: CC4121C0006 X-Rspamd-Server: rspam12 X-Stat-Signature: 664dqqgamurqwkhaoqmab47yq7yy4thm X-HE-Tag: 1740191837-380352 X-HE-Meta: U2FsdGVkX1+CTLWzxpXRdmG1leQZBcGpKhC4rNo6cVFFfEImaH+HZRUsL3AR79MqTsclnqOG7j+ISzfUrqaGYwuplbBrJEP/Vh0Qt1dYRbvQbFShtMhR+5Gt1IEYanCRt33lCIC+ApDpeBLzUCO5vQZktbrx1xQ9Y9srLKeBQW5WdVmJmVQTZE5lQQLxzjCXL4aHPj1um/P0C6RblGlBW5bh4IYBSCYhqKIYx/opQL3e7kKANcKcNOd0tSkxWsFrEuONm+tNGlWu2HTJEc+Etmg8mUvZ+jAsyXahjkj7BppyaIoleBuA7hvq2598WNz/hvi3f8AEqpqq9252rbuaHCH72ABPWM8yR0BsRr26/Apc9yb7g7O+lgSlByx7V5MRvShZ3LvJGxOEpRQzlkdtj8k0IG9pR20AdBXZVT478/Qq7X85C0i3TF71rMbx7fWhX1HVbaeCWEfkR8VF1Cqi2pvMi3GUZrHd5fivDu2AdUmkEdQxkntv45qKIK6HC5ye5bVitNk9EqHU/oalmgMi6J6jfvsXNANvyJVnUmwdORY4frpiaq8ncYxEkVhAzLzk1BbN6x3L+JSYAVi466b7nGx8Js/k/DJsCNCUQbB0vWkA+Hps1RPHLZAlvS3b9ksfzWUsccKozJmKS+BTNjH5bI2HCTCuM8muvpNKX0PVQ1q+xRlCwXH9NoQhJvO57CE7iiFmVtHdKtHOvST2qNC9GThZ5cU+C0Z4qikZkkd+CgLTvAnzErpCEARBOj18+x2ksN3/9AJKtCU+y99/yPJ3ypwQR6Ms2c9fNm0l+xqBNgagziYHCWKKtzv59xjGyTLmfmDDkQJ7aQ86V9QUUHjS0/MQZ/XnOTE+JbimlGDucsV0Fcy3grdSnk8LK93Un9Lz1/tkUI5AqLShED9RqOkkpLNDEHp7whxjbcb6rjn3iy45f7pZev2tc8ZKFn69Tl3OHbdawkEa3CgeB26srPA 5szhu9SL 7p5GY1cOqzgXZ4OmJXOkzT59DEGb1CGWSwPtnUkYZW8JMWZVIwGjvK2NLYlU+oLiqEjoul4oLmQQX1DntrRy2kpdXchw+Tzm1KvzWBPodFS/4AmpFNlXSBY5id4hESqSJ/mkoTZF/L6SDQJLab6kgSQVsNtHM/AzaRuA6J7de+RwjPCkNb4bdCb6IJr4SWeo5I9+feBskfUMpiww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/21 23:28, Oleg Nesterov 写道: > On 02/21, Tong Tiangen wrote: >> >> --- a/kernel/events/uprobes.c >> +++ b/kernel/events/uprobes.c >> @@ -506,6 +506,11 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, >> if (ret <= 0) >> goto put_old; >> >> + if (is_zero_page(old_page)) { >> + ret = -EINVAL; >> + goto put_old; >> + } > > I agree with David, the subject looks a bit misleading. > > And. I won't insist, this is cosmetic, but if you send V2 please consider > moving the "verify_opcode()" check down, after the is_zero_page/PageCompound > checks. > > Oleg. OK, check the validity of the old page first and modify the subject in v3 . Thanks. > > > .