From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0030C87FC5 for ; Mon, 21 Jul 2025 09:30:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F3056B008A; Mon, 21 Jul 2025 05:30:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A43C6B008C; Mon, 21 Jul 2025 05:30:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26BD06B0093; Mon, 21 Jul 2025 05:30:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 122176B008A for ; Mon, 21 Jul 2025 05:30:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A93CD12FBDD for ; Mon, 21 Jul 2025 09:30:01 +0000 (UTC) X-FDA: 83687750202.02.61DF252 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 0A44C100004 for ; Mon, 21 Jul 2025 09:29:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RbuD7STP; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753090199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Pn1yAqxru75n2B+pGzMkeK12aWvdk+5Ea56o0G1d/s=; b=DASNJG0yKCXWchVLZQkfbCw8HTlug4xhcRLE3kGNqJj2nWp3mHQX4RtThr00ue3Tx53NRg u6cxyZe/ZVs+D6BI+DjuRJKOOWoZT2L4LWB5p15t3lazZ33h6ddd7IGZrKzdkw2rPTsokH JKA1cdTJdjkry0NyThSeVVDEfbo2FqY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753090199; a=rsa-sha256; cv=none; b=UGrKYxirmhbuXIaq5MOeooFnyDcEIArgqhzubxp2I0KWkaggpkXIWUzuzdPcn/QgdHdZ9X 3xkRtPJ2XS2Ol8xU1hnIkPtMqdUiR7/aOhMxRqoN6dPOMKpXZ3xu39bXXJ638aww96wUIr hPieFIeG3Rp7bTlrjLgYdGY8m0+CjeA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RbuD7STP; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753090198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8Pn1yAqxru75n2B+pGzMkeK12aWvdk+5Ea56o0G1d/s=; b=RbuD7STPdyOQQflJISYiOo1DqNGDjest515QCIH2HlFaim3VmVqxJc9pfIxGpFAwc68wWG axMuwek3AdJ5vrFnBF3dJMDdtl555l94y4PcdDOQaOtaKts0Uv/8zYF1XbHn4ErtXGyAuW v8efO2nhryOvFk+9cEjFFxO9/4WF9AU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-CLmQ4ceqOsSCDEx7kMMaqg-1; Mon, 21 Jul 2025 05:29:56 -0400 X-MC-Unique: CLmQ4ceqOsSCDEx7kMMaqg-1 X-Mimecast-MFC-AGG-ID: CLmQ4ceqOsSCDEx7kMMaqg_1753090195 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4563f15f226so6114035e9.1 for ; Mon, 21 Jul 2025 02:29:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753090195; x=1753694995; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8Pn1yAqxru75n2B+pGzMkeK12aWvdk+5Ea56o0G1d/s=; b=pa/LX9xu0CJIJ2AVgxrKfmSQWvwfyZ6JPXLXOLJXUvBd8lKk1l0SH2seYK95vZf5Jx VpiScOxI/iDsGMR6YgMZ7Fj5N2MXyVQuQCXhf8FfLuA0MoC/4Hz88qyXZ+LqwTQ+Idqq trkjXcDU6LS5xXO5T3tEu/mnppl7hnkxup0HbIFLubsMhtPxuBwJvg8qMFywAN+8ikcg W1F4V6/rjOzh4Hy7EHWX7TPMjbhgqmLH2oJ0PqCCJn9rZJTiggNc+d7ppr1ccCTNQjwQ sLHgdRParNuGI2jfykPyQ8edHVBWw6TiaZ+QRIXqMTrcpzMdB1Nkfz63jrPpPotpoUAF DjlQ== X-Gm-Message-State: AOJu0YzQDRhHikbzkR55ob2+xRbNREtWbT7Q3AVJ6E+O0KH0CdTQZM6U QBsoq2vrHq84kBXKhb1PcHwRU7qfBKv9Yt+kKuKek2g6bvKQYCfJRQQ6LOFl7LdpObIlyeHNfNp xc/rETnJH/QpRpuyZyFeCbnKrphITQ00YiJV+3nUINiaO1zvxqOZP X-Gm-Gg: ASbGnct+SHidBBJykVf3ylLps2HoQXub0vJlsWlNxorQz7Ql3Fg0CN/ikNwbmSRByIj unUMKZGZsEpN+WK4cUA+6t5D0sGOTj/yxPVUwIqWfxvR2pYNGLYRd5Cd7c7vhzKgMh7LmyR52Wm hfg74TdoSOyDQYvGxZ1C8bE5L8xoILMbmM4YPAwvmeO8if64jHSxq5DsGI2/4OOO54hKJplUuKm 6lEgvNIBln9fBjFoeUkWqfOmbGUTZXHYTjWajpgvEV0eiLwRJy5sPFtyIXv+5wCYwl5wlGzuKxD KvyXAgadPcXmikTZSQbLzJ5ZkBdk7+co9xoGYZN7GhWPSLXKfEEusia6Sf/PsP4/dRSEdGk5CJb hlx/FAHOfQY4SlQRUHCppvp8nXL+LcIs9VyL/sNXwq+u3I6Wnlj3vmOfCOG2bfCqu X-Received: by 2002:a05:600c:19c8:b0:456:1b6f:c888 with SMTP id 5b1f17b1804b1-4563b8f607bmr94041555e9.23.1753090195002; Mon, 21 Jul 2025 02:29:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFtib9Sc8VkzIB3iSms0G9AepPe//Ku1AQIxINAeaa7HLHOkM8yabiEiyuYqe6QgtK4IGzanQ== X-Received: by 2002:a05:600c:19c8:b0:456:1b6f:c888 with SMTP id 5b1f17b1804b1-4563b8f607bmr94041275e9.23.1753090194425; Mon, 21 Jul 2025 02:29:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4c:df00:a9f5:b75b:33c:a17f? (p200300d82f4cdf00a9f5b75b033ca17f.dip0.t-ipconnect.de. [2003:d8:2f4c:df00:a9f5:b75b:33c:a17f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4563b7404f3sm96716165e9.23.2025.07.21.02.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jul 2025 02:29:53 -0700 (PDT) Message-ID: <46a22e7c-51f0-4fd0-8583-447c5e366029@redhat.com> Date: Mon, 21 Jul 2025 11:29:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] smaps: fix BUG_ON in smaps_hugetlb_range To: Jinjiang Tu , akpm@linux-foundation.org, catalin.marinas@arm.com, lorenzo.stoakes@oracle.com, thiago.bauermann@linaro.org, superman.xpt@gmail.com, christophe.leroy@csgroup.eu, brahmajit.xyz@gmail.com, andrii@kernel.org, avagin@gmail.com, baolin.wang@linux.alibaba.com, ryan.roberts@arm.com, hughd@google.com, rientjes@google.com, mhocko@suse.com, joern@logfs.org Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250721081444.277183-1-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250721081444.277183-1-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AN-o4ZkFL_4_i3yRdi29NRfoNcN_h_ivod6DEHk0v3o_1753090195 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: tzkb476xunjhfoahbwqq564whdrn9nuu X-Rspamd-Queue-Id: 0A44C100004 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1753090198-605955 X-HE-Meta: U2FsdGVkX18NeAuR3MyFE2jeCWtJ0j09sYM93TnCO6NsHwnJQK4w3aPf0iyeiZXrMcXFZpj4TdzeoprF+u56BHSxcvliU/JAnYTPN/qSqpp3n5KMFendy9D6tBQSovkpkvubSS5v+6mOBu12fP/Ks1rimbjf1pu+oHChiESszW6OlC7a4g5wLZMLOjVLMluYRoA+L9AfBOJJzqaCpF4igSzrQQio8mE6DGdaTFYYCcBhsbLUULpefXRS+RJ0p80mYOwQsQMAf7Cajhbk0ELXMaMIhgt5CGsTtMzQAYc3j0LOW8ZG6bZ8BU1LL2aYxxyC7o/Fiex2EANW/Iz/m9CV9iNZ4Y0WsytI/y4P5an8flNQR+uClwzmze2sEuAucfnkre7yExmkrzCOwiHnQsD7jvLcfQL/WKSpzGRAMD2OjzDYNwgb8WTNPFFOSVwa9+hp0a3OiNCLok7CyPMxnnFQnc81XWA+45QldrWouWEfqBtwm/Mer/pwAKmXEZDjIycQuO9X3xF0yZMd7X5AWIz5beonNUXMhCkJixr5mO03T7mwKhrlnND/nCgPiqwXiybbXp/69pUy9T0TYADUKVuOvFM9PRWkjXAHwuLviMBK8t0gbSzMqNK+4Nu66oGW6sDZkJz4kg8Ip1SwWRDRXV6X1FVq9Hm0y5Np6soeazBPt9fzGc0M65PMV0+n81LvPPXwVpkzs6yjw2znflrjzZeKDsRq2HKEWEGHxMCa+f3QAVcG/8z5EAfC6kKF7ZrZoVNYdQ0U7ig7TnWEpyeJM7d+jVdhLFkri10VoFQxKZrsXG2qTYuxbMRCOrT42PeUeIqe1Dp3N9ovA8YjpZ6TETkP/s25RYLnKMqPOm3Tv6OMe8HtnGzIyod2A+1G3xU0c6JVf8RNwVmoopSUN3x7zvBaZocqOABGBYJlA5AnyzE8QtfmQLjBcOjWcQ6xZsJXrNkI3fPwlsZRS3/0apDMeHE snTChKTP isvkEwtYbpSb+xtzrahc9OkS8ADui45c3gett6ZyKyvEGlFymcVMG8LWzVCcFcnO1Z9tqbQbbEanXC4WpHmAz9T9kImnhMzMxXp+ZLNrb1B96qUtP86aPyHMYV4JRTg1OA+bGzeWnOKU3IWX3T2HovpHhudGqStH9GIN53W3XH8lcfJdYTETH0tNybqB76zONFtCzCgWrioZXf2UUOCtT5vsf0NLSk1Nh27cqV4xWJKE7DLP6p++zl9IfyTffcBHEhouq2/HyYxgbYtQsF2z1SYpL7OunWJ9HcO/tPdbKnoGHlHvrfELlrlPwhIjGEsZDp2A7EGdMHSzHotTnwmXBrdKpqxIUNlNte2YNOsU/0cgqAoSpnrWCKPFBfYLVamBhpiCCx4JdXJcW9Fxq7kUP8JGZDA3kP9T8X45Efem5IPPBVYIo2QTZgiZBCrj39lRRWGOFwWGTChu7W2mzeWc36qWcXa6L4LODJLL8h8TFUwPa+q6WHjgRcD3wo5hVY6/XC+vovLG4dOq8XZrOf6FmkHEh3GwAd4mhfxYH6KnZMlpap3TLasfzvYV9FQQZxPz53mc3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.07.25 10:14, Jinjiang Tu wrote: > smaps_hugetlb_range() handles the pte without holdling ptl, and may be > concurrenct with migration, leaing to BUG_ON in pfn_swap_entry_to_page(). > The race is as follows. > > smaps_hugetlb_range migrate_pages > huge_ptep_get > remove_migration_ptes > folio_unlock > pfn_swap_entry_folio > BUG_ON > > To fix it, hold ptl lock in smaps_hugetlb_range(). > > Fixes: 25ee01a2fca0 ("mm: hugetlb: proc: add hugetlb-related fields to /proc/PID/smaps") > Signed-off-by: Jinjiang Tu > --- > fs/proc/task_mmu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 751479eb128f..0102ab3aaec1 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1020,10 +1020,13 @@ static int smaps_hugetlb_range(pte_t *pte, unsigned long hmask, > { > struct mem_size_stats *mss = walk->private; > struct vm_area_struct *vma = walk->vma; > - pte_t ptent = huge_ptep_get(walk->mm, addr, pte); > struct folio *folio = NULL; > bool present = false; > + spinlock_t *ptl; > + pte_t ptent; > > + ptl = huge_pte_lock(hstate_vma(vma), walk->mm, pte); > + ptent = huge_ptep_get(walk->mm, addr, pte); > if (pte_present(ptent)) { > folio = page_folio(pte_page(ptent)); > present = true; > @@ -1042,6 +1045,7 @@ static int smaps_hugetlb_range(pte_t *pte, unsigned long hmask, > else > mss->private_hugetlb += huge_page_size(hstate_vma(vma)); > } > + spin_unlock(ptl); > return 0; > } > #else Heh, I stumbled over that code many times and wondered "why don't we need the PTL here -- I'm sure it's fine because otherwise we would be getting reports.". In pagewalk code we only hold the vma lock -- see walk_hugetlb_range(). So I think we should just grab the PTL in all these walkers. What about pagemap_hugetlb_range, pagemap_scan_hugetlb_entry, gather_hugetlb_stats? I think we should not make exceptions here and just handle it like we would have handled ordinary PTEs/PMDs. -- Cheers, David / dhildenb