From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.18.234]) by e23smtp06.au.ibm.com (8.13.1/8.13.1) with ESMTP id l8Q8JoIk008965 for ; Wed, 26 Sep 2007 18:19:50 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l8Q8JoDS3211406 for ; Wed, 26 Sep 2007 18:19:50 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l8Q8IKrc029773 for ; Wed, 26 Sep 2007 18:18:21 +1000 Message-ID: <46FA1604.3040808@linux.vnet.ibm.com> Date: Wed, 26 Sep 2007 13:49:16 +0530 From: Kamalesh Babulal MIME-Version: 1.0 Subject: Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure References: <20070925014625.3cd5f896.akpm@linux-foundation.org> <46F968C2.7080900@linux.vnet.ibm.com> <20070926103205.c72a8e8a.kamezawa.hiroyu@jp.fujitsu.com> <20070926104854.7cc09d13.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20070926104854.7cc09d13.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andy Whitcroft , Balbir Singh , Badari Pulavarty List-ID: KAMEZAWA Hiroyuki wrote: > On Wed, 26 Sep 2007 10:32:05 +0900 > KAMEZAWA Hiroyuki wrote: >> Maybe my patch is the problem. could you give me your .config ? >> > Ah, memory hot remove is selectable even if the arch doesn't support it....sorry. > > ok, this is fix. > > Thanks, > -Kame > == > MEMORY_HOTREMOVE config option is selectable even it arch doesn't support it. > This fix it. > > Signed-off-by: KAMEZAWA Hiroyuki > > > Index: linux-2.6.23-rc8-mm1/arch/ia64/Kconfig > =================================================================== > --- linux-2.6.23-rc8-mm1.orig/arch/ia64/Kconfig > +++ linux-2.6.23-rc8-mm1/arch/ia64/Kconfig > @@ -305,6 +305,9 @@ config HOTPLUG_CPU > config ARCH_ENABLE_MEMORY_HOTPLUG > def_bool y > > +config ARCH_ENABLE_MEMORY_HOTREMOVE > + def_bool y > + > config SCHED_SMT > bool "SMT scheduler support" > depends on SMP > Index: linux-2.6.23-rc8-mm1/mm/Kconfig > =================================================================== > --- linux-2.6.23-rc8-mm1.orig/mm/Kconfig > +++ linux-2.6.23-rc8-mm1/mm/Kconfig > @@ -141,7 +141,7 @@ config MEMORY_HOTPLUG_SPARSE > > config MEMORY_HOTREMOVE > bool "Allow for memory hot remove" > - depends on MEMORY_HOTPLUG > + depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE > depends on MIGRATION > > # Heavily threaded applications may benefit from splitting the mm-wide > > - Hi Kame, Thanks, your patch fixes the problem. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org