Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure

[Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>]

KAMEZAWA Hiroyuki wrote:
> On Wed, 26 Sep 2007 10:32:05 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> Maybe my patch is the problem. could you give me your .config ?
>>
> Ah, memory hot remove is selectable even if the arch doesn't support it....sorry.
> 
> ok, this is fix.
> 
> Thanks,
> -Kame
> ==
> MEMORY_HOTREMOVE config option is selectable even it arch doesn't support it.
> This fix it.
> 
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> 
> 
> Index: linux-2.6.23-rc8-mm1/arch/ia64/Kconfig
> ===================================================================
> --- linux-2.6.23-rc8-mm1.orig/arch/ia64/Kconfig
> +++ linux-2.6.23-rc8-mm1/arch/ia64/Kconfig
> @@ -305,6 +305,9 @@ config HOTPLUG_CPU
>  config ARCH_ENABLE_MEMORY_HOTPLUG
>  	def_bool y
> 
> +config ARCH_ENABLE_MEMORY_HOTREMOVE
> +	def_bool y
> +
>  config SCHED_SMT
>  	bool "SMT scheduler support"
>  	depends on SMP
> Index: linux-2.6.23-rc8-mm1/mm/Kconfig
> ===================================================================
> --- linux-2.6.23-rc8-mm1.orig/mm/Kconfig
> +++ linux-2.6.23-rc8-mm1/mm/Kconfig
> @@ -141,7 +141,7 @@ config MEMORY_HOTPLUG_SPARSE
> 
>  config MEMORY_HOTREMOVE
>  	bool "Allow for memory hot remove"
> -	depends on MEMORY_HOTPLUG
> +	depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE
>  	depends on MIGRATION
> 
>  # Heavily threaded applications may benefit from splitting the mm-wide
> 
> -
Hi Kame,

Thanks, your patch fixes the problem.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>