* Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure [not found] <20070925014625.3cd5f896.akpm@linux-foundation.org> @ 2007-09-25 20:00 ` Kamalesh Babulal 2007-09-25 22:01 ` Badari Pulavarty 2007-09-26 1:32 ` KAMEZAWA Hiroyuki 0 siblings, 2 replies; 6+ messages in thread From: Kamalesh Babulal @ 2007-09-25 20:00 UTC (permalink / raw) To: Andrew Morton Cc: linux-kernel, linux-mm, kamezawa.hiroyu, Andy Whitcroft, Balbir Singh Hi Andrew, The 2.6.23-rc8-mm1 kernel linking fails on the powerpc (P5+) box CC init/version.o LD init/built-in.o LD .tmp_vmlinux1 drivers/built-in.o: In function `memory_block_action': /root/scrap/linux-2.6.23-rc8/drivers/base/memory.c:188: undefined reference to `.remove_memory' make: *** [.tmp_vmlinux1] Error 1 # gcc -v Using built-in specs. Target: powerpc64-suse-linux Configured with: ../configure --enable-threads=posix --prefix=/usr --with-local-prefix=/usr/local --infodir=/usr/share/info --mandir=/usr/share/man --libdir=/usr/lib --libexecdir=/usr/lib --enable-languages=c,c++,objc,fortran,obj-c++,java,ada --enable-checking=release --with-gxx-include-dir=/usr/include/c++/4.1.2 --enable-ssp --disable-libssp --disable-libgcj --with-slibdir=/lib --with-system-zlib --enable-shared --enable-__cxa_atexit --enable-libstdcxx-allocator=new --program-suffix=-4.1 --enable-version-specific-runtime-libs --without-system-libunwind --with-cpu=default32 --enable-secureplt --with-long-double-128 --host=powerpc64-suse-linux Thread model: posix gcc version 4.1.2 20061115 (prerelease) (SUSE Linux) # ld -v GNU ld version 2.17.50.0.5 20060927 (SUSE Linux) -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure 2007-09-25 20:00 ` 2.6.23-rc8-mm1 - powerpc memory hotplug link failure Kamalesh Babulal @ 2007-09-25 22:01 ` Badari Pulavarty 2007-09-26 8:18 ` Kamalesh Babulal 2007-09-26 1:32 ` KAMEZAWA Hiroyuki 1 sibling, 1 reply; 6+ messages in thread From: Badari Pulavarty @ 2007-09-25 22:01 UTC (permalink / raw) To: Kamalesh Babulal Cc: Andrew Morton, lkml, linux-mm, kamezawa.hiroyu, Andy Whitcroft, Balbir Singh On Wed, 2007-09-26 at 01:30 +0530, Kamalesh Babulal wrote: > Hi Andrew, > > The 2.6.23-rc8-mm1 kernel linking fails on the powerpc (P5+) box > > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > drivers/built-in.o: In function `memory_block_action': > /root/scrap/linux-2.6.23-rc8/drivers/base/memory.c:188: undefined reference to `.remove_memory' > make: *** [.tmp_vmlinux1] Error 1 > I ran into the same thing earlier. Here is the fix I made. Thanks, Badari Memory hotplug remove is currently supported only on IA64 Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com> Index: linux-2.6.23-rc8/mm/Kconfig =================================================================== --- linux-2.6.23-rc8.orig/mm/Kconfig 2007-09-25 14:44:03.000000000 -0700 +++ linux-2.6.23-rc8/mm/Kconfig 2007-09-25 14:44:48.000000000 -0700 @@ -143,6 +143,7 @@ config MEMORY_HOTREMOVE bool "Allow for memory hot remove" depends on MEMORY_HOTPLUG depends on MIGRATION + depends on (IA64) # Heavily threaded applications may benefit from splitting the mm-wide # page_table_lock, so that faults on different parts of the user address -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure 2007-09-25 22:01 ` Badari Pulavarty @ 2007-09-26 8:18 ` Kamalesh Babulal 0 siblings, 0 replies; 6+ messages in thread From: Kamalesh Babulal @ 2007-09-26 8:18 UTC (permalink / raw) To: Badari Pulavarty Cc: Andrew Morton, lkml, linux-mm, kamezawa.hiroyu, Andy Whitcroft, Balbir Singh Badari Pulavarty wrote: > On Wed, 2007-09-26 at 01:30 +0530, Kamalesh Babulal wrote: >> Hi Andrew, >> >> The 2.6.23-rc8-mm1 kernel linking fails on the powerpc (P5+) box >> >> CC init/version.o >> LD init/built-in.o >> LD .tmp_vmlinux1 >> drivers/built-in.o: In function `memory_block_action': >> /root/scrap/linux-2.6.23-rc8/drivers/base/memory.c:188: undefined reference to `.remove_memory' >> make: *** [.tmp_vmlinux1] Error 1 >> > > I ran into the same thing earlier. Here is the fix I made. > > Thanks, > Badari > > Memory hotplug remove is currently supported only on IA64 > > Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com> > > Index: linux-2.6.23-rc8/mm/Kconfig > =================================================================== > --- linux-2.6.23-rc8.orig/mm/Kconfig 2007-09-25 14:44:03.000000000 -0700 > +++ linux-2.6.23-rc8/mm/Kconfig 2007-09-25 14:44:48.000000000 -0700 > @@ -143,6 +143,7 @@ config MEMORY_HOTREMOVE > bool "Allow for memory hot remove" > depends on MEMORY_HOTPLUG > depends on MIGRATION > + depends on (IA64) > > # Heavily threaded applications may benefit from splitting the mm-wide > # page_table_lock, so that faults on different parts of the user address > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ Hi Badari, Thanks, your patch fixed the problem. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure 2007-09-25 20:00 ` 2.6.23-rc8-mm1 - powerpc memory hotplug link failure Kamalesh Babulal 2007-09-25 22:01 ` Badari Pulavarty @ 2007-09-26 1:32 ` KAMEZAWA Hiroyuki 2007-09-26 1:48 ` KAMEZAWA Hiroyuki 1 sibling, 1 reply; 6+ messages in thread From: KAMEZAWA Hiroyuki @ 2007-09-26 1:32 UTC (permalink / raw) To: Kamalesh Babulal Cc: Andrew Morton, linux-kernel, linux-mm, Andy Whitcroft, Balbir Singh On Wed, 26 Sep 2007 01:30:02 +0530 Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote: > Hi Andrew, > > The 2.6.23-rc8-mm1 kernel linking fails on the powerpc (P5+) box > > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > drivers/built-in.o: In function `memory_block_action': > /root/scrap/linux-2.6.23-rc8/drivers/base/memory.c:188: undefined reference to `.remove_memory' > make: *** [.tmp_vmlinux1] Error 1 > Maybe my patch is the problem. could you give me your .config ? Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure 2007-09-26 1:32 ` KAMEZAWA Hiroyuki @ 2007-09-26 1:48 ` KAMEZAWA Hiroyuki 2007-09-26 8:19 ` Kamalesh Babulal 0 siblings, 1 reply; 6+ messages in thread From: KAMEZAWA Hiroyuki @ 2007-09-26 1:48 UTC (permalink / raw) To: KAMEZAWA Hiroyuki Cc: Kamalesh Babulal, Andrew Morton, linux-kernel, linux-mm, Andy Whitcroft, Balbir Singh, Badari Pulavarty On Wed, 26 Sep 2007 10:32:05 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > Maybe my patch is the problem. could you give me your .config ? > Ah, memory hot remove is selectable even if the arch doesn't support it....sorry. ok, this is fix. Thanks, -Kame == MEMORY_HOTREMOVE config option is selectable even it arch doesn't support it. This fix it. Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Index: linux-2.6.23-rc8-mm1/arch/ia64/Kconfig =================================================================== --- linux-2.6.23-rc8-mm1.orig/arch/ia64/Kconfig +++ linux-2.6.23-rc8-mm1/arch/ia64/Kconfig @@ -305,6 +305,9 @@ config HOTPLUG_CPU config ARCH_ENABLE_MEMORY_HOTPLUG def_bool y +config ARCH_ENABLE_MEMORY_HOTREMOVE + def_bool y + config SCHED_SMT bool "SMT scheduler support" depends on SMP Index: linux-2.6.23-rc8-mm1/mm/Kconfig =================================================================== --- linux-2.6.23-rc8-mm1.orig/mm/Kconfig +++ linux-2.6.23-rc8-mm1/mm/Kconfig @@ -141,7 +141,7 @@ config MEMORY_HOTPLUG_SPARSE config MEMORY_HOTREMOVE bool "Allow for memory hot remove" - depends on MEMORY_HOTPLUG + depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE depends on MIGRATION # Heavily threaded applications may benefit from splitting the mm-wide -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure 2007-09-26 1:48 ` KAMEZAWA Hiroyuki @ 2007-09-26 8:19 ` Kamalesh Babulal 0 siblings, 0 replies; 6+ messages in thread From: Kamalesh Babulal @ 2007-09-26 8:19 UTC (permalink / raw) To: KAMEZAWA Hiroyuki Cc: Andrew Morton, linux-kernel, linux-mm, Andy Whitcroft, Balbir Singh, Badari Pulavarty KAMEZAWA Hiroyuki wrote: > On Wed, 26 Sep 2007 10:32:05 +0900 > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: >> Maybe my patch is the problem. could you give me your .config ? >> > Ah, memory hot remove is selectable even if the arch doesn't support it....sorry. > > ok, this is fix. > > Thanks, > -Kame > == > MEMORY_HOTREMOVE config option is selectable even it arch doesn't support it. > This fix it. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > > Index: linux-2.6.23-rc8-mm1/arch/ia64/Kconfig > =================================================================== > --- linux-2.6.23-rc8-mm1.orig/arch/ia64/Kconfig > +++ linux-2.6.23-rc8-mm1/arch/ia64/Kconfig > @@ -305,6 +305,9 @@ config HOTPLUG_CPU > config ARCH_ENABLE_MEMORY_HOTPLUG > def_bool y > > +config ARCH_ENABLE_MEMORY_HOTREMOVE > + def_bool y > + > config SCHED_SMT > bool "SMT scheduler support" > depends on SMP > Index: linux-2.6.23-rc8-mm1/mm/Kconfig > =================================================================== > --- linux-2.6.23-rc8-mm1.orig/mm/Kconfig > +++ linux-2.6.23-rc8-mm1/mm/Kconfig > @@ -141,7 +141,7 @@ config MEMORY_HOTPLUG_SPARSE > > config MEMORY_HOTREMOVE > bool "Allow for memory hot remove" > - depends on MEMORY_HOTPLUG > + depends on MEMORY_HOTPLUG && ARCH_ENABLE_MEMORY_HOTREMOVE > depends on MIGRATION > > # Heavily threaded applications may benefit from splitting the mm-wide > > - Hi Kame, Thanks, your patch fixes the problem. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-09-26 8:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20070925014625.3cd5f896.akpm@linux-foundation.org>
2007-09-25 20:00 ` 2.6.23-rc8-mm1 - powerpc memory hotplug link failure Kamalesh Babulal
2007-09-25 22:01 ` Badari Pulavarty
2007-09-26 8:18 ` Kamalesh Babulal
2007-09-26 1:32 ` KAMEZAWA Hiroyuki
2007-09-26 1:48 ` KAMEZAWA Hiroyuki
2007-09-26 8:19 ` Kamalesh Babulal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox