Re: [PATCH 3/4] hugetlb: Try to grow hugetlb pool for MAP_SHARED mappings

["Mika Penttilä" <mika.penttila@kolumbus.fi>]

> +void return_unused_surplus_pages(void)
> +{
> +	static int nid = -1;
> +	int delta;
> +	struct page *page;
> +
> +	delta = unused_surplus_pages - resv_huge_pages;
> +
> +	while (delta) {
>   
Shouldn't this be while (delta >= 0) ?
> +		nid = next_node(nid, node_online_map);
> +		if (nid == MAX_NUMNODES)
> +			nid = first_node(node_online_map);
> +
> +		if (!surplus_huge_pages_node[nid])
> +			continue;
> +
> +		if (!list_empty(&hugepage_freelists[nid])) {
> +			page = list_entry(hugepage_freelists[nid].next,
> +					  struct page, lru);
> +			list_del(&page->lru);
> +			update_and_free_page(page);
> +			free_huge_pages--;
> +			free_huge_pages_node[nid]--;
> +			surplus_huge_pages_node[nid]--;
> +			unused_surplus_pages--;
> +			delta--;
> +		}
> +	}
> +}
> +

--Mika

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>