Re: 2.6.23-rc4-mm1 memory controller BUG_ON()

[Balbir Singh <balbir@linux.vnet.ibm.com>]

Dave Hansen wrote:
> On Thu, 2007-09-13 at 12:34 -0700, Dave Hansen wrote:
>> Looks like somebody is holding a lock while trying to do a
>> mem_container_charge(), and the mem_container_charge() call is doing an
>> allocation.  Naughty.
>>
>> I'm digging into it a bit more, but thought I'd report it, first.
>>
>> .config: http://sr71.net/~dave/linux/memory-controller-bug.config
> 
> I'm now thinking this is because the add_to_page_cache() functions have
> a gfp_mask passed in, and the mem_container_charge() functions don't
> take that mask.  So, even if the add_to_page_cache() user specified !
> __GFP_WAIT, the mem_container_charge() function can sleep on its
> kmalloc.
> 
> I'll try passing gfp_flags through to it and see what happens.
> 

Please see my patch at

http://lkml.org/lkml/2007/9/12/113 and some more details as a reply
to your earlier email.


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>