From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33347C54ED0 for ; Fri, 23 May 2025 06:55:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EE726B00A5; Fri, 23 May 2025 02:55:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49EB36B00CB; Fri, 23 May 2025 02:55:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38E0E6B00CC; Fri, 23 May 2025 02:55:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1A5DE6B00A5 for ; Fri, 23 May 2025 02:55:46 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 523DC5FD9B for ; Fri, 23 May 2025 06:55:45 +0000 (UTC) X-FDA: 83473262250.07.6008BC7 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf25.hostedemail.com (Postfix) with ESMTP id 292F9A0013 for ; Fri, 23 May 2025 06:55:41 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=a10Ip6lB; spf=pass (imf25.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747983343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kEIfINKZejvJZsMGvS6UgezRdxkkGcgt66QsjivJra8=; b=ZT02TLUSP8Qn6O6/diXJBkwnEoKWoXPYqAr2fa6qiq89u4kLT25LiFezIHz6MFnN8soo8y GhMc2RNk3CVMnE8EEsWZbjNFZx6B3mKQp+Be37WwvH2FT968aOjcR0ZYDV8J9TGkivW2eH 4kojZ1GLK7wQzRAx5+7julNkiTi63VQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=a10Ip6lB; spf=pass (imf25.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747983343; a=rsa-sha256; cv=none; b=aIUO3h4ea9HRmEVCRvpgXcVGU4uqzYoh13is9hKg8SAPPViL0DqroQsqaFMmJ+taG0FqHC fZxBSTyMlfLOk7GLuSc8au/MBWnNMWFLqrFLS6BKOOvPIpSmTHwNpLMyLat7UqA/6Ja8VI Zn6pd1JeAnjN3vwzghFtlkfnO7YRC+A= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1747983338; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=kEIfINKZejvJZsMGvS6UgezRdxkkGcgt66QsjivJra8=; b=a10Ip6lB0UCRn0osNUFcGljqTHg7DLfernOog4ui66UdZ5S4kZBCPddAsUaog/Q3nQ6rtAaeIvfLUSwlXnZOZ6PHyzxcjQckBE/tTot5FfBGhleg7rcH9kfhKdrMlS5/i9YxSN2l8onaEssNh0yy+nA1giWdg3Zb43+xZiyynXQ= Received: from 30.74.144.180(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WbZKq8c_1747983335 cluster:ay36) by smtp.aliyun-inc.com; Fri, 23 May 2025 14:55:36 +0800 Message-ID: <469db7d1-ba99-4dc7-af13-b5fe850d4031@linux.alibaba.com> Date: Fri, 23 May 2025 14:55:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 03/12] khugepaged: generalize hugepage_vma_revalidate for mTHP support To: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: david@redhat.com, ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org References: <20250515032226.128900-1-npache@redhat.com> <20250515032226.128900-4-npache@redhat.com> From: Baolin Wang In-Reply-To: <20250515032226.128900-4-npache@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 292F9A0013 X-Stat-Signature: 7qm1icx59dnif5g9k8fduio3myowfcrm X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1747983341-948674 X-HE-Meta: U2FsdGVkX1//YJ6psZhdWzv/qIgPEQLTpqMhfZguDe80slNHGpfD7NJJbtfVuNpYqYP82ya/A15HdRBLkFuhAeLzzZ8pFq+f+XiB85tiTwaK0v7tpyjSzmdoXlYFTjzNa4IgyKyeUI3mcVZiYv/CiCXrRtQe2QURi96U6a9J9OvQZaH5r1D7kg3KwWB0v5Yq1QiZdOhd7alKomobesAOHEgUqn6r7mQriK0epF8KjguqcTWLugzEdAKGLdWBvpMZ72LqigyZ3ngkdUm+SiR9EbRZowSrDjS8jsSkaOEc0ntP08u5kuGFYrl3mXU9XUufRBcQM5VBanhJMidwVCF6gtBlcxFcloFg+A6MWYVO+FpD6fLojOvTjZl3WKh1fAj5yLuWc7tjCV2v7eJicMMDCE+fai6M100xuDrpQM1wD8MIO4C9h0Eoc1t8IddXc5yUmNQi0V4D/XuhsFXoQS+e6LDjE9sMlXqeomIHuB3LM1O/35RxYJV3YzCAJkvO5DM/MxDlHzXc7uWB0V/CMFsVbXDcsY+KMvc81fBdfgj3HiShT3m7ZCWEzMmO7y79/BFI0wU2dhDdeYL7+oy/gRXCtZT2ZDQPhu4gMrJ7lyXP9Kzg+JN5WrkmzngA57/K8r1YZOfwv0z/T8vqg24hOG3dIdixNRaFTw7G8/jySxtuztk89wd2DXZKhJkbcwrRODDoYgoIZI84VM9ZheEpwIuUdTKBbW/ZQlBLzaiG3nYD7MqhzzDSHtmioJVk2mSmskKkFBBPK++Dn9JE13e3tRxOB0Z/27a17WuCtP3qTiyAyPcWdcmXl3VWasiOKZvG3hl/SKeLgYZS24lE1yhpW70oZxawQ5pvIUMlINo+l3PvTHDYdwcKnxLPeSUkdAdRXQEQl9yvmRIh6p+6XaTBMoMyz4IRuOEYBLQgzttFCIqYFr/4cxMsM5Jy+ZwZfYwEolUXpZSrQcZ9TndjveVPpAY pILstFpA oif+f5+HJgCRLHts87s6WiemyLdQaCXk6B6W0Mui0ua/goS0MbjEFYFVN/FQuZenHImj7fPrSkFPeY1+txnwQAFPfhz0m4k4OIHcT75B3enbh0Ra5+mCplVpT/Zgk3dYVPa+EOnhjKHH0bJ59194mTVbVDb1cod1Iv/nCSJo/EyFGSb5RW7TOysUgRGgR64AqJn4EBgvJnq7qdFXJYhS9Nimkkk3WlTbukAns8BCWxJHXKJXskrWmGLCnBnrr2HllDbMlHq/tmKMcjEysMhwbqrJecEtOG0MA3pjKA3clC5jTZG3d7JugG4/4M/83iboYah/rmuYMz+MgHAoHYtnkZBNqAgR86ExiJsLPh9vm2kgvwnEH68BBybNNC8xQFdjUyxge29Z32Siy+ijjWgGZbu5xtzfr86fIan653y1DnzkxD8tJZXu+lSyVc8VaOAfSYDoL4XXvXDn8GNvS8aGRg0GGHQ/ZbYVe7ZIz8cEHqWbiEdpXbRRxyvEfpAshdLTxQL4Tg9mYeYUZPKE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/15 11:22, Nico Pache wrote: > For khugepaged to support different mTHP orders, we must generalize this > to check if the PMD is not shared by another VMA and the order is > enabled. > > No functional change in this patch. > > Reviewed-by: Baolin Wang > Co-developed-by: Dev Jain > Signed-off-by: Dev Jain > Signed-off-by: Nico Pache > --- > mm/khugepaged.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 5457571d505a..0c4d6a02d59c 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -920,7 +920,7 @@ static int khugepaged_find_target_node(struct collapse_control *cc) > static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > bool expect_anon, > struct vm_area_struct **vmap, > - struct collapse_control *cc) > + struct collapse_control *cc, int order) > { > struct vm_area_struct *vma; > unsigned long tva_flags = cc->is_khugepaged ? TVA_ENFORCE_SYSFS : 0; > @@ -934,7 +934,7 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > > if (!thp_vma_suitable_order(vma, address, PMD_ORDER)) Sorry, I missed this before. Should we also change 'PMD_ORDER' to 'order' for the thp_vma_suitable_order()? > return SCAN_ADDRESS_RANGE; > - if (!thp_vma_allowable_order(vma, vma->vm_flags, tva_flags, PMD_ORDER)) > + if (!thp_vma_allowable_order(vma, vma->vm_flags, tva_flags, order)) > return SCAN_VMA_CHECK; > /* > * Anon VMA expected, the address may be unmapped then > @@ -1130,7 +1130,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, > goto out_nolock; > > mmap_read_lock(mm); > - result = hugepage_vma_revalidate(mm, address, true, &vma, cc); > + result = hugepage_vma_revalidate(mm, address, true, &vma, cc, HPAGE_PMD_ORDER); > if (result != SCAN_SUCCEED) { > mmap_read_unlock(mm); > goto out_nolock; > @@ -1164,7 +1164,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, > * mmap_lock. > */ > mmap_write_lock(mm); > - result = hugepage_vma_revalidate(mm, address, true, &vma, cc); > + result = hugepage_vma_revalidate(mm, address, true, &vma, cc, HPAGE_PMD_ORDER); > if (result != SCAN_SUCCEED) > goto out_up_write; > /* check if the pmd is still valid */ > @@ -2782,7 +2782,7 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > mmap_read_lock(mm); > mmap_locked = true; > result = hugepage_vma_revalidate(mm, addr, false, &vma, > - cc); > + cc, HPAGE_PMD_ORDER); > if (result != SCAN_SUCCEED) { > last_fail = result; > goto out_nolock;