From: Ethan Solomita <solo@google.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
a.p.zijlstra@chello.nl
Subject: Re: [RFC 1/7] cpuset write dirty map
Date: Wed, 11 Jul 2007 12:18:34 -0700 [thread overview]
Message-ID: <46952D0A.1090304@google.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0706261216110.20282@schroedinger.engr.sgi.com>
throttle_vm_writeout() you added a clause that checks for __GFP_FS |
__GFP_IO and if they're not both set it calls blk_congestion_wait()
immediately and then returns, no change for looping. Two questions:
1. This seems like an unrelated bug fix. Should you submit it as a
standalone patch?
2. You put this gfp check before the check for get_dirty_limits. It's
possible that this will block even though without your change it would
have returned straight away. Would it better, instead of adding the
if-clause at the top of the function, to embed the gfp check at the end
of the for-loop after calling blk_congestion_wait?
-- Ethan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-07-11 19:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 6:03 Ethan Solomita
2007-06-01 6:10 ` [RFC 2/7] cpuset write pdflush nodemask Ethan Solomita
2007-06-01 6:11 ` [RFC 3/7] cpuset write throttle Ethan Solomita
2007-06-01 6:13 ` [RFC 4/7] cpuset write vmscan Ethan Solomita
2007-06-01 6:15 ` [RFC 5/7] cpuset write vm writeout Ethan Solomita
2007-06-01 6:16 ` [corrected][RFC " Ethan Solomita
2007-06-01 6:16 ` [RFC 6/7] cpuset write fixes Ethan Solomita
2007-06-01 6:17 ` [RFC 7/7] cpuset dirty limits Ethan Solomita
2007-06-04 18:39 ` [RFC 1/7] cpuset write dirty map Christoph Lameter
2007-06-04 19:38 ` Ethan Solomita
2007-06-04 19:52 ` Christoph Lameter
2007-06-25 20:21 ` Ethan Solomita
2007-06-26 19:16 ` Christoph Lameter
2007-06-26 22:22 ` Andrew Morton
2007-06-27 3:18 ` Christoph Lameter
2007-06-27 9:14 ` Andrew Morton
2007-06-27 12:44 ` Christoph Lameter
2007-06-27 21:10 ` Mel Gorman
2007-06-27 18:17 ` Ethan Solomita
2007-06-27 21:38 ` Christoph Lameter
2007-07-01 2:57 ` Ethan Solomita
2007-07-03 18:09 ` Christoph Lameter
2007-07-11 19:18 ` Ethan Solomita [this message]
2007-07-11 20:11 ` Christoph Lameter
2007-07-12 1:07 ` Ethan Solomita
-- strict thread matches above, loose matches on Subject: below --
2007-04-23 23:20 Ethan Solomita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46952D0A.1090304@google.com \
--to=solo@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@google.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox