From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sd0109e.au.ibm.com (d23rh905.au.ibm.com [202.81.18.225]) by ausmtp04.au.ibm.com (8.13.8/8.13.8) with ESMTP id l667S8l1244148 for ; Fri, 6 Jul 2007 17:28:10 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.250.243]) by sd0109e.au.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l6679177172510 for ; Fri, 6 Jul 2007 17:09:06 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6675Qio031924 for ; Fri, 6 Jul 2007 17:05:26 +1000 Message-ID: <468DE9A8.8000107@linux.vnet.ibm.com> Date: Fri, 06 Jul 2007 00:05:12 -0700 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com MIME-Version: 1.0 Subject: Re: [-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v2) References: <20070706052029.11677.16964.sendpatchset@balbir-laptop> <20070706052212.11677.26502.sendpatchset@balbir-laptop> In-Reply-To: <20070706052212.11677.26502.sendpatchset@balbir-laptop> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Balbir Singh Cc: Vaidyanathan Srinivasan , Andrew Morton , Pavel Emelianov , Peter Zijlstra , Linux Kernel Mailing List , Linux MM Mailing List , Eric W Biederman , Linux Containers , Paul Menage List-ID: Balbir Singh wrote: > +unsigned long mem_container_isolate_pages(unsigned long nr_to_scan, > + struct list_head *dst, > + unsigned long *scanned, int order, > + int mode, struct zone *z, > + struct mem_container *mem_cont, > + int active) [snip] > +{ > + /* > + * Check if the meta page went away from under us > + */ > + if (!list_empty(&mp->list) There is a small typo here, we need an extra brace at the end (I should have done a refpatch :( ) -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org