From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2498C5AE59 for ; Tue, 3 Jun 2025 14:15:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62CF06B0479; Tue, 3 Jun 2025 10:15:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 604FF6B047C; Tue, 3 Jun 2025 10:15:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F44F6B047D; Tue, 3 Jun 2025 10:15:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2F42A6B0479 for ; Tue, 3 Jun 2025 10:15:51 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C17FD809DE for ; Tue, 3 Jun 2025 14:15:50 +0000 (UTC) X-FDA: 83514288060.18.682735E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id F0AC114001A for ; Tue, 3 Jun 2025 14:15:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AivrawSe; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748960148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sKa5t52MY3GEaT9Com1xmb0aaOXYWR4eXFTO3mfWlV8=; b=oZdzulpyUFFdGleXuySupqAdB80UZQBtMEKOUKT35S5ey14QXqegXyFdz3BdkoRyXjMIaq MUS17I3o0nN+ozNpOxYUvzTrLqUvDnzj0MNe73IiPkE1GV4jT2Jxxw5N74cqXGN8LgNzTs 7LEcyLuKpv4ZNNdiA9ylbDhq3xY7SUo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AivrawSe; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748960148; a=rsa-sha256; cv=none; b=A43bL1RF+AOCuOJIN06k72EMh55uskP/ZLF7/dVlI4IES4DTkzfxE2piXBIpiy0pOiLlBB /oUGu5VHNabkqr73nnmKz/WVnavfsLZ48Y2hv92ZxdTnXpypk75sX87jHJD8eEQqbhobkE XZ7xC3GTdie50qerDuYktaUUjgW94xQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748960147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sKa5t52MY3GEaT9Com1xmb0aaOXYWR4eXFTO3mfWlV8=; b=AivrawSe86vuAg+SwvwqX5hILD47/8Fe6GGgWaYIPQ59UanpgjbQzSKjMtGAijQUrN5SUf D0LiQypfqPQcbMl0XXtgumWa94zvTkDELm9/9xPuzVdjV/NA8Qng55GgfvAMnze5mvi9SA DrmsXGws2sMihjXbqz3npZYZrOjN/rM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-1oiQe_9FNyGV0hIxn-4GLw-1; Tue, 03 Jun 2025 10:15:46 -0400 X-MC-Unique: 1oiQe_9FNyGV0hIxn-4GLw-1 X-Mimecast-MFC-AGG-ID: 1oiQe_9FNyGV0hIxn-4GLw_1748960145 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450dada0f83so31065115e9.0 for ; Tue, 03 Jun 2025 07:15:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748960145; x=1749564945; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sKa5t52MY3GEaT9Com1xmb0aaOXYWR4eXFTO3mfWlV8=; b=RxcGS+K4vYcRt3SaR2T7QNQ0LY1PrvT3iNOxwzlZqXkpy4/sV33SRDBPMhdtpYrhx2 R9oCfYjncV3MUoBjXhrEpGVOORsIxqL7Ma/RyCb2n+42IEPRQ8hPBxdZBB2oyhnLkTnQ MIiwW5oE/6F7kGWbZ5uNRH9//uEto0gnOb9It5iNrKO+rf2bFUdrhSc3/F5BUQ0WiSUk mD5t3PP30TzbSx5skNDGkflfSPgyZthaekgRB1kLzO493iOlgEfJjUkNMEJZ1POIJwMe UXk9OYQrQvOT6U7o+dTKtEq/F4VV3dHWlxRzCIVHL5/Vw+5Xb3OF1usfyZR2fJ8d61bI ZuzA== X-Forwarded-Encrypted: i=1; AJvYcCUIiT2y+hAp99wEZX4GNEuGWeSP/mbMSJuw96eOetFIO7apczSKp11Q+I8bG6GluuVO6Pr2mugI/w==@kvack.org X-Gm-Message-State: AOJu0YzN3yzkmgK1jXsANHO80wAvhCmsBhhL/rP/kzcjsvCGlbZ2djUX PGt12hkl78/Ffo864wCZr7oDR0eSkW2Pr+CTpDwgzRxztYT0hY0McA2QD4d3gIqSVDO2eOIRML5 hNe14wnegk87/XmctMgIKakeTN8K6GGU9/vQN5S4FlbJnLJeWnSwzegQx6WyaRyM= X-Gm-Gg: ASbGnctblNRWtBkq6nsDirIfWZIHVvWMCd5nyhy4clTqAdMw8bD20Kk1PaBWaXmuQAW k9n5W86vrf2uI1VSl+xILeStNnhhNE01XjEZtLH9yClGVcs3ANqCDkSYeSxDmKxELTgXbQLo39Y wD5BdcrrPNiI/MmZwB4+YwhOwmvbFBjxLh8CtxqeVznqim9W0s/yO6CXOOnFJ5U4waCHF6TaUCR m61LbyxEh3oUNt4NFP5YIGBK40G+1yb6nvBful/STxAjERiOekp74JaRTDeOuOP/bamemS2lzg4 iNUuoHQByDHCTGiwp8t5RR2eGJQoysiYyxt3MaMlGoxR172Pa5h6bH8ah3zSS05Ew3y4T9DElZq p7A7kVe65hH3s9kgN+l9IzMni3zmrvNPFC99wQa5SRs95nSfS4w== X-Received: by 2002:a05:600c:548c:b0:43c:fe5e:f03b with SMTP id 5b1f17b1804b1-45126572d16mr132881535e9.30.1748960144806; Tue, 03 Jun 2025 07:15:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWpp1Ue9ft7Rf3WE+CItJU5/SFz/z8xheX0XLv2yVZGygyV17SSstF2Qqeydu/Hmnb1lqrnA== X-Received: by 2002:a05:600c:548c:b0:43c:fe5e:f03b with SMTP id 5b1f17b1804b1-45126572d16mr132881045e9.30.1748960144305; Tue, 03 Jun 2025 07:15:44 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f0097205sm18573064f8f.79.2025.06.03.07.15.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 07:15:43 -0700 (PDT) Message-ID: <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> Date: Tue, 3 Jun 2025 16:15:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] selftests/mm: Report unique test names for each cow test To: Mark Brown Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-3-ff198df8e38e@kernel.org> <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0XEfAlRl5N2Dr6S0rcqGsKEPwJ-imSXAdMjqAX7A8T4_1748960145 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: F0AC114001A X-Rspamd-Server: rspam09 X-Stat-Signature: wj8gd9u697cgbf3qjhbuondec8iz584a X-HE-Tag: 1748960147-958001 X-HE-Meta: U2FsdGVkX1/kHuaOVMfniJsH47xbgvgt3+e2DAeJ5nTBReeJzAzDf6N+J7HXosLgWvTJJzkjZ6khxpk93fdbtqASgUFH6CmYBuYDlMVScob5H7UovV6tX1BVrzBUAt6vxiZ5xG9d72TQx9nZWAGHdeTJRVNqFT2ZtzumW9zaiHU2/JiCqSsMhcHQwQzuLlfE9j/9YEazyuPSXv+eKTF7pDIUWRqDJW/NYrSXJL8kkQOKCKyDDMCe7LplZihBmxs1Gv453G0ichrMzMl6TtjGa569qOCve7N11tVwd6j1ABTAerc1rR9U7Kf74CxBfm9tdmnZ+HIaffKi0FQVbkRRhrQfJ5yofW0MOkcTsSI/Odl4eA2j2cX21iU+6Fro3S+w3WMd7QYcGq1DraLcv42xB+UA4us0eY9Aa3uwgqmJTKMEpVbDJ9iAFNmmx6wf4/rth1NO+I1/PI6CTPGs1W6YXqif3HeofgqJIFZ8m98v3ZGuIIR2BbE6+00sGYnD9jkg60F9N/jYK2Kdqb2tORZfMc4XBBYHARS3gvwjDSbot1yuT8Rx/TaTqXMruJbNb0aEGfdlwrsJHdvzUBCStivuNGmeB4/KJhHe9tubS6cCxmXH8Oq3RDgN/WNe0lwtXn8XujivpcI5JV9t6JsHUVwQIEFWsmuX+BDmoO3ocxFZC7kxzr1h127CkZ+fOEZu2vFZtny/MDmC3zkx1107Cyr3Kee1vfRdk9B0ThnEpu7LNjjMKqLGqwRklOB5Xb/XKXboCXhfegpgXLwp7g/O+/tAkR1jjViU/a9assTZRxnuSkg0bOuy4KPUmjT9/JuJxl7A8T6Yzjgbx5kjQGE1glVSXlGavXev01917t6izvfzeC6j9hzAMIXVI8h4UUB9uKARht95Szl6tcqSZ2VuoaM0rHxeMs2SNJd4ax4a3wRPhaASQqayDvFpLzd9LAOOQr9449bikpxxxmjiyOaKXuX EyYfyOP/ kwIi9KQXo9/9kmcRNpN4d3Z0acku9xwctfdMvj37kexZo+rofoGN862YxPfE5LD3FsDZyJvVo6JdLwfDbyMylfAFupnbs6/CYzRHxAdSyRqSvhvLTBYEefV5lDQdOnDMwhpwpldQ602Q1ZBlrtBtCV7y4y6SMnzX8s1cbMYZoe8DF/O1jc8wkpy+xNoF/UyiYevs7zisO7gtVuhu9y35JYEYkFeuXzrCo5XyCHknCYR+OkEJBLFVyg5WcBcLR77m2aMUAlZbp8ZqczZjsu6WreDIXq0tRea7zGAkEgoq9mgTopWj1LNSEIeX7LRTohKJGigCfTurUC0nKMIW9NXaklcK4j6SaCaYJBCGfyXiZRJAoTvbcJpHX2nQvbEVLm0d27untTaSEKPxXHTVioR1xqinygQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 15:21, Mark Brown wrote: > On Tue, Jun 03, 2025 at 02:51:45PM +0200, David Hildenbrand wrote: >> On 27.05.25 18:04, Mark Brown wrote: > >>> ret = mprotect(mem, size, PROT_READ); >>> - ret |= mprotect(mem, size, PROT_READ|PROT_WRITE); >>> if (ret) { > >> Not sure if that change is really required: if the second mprotect succeeds, >> errno should not be updated. At least if my memory is correct :) > >> Same applies to similar cases below. > > I thought about checking to see if that was guaranteed to be the case, > then I thought that if that wasn't clear to me right now without > checking it probably also wasn't going to be obvious to future readers > so it was better to just write something clear. Previously we didn't > report errno so it didn't matter. > >>> } else { >>> - ksft_test_result_fail("Leak from parent into child\n"); > >> Same here and in other cases below (I probably didn't catch all). > >> We should log that somehow to indicate what exactly is going wrong, likely >> using ksft_print_msg(). > > Can you send a patch with the logging that you think would be clear > please? > I dropped these because they just seemed to be reporting the> overall point of the test, unlike the cases where we ran into some error > during the setup and didn't actually manage to perform the test we were > trying to do. Perhaps the tests should be renamed. ksft_print_msg("Leak from parent into child"); -- Cheers, David / dhildenb