From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0D4C77B7C for ; Wed, 31 May 2023 07:46:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 654AD6B0072; Wed, 31 May 2023 03:46:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DE6E280001; Wed, 31 May 2023 03:46:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457CA900002; Wed, 31 May 2023 03:46:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 36D5F6B0072 for ; Wed, 31 May 2023 03:46:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 07E221C70BD for ; Wed, 31 May 2023 07:46:08 +0000 (UTC) X-FDA: 80849766816.06.B93B617 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id B8EA616000E for ; Wed, 31 May 2023 07:46:05 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cb6UyRP6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685519165; a=rsa-sha256; cv=none; b=V4DpKl/+heO0qX3e/mgcVh8K+6+lpYVIfN7H/n2ArK1LomNHEsBYBMpj4qz1JQwVCW+x+y ldJRiqI1i9Gz9iLOZqqAfal/nJ7DLHIeqRPDqnKH6rqUQFubzDaP5T13Rz6kWo5xkuK6by Npf0qJ7OCeNHL9y/JKVtKGJm9F8KZs4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cb6UyRP6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685519165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KADJzQt78DjOkhXJxElYzWhBohOxFMyWxYB3IAT5tK8=; b=lSLA1G91OeyD4cIca1+uPhtJ2yjSpz+YwHF+9VeAKSg8KAenaW3R16SOuZaBppp3zbHRbl OKCXCTr/tLrobe33GjuY3EAZcpKqkZ00/zM+WiQZf6uFjnLcEtkzeThscpM0OpEg8j8DYj /+aw8kQ4yf6gC3t4mzHT2mXnwKZwcq8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685519165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KADJzQt78DjOkhXJxElYzWhBohOxFMyWxYB3IAT5tK8=; b=Cb6UyRP62mXycGn3sh+SykDrIQ4GsDFER1BtZ0RzEulBycnKHpoZAFh/cx+gb5NAsRJzkq U3Q4oRoSYqOkcMpEa/GDvugCRTbJ1UEGIjO2SRltY80uwBb7fuFmBxSAvwtSkovgxVcWA8 +3SbyjvEHd+x1MOgRI1YdhzcWAfrCh8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-L_xypHZuPfqBm_L9MCYB0Q-1; Wed, 31 May 2023 03:46:03 -0400 X-MC-Unique: L_xypHZuPfqBm_L9MCYB0Q-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f6ffc45209so3054105e9.0 for ; Wed, 31 May 2023 00:46:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519162; x=1688111162; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KADJzQt78DjOkhXJxElYzWhBohOxFMyWxYB3IAT5tK8=; b=IoFDIYCVplv2goK7BDeJXoMNBFpF3O2X5QEtdrZP+T30HBrCpZG09iX1+r53S/fQW+ w+hqqBJbCYnko7D0/HpXRrdLtQEb5l77/1DJoaBLW0XHwfnG40F9pJFzqFzscjgJJNob dYo4/7KxT3u7QP4SkhOVLZueQvLD3gWpw9d+4b/fyyJhEjdwVoAvM/ZvavqeZGcr2cMW TfD7ELDCRwojdJOcAJ5Jjh0/pnzqTAIW5P+8DBLXASHMNf/9NpSh3bjiPtrVi/gkail0 PpwzMLu+tRRYvqdUhirmhbRoQgKAI7qBZpDluUAoJs1NBtZpb01cgwnpEJJGupZ9aeEo oMmw== X-Gm-Message-State: AC+VfDxxVF82G8rN6pE3nvtBzOdjzyktgsAcyTZoWQlmqrGPhEy+HefT YQPaTTZ49QkCCw1ZWF9X0OtzZez2s6p5DNRB8F8i8HcRQlEtsPDbcxWgbVQI6aJUHizl8h7L9ZQ V9mtOvMdxeMA= X-Received: by 2002:a1c:f706:0:b0:3f7:5e1:f3fd with SMTP id v6-20020a1cf706000000b003f705e1f3fdmr3625249wmh.5.1685519161761; Wed, 31 May 2023 00:46:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ436UU61NczDYH9UaXW/YOC3HPN9Gmy77aR6LZ58EoWnnluA/iJOcFIqaN4LScHpULaPFgovQ== X-Received: by 2002:a1c:f706:0:b0:3f7:5e1:f3fd with SMTP id v6-20020a1cf706000000b003f705e1f3fdmr3625231wmh.5.1685519161408; Wed, 31 May 2023 00:46:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:cb00:fc9f:d303:d4cc:9f26? (p200300cbc749cb00fc9fd303d4cc9f26.dip0.t-ipconnect.de. [2003:cb:c749:cb00:fc9f:d303:d4cc:9f26]) by smtp.gmail.com with ESMTPSA id u20-20020a05600c211400b003f4ebeaa970sm19755583wml.25.2023.05.31.00.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:46:01 -0700 (PDT) Message-ID: <465c83f4-10c1-b025-cae7-04e5ff5f7561@redhat.com> Date: Wed, 31 May 2023 09:45:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH -V3 3/5] swap: remove __swp_swapcount() To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Minchan Kim , Tim Chen , Yang Shi , Yu Zhao , Chris Li , Yosry Ahmed References: <20230529061355.125791-1-ying.huang@intel.com> <20230529061355.125791-4-ying.huang@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230529061355.125791-4-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B8EA616000E X-Stat-Signature: 5i6yps5o79ih48o38rs5pyj7yuf481ci X-HE-Tag: 1685519165-258115 X-HE-Meta: U2FsdGVkX19TftXHu2/ElcHofkgcwa7MWAN3AwLjasGd8DiY07huT673+nFrkkMPOOLufvHIDQv7s0++Etbf6xrOsh5ZchnVCuFsFmLoTEEakv/wl1ov407iFbGyFjeQUcPmZohMplFXEp95+nkyw2o+J8XR1Y6aUSfLjcKGVpRejZPbalIQRfjpfDOgl7KievUsL5CcYcLOyKnBcziZ4vs2y1v+2r0498ZaOjvoK+btlfUoQ6eV5zYpQVHfhJXuhsGBVyQCuD+atw7sm1cOLgct/1UdG25qw4uUIeDhOQNTdHK3TSUFLy2wPlEA/92rsD5DuRmxrwuv9v+5I90rPEvPMTpJxvDYO7UZisuHCH7X5ZXFJ1ZSP9eQUWdyfN3RrOun7QuXFKBNejg/uzyDquqDy98aiHtDYXcp+BbqNRzmYcDZVx+1RvPmD0i6syZMJRWCqLrwEXqTQ0UoLS7aTm+3nxJAeTcp5XxpqiSh5yMgEvOEe4KYrJp/hy7q15IKgJaQQTusgKfdXWMNDkBzyuogqFkWFikGYQXP/+DSjLW2aiPfm9paky2VhKc8+4zX6/mVeL75gLh1XFwTHzaBdf8V1A1i4limYlh8K2exxEfwbNrbXBhw5BtpfZZvYXWppbgzr0vX8YYyTus8gG+rz2JBVrq2Yr0PiPTLIVu2Ax/kUo+mpx9lLuf9D0W69w6T9TDMVCTSdo15EKvJNzm6de3/GyrAHch/S7pTQaMgYY4Tsji3YR2YilFTm7BUkFgONetysBAs65DMkoShoICpJhajV5o+vi8RomNKQBGtMgG2C/R5CoJGEGnnZ2qmXAOdz77koF6aXOiahj4dcVXwvdoyLwlr5G77uKwM+gRSZLPS/x8tZTeCcsZBop4wrfXfdzcCsz/l/MVCkwZjgZ7Y87/TffBZbO1h+2mf83dfNVSRwb8JqCEb61AI4JJCLXSD8L7fabXiv7ya/WH0Mr1 0RR29i9h i6LGHv0KYzadypbJLPLqGhnh7zx/cIpNak6DB4KrQvb9t9VblURk01363/4ZHFkwPGX8bOSemWGJjk7Casrrqfifd64wLsnI/6zan6wnOk3E47zig/yEtqdKhcTdkJD0AzvXUQjmgdca6H5o6J+ZJqnboGX/7/gcJ1hEVrRcHuZmGwIniEBE9JxuuxHCbJSy7ht5u5IdQKCM0kZTn9OPQaHoByqK5s5cEDkkepyHt9Ubc3H2ccwmXoJ1d33qTOBiabjHiGbfC/KW0RGyQcPX9BiYuZNnopIWR4RVfEWju17LDU34eiUP2L/3Ckpz5S+R96MRF/vHjFN8Q+S/7OVZAgvIIsFAYwcj5Xc5ANjEGf7sCTOS8RZ7cSrsxQvnzkKUWKqaCb/UD39+DvocqwtuKLo2IueveR7idkLkl8N+fSJiSTT4mUD7RJgLqC8006lTs8zvLbvEc2eJKnMJKEideUL9y+KcDUHm5KQdaqVEeNFAO3uwrsvOo/4Nfy2O2TuriD4VZxL91oknWNSCgY9MMkPypJ71f946z62/uCiSET/ihlGzfwSZfEsLbFEOPsGafb/EpHftMXOtmbUSGnDvsPggysdSiQ7oytezqVPQH4UPg62CMviO5Y0ggBiFxu39yum1/TAdSe/d6ATu8jcLVAbAGWEfAlTuV0ojNGpLYnxt1jmG29lSWt3D75icYn9GI+evM8JKnpf/Nl3jMm9xfgNm9yWBhxXu0HUxwVRX529TigibOziWGOj+Tg08N4MsBO9Qw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.05.23 08:13, Huang Ying wrote: > __swp_swapcount() just encloses the calling to swap_swapcount() with > get/put_swap_device(). It is called in __read_swap_cache_async() > only, which encloses the calling with get/put_swap_device() already. > So, __read_swap_cache_async() can call swap_swapcount() directly. > > Signed-off-by: "Huang, Ying" > Cc: David Hildenbrand > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Tim Chen > Cc: Yang Shi > Cc: Yu Zhao > Cc: Chris Li > Cc: Yosry Ahmed > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb