From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <465551DC.4060603@users.sourceforge.net> From: Andrea Righi Reply-To: righiandr@users.sourceforge.net MIME-Version: 1.0 Subject: Re: [PATCH 1/2] limit print_fatal_signal() rate References: <464ED258.2010903@users.sourceforge.net> <20070520203123.5cde3224.akpm@linux-foundation.org> <20070524075835.GC21138@elte.hu> In-Reply-To: <20070524075835.GC21138@elte.hu> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Thu, 24 May 2007 10:50:49 +0200 (MEST) Sender: owner-linux-mm@kvack.org Return-Path: To: Ingo Molnar Cc: Andrew Morton , Bernd Eckenfels , linux-kernel@vger.kernel.org, Rik van Riel , linux-mm@kvack.org List-ID: Ingo Molnar wrote: > * Andrew Morton wrote: > >> Well OK. But vdso-print-fatal-signals.patch is designated >> not-for-mainline anyway. > > btw., why? It's very, very useful to distro, early-boot-userspace and > glibc development. The only add-on change should be to not print SIGKILL > events. Otherwise it's very much a keeper. Hm? > Actually it seems that SIGKILLs are not printed. In get_signal_to_deliver() we have: [snip] @@ -1843,6 +1879,8 @@ relock: * Anything else is fatal, maybe with a core dump. */ current->flags |= PF_SIGNALED; + if ((signr != SIGKILL) && print_fatal_signals) + print_fatal_signal(regs, signr); if (sig_kernel_coredump(signr)) { /* * If it was able to dump core, this kills all [snip] -Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org