From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840B6C25B75 for ; Tue, 21 May 2024 09:36:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1FA36B008C; Tue, 21 May 2024 05:36:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECEF36B0092; Tue, 21 May 2024 05:36:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D48746B0093; Tue, 21 May 2024 05:36:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B09BB6B008C for ; Tue, 21 May 2024 05:36:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5AABBA273C for ; Tue, 21 May 2024 09:36:50 +0000 (UTC) X-FDA: 82141898580.10.47C0F29 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 196CDC0017 for ; Tue, 21 May 2024 09:36:47 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="YLv/ULHg"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716284208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8TotQymrkTXKJP2dbOeE/8/7QYh8IcgEOhwgpcYLit4=; b=Wz+gfd/9z6Fjo8hAotZ7WNNUmiWMtM6TY/7OorNimxI9Gquxaxitqltwjlw9XTiMaUUp94 jopkq3qGOF2/Tf2E/LGtw0lGPbJxUuG/A9Aeg7bsCXjDXnsFCm3Cwsvb9qm7S4oqv8DLJq vUKxAlehaPn/QNU/NqomDRg/1rKa9HI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="YLv/ULHg"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716284208; a=rsa-sha256; cv=none; b=XGdzF4du16AR2VHhOg1FCkq1I1U/j7aRq94ayvPJDv0UtZqxpTyCcDmMabT18JvqD1Ds2f DBwluC6vuYovE/fkV7LteTWO8p0GWhJpenoUxdhL1LxCBEEimtueVAMUN4Bmx7/odqV9M2 cb6mu05Dcos6WkZiM7w+1hUf+Z1WtuU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716284207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8TotQymrkTXKJP2dbOeE/8/7QYh8IcgEOhwgpcYLit4=; b=YLv/ULHgvdhVUp4UZ2/UoY6XhgK6cIvXMhcAuxRMH8aBQVup0qFsWy5D6EVe/uaKaB64vE 6RuCE1+HbqqALl5uDFBfSMFYQjQBwOXI9qEx9XqqC419whiWkOBP83Ed57SlqxJIe22kCV DJHJbTeFYIJlgMEdugQLCGuhkaOo3A8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-iqMkBiPfOhW1pcMGU1GUbA-1; Tue, 21 May 2024 05:36:45 -0400 X-MC-Unique: iqMkBiPfOhW1pcMGU1GUbA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-351bf7f7f73so5259790f8f.0 for ; Tue, 21 May 2024 02:36:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716284204; x=1716889004; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8TotQymrkTXKJP2dbOeE/8/7QYh8IcgEOhwgpcYLit4=; b=AB+NsyEKPbjPnXXFw8+mHF11ylv3yGEWWPDXDKrPYJZ2j/iqldQjDo9ODg7hqf02rq ul/ZY7hUpmoD7vKhHMZrXVbnKOHgpE85C0JhvJf4tdRlXB2IAlpPE5hcFzORJYcd4Hos IBcQ2quVLj6X8lGgwTnmda/chA42sABFnFwjrPzTiDwg15lUBOcV+HGgJlgbD0drVyl4 r2+SuZ7SnuXOo23kNm80Ielxbs3ghpbqTrlhPmTGlSjQSzI4cemuwjMYNJLg7tPT3pHR aT70gD8Vcg8kI+S1qq0Ebj/cLDKwTXfeob5xubiax1J1PM4EiQHztKHufu/IWiVb/H9l 3Frg== X-Forwarded-Encrypted: i=1; AJvYcCVZ0lcWyHzsP/qXsJDpajzfsj21obGCELrtsXvsLFcEOtntbEs7PXteNtRor6rJGIhBEju42KA4SnIZT/i2ytGwdKc= X-Gm-Message-State: AOJu0Yy/q8E1P3L8b7/ETmR6S/5CeHus980P9yMKb9cy1AGyFGHKmtDZ QOaUxRiyRCvgNH66LsLN/XbTIFsttmlOqPpV8t7TTzATTfAHFrbza2JEVXcDtW3hmgnuYnnHUAd MhNa5Q603b8VDl6SPvrD3ZPt2k0LUxzmnxC3R7WfXyg+qa7OF X-Received: by 2002:adf:f590:0:b0:34c:b86a:794c with SMTP id ffacd0b85a97d-3504a96b845mr29768829f8f.70.1716284204296; Tue, 21 May 2024 02:36:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkrfOPTQeHBK0L612NDmEfoV6h/sGmyVuwJjpTZyriwnIAr0c/urZ2Tu2jhH0ROmfzvFkapg== X-Received: by 2002:adf:f590:0:b0:34c:b86a:794c with SMTP id ffacd0b85a97d-3504a96b845mr29768805f8f.70.1716284203881; Tue, 21 May 2024 02:36:43 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502b79bd09sm31289718f8f.14.2024.05.21.02.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 02:36:43 -0700 (PDT) Message-ID: <4650b888-d90f-40e3-8c53-c9949e539959@redhat.com> Date: Tue, 21 May 2024 11:36:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] mm: Refactor update_mmu_tlb() To: Bang Li , akpm@linux-foundation.org, chenhuacai@kernel.org, tsbogend@alpha.franken.de, paul.walmsley@sifive.com, palmer@dabbelt.com, chris@zankel.net, jcmvbkbc@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, ryan.roberts@arm.com, ioworker0@gmail.com, libang.linux@gmail.com References: <20240518074914.52170-1-libang.li@antgroup.com> <20240518074914.52170-3-libang.li@antgroup.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240518074914.52170-3-libang.li@antgroup.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 196CDC0017 X-Stat-Signature: zabh1ymncys75o1tmnmjfub89pog5qty X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716284207-953716 X-HE-Meta: U2FsdGVkX1+qt/2XHivHhKHm1xl0L02REzlMN87XfCYDjnzwtKDiOa62FwHHnAWYP/ZS7PvbMKWr483o4ePFA8u19e9mnkNWgckz3Nq8YXr7rhveLgWQGnrqtGDTiRm0y4MnRZk+KF09oFkj0cyRnYFQiLmuJg4t7kDxowSm5nPlefYayK6zDvg2W1Bcg3qi7vrCwPeOmYDzLOOK/GQz9crFzZsXompLfTpd2OJ34BIjt5SU1Ha1Y8uqYKMX+x/4xaePZNZ0LvuNnVS3d2lE1rhnPmwEYRzmqynT6ZHepErR3rDAVQXg4QIVJG6LHyeTS1zvJq+TxAuDFzks0yKvksoiQ9oVZA5C7HSQ6TAYhhNHLki2C53zAQ1sjhGte9aY0/cibvMov7ZOzNbvkmNExx1a0jIo2OEyLdchdiOORs10TpSXmY8t408fMyah3MggILcr+W6DCNjlnA9VH+C6XygvY8dYav9+JhBjoMm+HMp4JksWjvJDh+gDssoW5UMVbNJujja0n7QD0BbwDDgubBCS+cAwptTZqTc67J3w1pJ6K2utmIANz3skrwmhW5aF3CVAbubEsNBifWgz0UpKBDAn5/zWY8VQsCUyn5by74lAkizjzPwwOK+LTPXyyEM578+NVdsu0YTsjz58i4cj4DgX6/4rjnhGkKr7sALyoPVQc40P4ykXnqnQLDIPQuXdUk7bEX9PLnt1MKgE0l6/lGbqdtemeq6Ym/y2o9MeL3G8CFNlFlJZRV5Q5JAd7Y8PIgsBBV9EQL+bn82lG0gedZ3kZE25qOIRdJuRQTX5pGPOmlbDsxiy+3TWPmkNwTwvwdNsqsw/V/hEBHWKCJVQ3LYPC8lK5rUKH1HCDGB3QiDBy89wCa79JqpPn4w6vKbYZecPfrjKWQKBm+4p5+/9PvG7oQKkbATTVWtBgvfjaCRqvcMdz8Y8H0eX2bRgZuCOn0VjInyxkRbsJ7ye6qL m755vISm E/9vC0GZlTXSpkFn88yztuFYIfTLFUng3mKomjkYIgb4BW7s38f3nYeI9mNHxSvk3s87EPX5/Sqo5C/nMw9M5+u8nG83eTEwDaXG20Nk5Q3MhZh11EZRpVRS4S7z+wz4zcILWTMRxB6td2ay7HuS81yY1Rg35f2aCcBoqtbQmvpPLKyWXNyJ7cVNECekmYBBneLPdbAsLnrZ9pmwY2mxcfrOqO4pf0bC3WJAAtNS4s2QneOHCjJORot5O0yAdmpFGi14eFBOhR45rZO5AdkwfsOenXcYWmreBmOXAwNOK7oVv/rRSGdzWm8hwVZPU0dw57vvyMB4Sm8SiVggOhH4GdvRMkF8JaYaY6FEtDQL0UOeetOKfhIG/+4HipFX3E6o3JR15kgz41iXljI1iuUPShWdee0EEqKgo+iJKrnv0h46coMB2ZQM0P0r4PjUQCR/cgNc/hP5w3ObQ/bgV0L0HTGVrvPiH2M+WnScjIt0NLevuSDb68AtPbVHesbBZLYsz9g/XTLvqTkIkpBk3RKb8IIllcQEiPIyoQ0o/1mY2foKXKxo+fizd6rwy9kBf9bfodvVkYDW5aDsVlx91TTxqv9AjXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.005269, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.05.24 09:49, Bang Li wrote: > Remove update_mmu_tlb() from those architectures and define > generically via update_mmu_tlb_range(), removing the ability > for arches to override it. I'd suggest something like "mm: implement update_mmu_tlb() using update_mmu_tlb_range() Let's make update_mmu_tlb() simply a generic wrapper around update_mmu_tlb_range(). Only the latter can now be overridden by the architecture. We can now remove __HAVE_ARCH_UPDATE_MMU_TLB as well. " [...] > +#ifndef update_mmu_tlb_range > +static inline void update_mmu_tlb_range(struct vm_area_struct *vma, > + unsigned long address, pte_t *ptep, unsigned int nr) > +{ > +} > +#endif With that in patch #1 Acked-by: David Hildenbrand -- Cheers, David / dhildenb