From: David Hildenbrand <david@redhat.com>
To: Bang Li <libang.li@antgroup.com>,
akpm@linux-foundation.org, chenhuacai@kernel.org,
tsbogend@alpha.franken.de, paul.walmsley@sifive.com,
palmer@dabbelt.com, chris@zankel.net, jcmvbkbc@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
loongarch@lists.linux.dev, linux-riscv@lists.infradead.org,
ryan.roberts@arm.com, ioworker0@gmail.com,
libang.linux@gmail.com
Subject: Re: [PATCH v3 2/3] mm: Refactor update_mmu_tlb()
Date: Tue, 21 May 2024 11:36:42 +0200 [thread overview]
Message-ID: <4650b888-d90f-40e3-8c53-c9949e539959@redhat.com> (raw)
In-Reply-To: <20240518074914.52170-3-libang.li@antgroup.com>
On 18.05.24 09:49, Bang Li wrote:
> Remove update_mmu_tlb() from those architectures and define
> generically via update_mmu_tlb_range(), removing the ability
> for arches to override it.
I'd suggest something like
"mm: implement update_mmu_tlb() using update_mmu_tlb_range()
Let's make update_mmu_tlb() simply a generic wrapper around
update_mmu_tlb_range(). Only the latter can now be overridden by the
architecture. We can now remove __HAVE_ARCH_UPDATE_MMU_TLB as well.
"
[...]
> +#ifndef update_mmu_tlb_range
> +static inline void update_mmu_tlb_range(struct vm_area_struct *vma,
> + unsigned long address, pte_t *ptep, unsigned int nr)
> +{
> +}
> +#endif
With that in patch #1
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-05-21 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 7:49 [PATCH v3 0/3] Add update_mmu_tlb_range() to simplify code Bang Li
2024-05-18 7:49 ` [PATCH v3 1/3] mm: Add update_mmu_tlb_range() Bang Li
[not found] ` <b356b558-d327-4bbc-9290-4e296877d145@redhat.com>
2024-05-21 15:36 ` Bang Li
2024-05-18 7:49 ` [PATCH v3 2/3] mm: Refactor update_mmu_tlb() Bang Li
2024-05-21 9:36 ` David Hildenbrand [this message]
2024-05-21 15:36 ` Bang Li
2024-05-18 7:49 ` [PATCH v3 3/3] mm: Use update_mmu_tlb_range() to simplify code Bang Li
2024-05-20 14:45 ` Lance Yang
2024-05-21 9:37 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4650b888-d90f-40e3-8c53-c9949e539959@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=ioworker0@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=libang.li@antgroup.com \
--cc=libang.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ryan.roberts@arm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox