From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <464ED258.2010903@users.sourceforge.net> From: Andrea Righi Reply-To: righiandr@users.sourceforge.net MIME-Version: 1.0 Subject: [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Date: Sat, 19 May 2007 12:33:04 +0200 (MEST) Sender: owner-linux-mm@kvack.org Return-Path: To: Bernd Eckenfels Cc: linux-kernel@vger.kernel.org, Rik van Riel , linux-mm@kvack.org, Ingo Molnar , Andrew Morton List-ID: Bernd Eckenfels wrote: > In article <464DCEAB.3090905@users.sourceforge.net> you wrote: >> printk("%s/%d: potentially unexpected fatal signal %d.\n", >> current->comm, current->pid, signr); > > can we have both KERN_WARNING please? > > Gruss > Bernd Depends on print_fatal_signals patch. --- Limit the rate of print_fatal_signal() to avoid potential denial-of-service attacks. Signed-off-by: Andrea Righi diff -urpN linux-2.6.22-rc1-mm1/kernel/signal.c linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c --- linux-2.6.22-rc1-mm1/kernel/signal.c 2007-05-19 11:25:24.000000000 +0200 +++ linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c 2007-05-19 11:30:00.000000000 +0200 @@ -790,7 +790,10 @@ static void print_vmas(void) static void print_fatal_signal(struct pt_regs *regs, int signr) { - printk("%s/%d: potentially unexpected fatal signal %d.\n", + if (unlikely(!printk_ratelimit())) + return; + + printk(KERN_WARNING "%s/%d: potentially unexpected fatal signal %d.\n", current->comm, current->pid, signr); #ifdef __i386__ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org