From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1794DC83030 for ; Thu, 3 Jul 2025 12:59:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0C4A6B0176; Thu, 3 Jul 2025 08:59:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BC126B0179; Thu, 3 Jul 2025 08:59:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 883986B017A; Thu, 3 Jul 2025 08:59:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 74CDF6B0176 for ; Thu, 3 Jul 2025 08:59:58 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B45614012E for ; Thu, 3 Jul 2025 12:59:58 +0000 (UTC) X-FDA: 83622960876.03.CD41EE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id B1E1E40006 for ; Thu, 3 Jul 2025 12:59:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VwT3bCD0; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751547596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RPqm9+gCQ4G++ODNHAXi9UZv0hvANLxxg7IJ6626syU=; b=drzKlLLjO2ndJVKAcR4oeZs+jIfpJtAI2mp6YmU5KI+0yYApsCY7qGJzZNorjSz2+r1UZa xi3gh075U46Egf8YMGyMC8itwcHnIn4NbjSS7jhaXUnFcFOKCxSYhidNSFHrNt0cCYp2eP B1WCyO5Pp4LAHvdNa+SRyyFQUfQzMWs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VwT3bCD0; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751547596; a=rsa-sha256; cv=none; b=V4KVQwkDvdbwGgHB6+MJsaUvoPMWedjwMh/i2ERhY1j54I2bS/3upqFwLs5pVtw2ne95SP ZsMA7xKpUdz3NEYiJowndgPrTILVa4wj1LAdQY21u+ao84zE1yaTfl0TsoPdGOatYRxeq0 S8Xa0yyD5PpI61/ith4KD6KMx0xAb5o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751547595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RPqm9+gCQ4G++ODNHAXi9UZv0hvANLxxg7IJ6626syU=; b=VwT3bCD0ZPbw7iN6C6PR7HyX6bdZyneJ7yD5ZnAbCg+iRyYovOYip3u03sflZyP5GeHw9V x1G8RlJp/pEKVQ3YE4XdMb8vfevalOBuVZja8OwX2AxFimyHTb/2p8OqduO6cAhaXxFAXx z8Mp4ZwdrNCNkw287Qk1KB6Ax9SnYDM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-gGC5kmOcMmaP1sC7PFs7Lg-1; Thu, 03 Jul 2025 08:59:52 -0400 X-MC-Unique: gGC5kmOcMmaP1sC7PFs7Lg-1 X-Mimecast-MFC-AGG-ID: gGC5kmOcMmaP1sC7PFs7Lg_1751547591 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-acb94dbd01fso443592266b.1 for ; Thu, 03 Jul 2025 05:59:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751547591; x=1752152391; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RPqm9+gCQ4G++ODNHAXi9UZv0hvANLxxg7IJ6626syU=; b=QzWcE6luByWU6aNM1OAbHnvB8dI+2HyUTQCfwchD48do6qESIglEBBPBRp8qNjozmw Agmv4YRcfpz+/gezgMmDD83LvCQQcGgzTJqRKQd5uVbQhSZkn8U/VF6Dz/HG/QkJHk7a eLZ3EeKbisx61ucEt4RQLNN7irR/9GUOxfgozaVES/UgqRP4XbaTVGbr9XFafnfEiiDU AQLw2Vp5fpa0aCj+jdLUjUyt/ooB1QSlAAzlZEYvUZ89z9aD1ouTq1k4GkrQ2EYO8Ylz 3dRZjd+OnbtGiIJHo3DTnVmN+dhgfFMqetIqliK8Dd1TPnLNPYKPHNjUx536sqp0rOhl XoOQ== X-Forwarded-Encrypted: i=1; AJvYcCXRWBTcXaikzB0m3vrVGClLpt0tCuHg95ykLkEFBauTWn0Q6rjaTGHRxM8R1URgAjEQifsGpX5iDw==@kvack.org X-Gm-Message-State: AOJu0Yz1GMIkHg1zcSHOX1XHjEO7xN59LR9o30+x5u4JMqksv37BKU8q OcZMgP24QtP+4SLsPByq+VO7VXt84vnlexYHRMcC9VTu+q7axwEzQ7pHJq/u+v21Ib61HdSFPkh t+VdU2y92fYcX0fNzVYfnKbHXZhz4WA3wIGGqPZOSLhIwrDCkYM5r X-Gm-Gg: ASbGncsBNLpwGo1JvMjTyU5gtL3sPbmutGpBb3N7xo4GIASweYNbOtwDUTC8N8T1vNB asoEErjPWj2Rytxpfrhlj4p4qyndHxXxMMzF/mCL0nGQT3eUWBzd9kbGxamxNYgJWF1ol9HrXhi bHCtdMV7QPzAnFLSMbfn1ekRUlJPa0S1A2Xiudjai41/VEvLw6ABRwtT23YXVYy74/N4nnqUbaz FdOJcIid8jg1bUc1cDVmWswLes9v45dPMzJ0/JZPokOHxrWuuyG2pccyz2/MotyWju/XkFcHDKm WXG11QCuyAK7++jHXeZd0MHM7peGWNYFCFO8sr00W80F X-Received: by 2002:a17:907:e989:b0:ade:42a7:dad2 with SMTP id a640c23a62f3a-ae3d84f7bdfmr291460966b.33.1751547590628; Thu, 03 Jul 2025 05:59:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFC0vmyCUfKNh5+RJRYCTBoX/Ahh5v1AgHscMOi05wRVFGjPHp+ArXAFWzQGHk5tNdxXoWaiw== X-Received: by 2002:a17:907:e989:b0:ade:42a7:dad2 with SMTP id a640c23a62f3a-ae3d84f7bdfmr291458066b.33.1751547590098; Thu, 03 Jul 2025 05:59:50 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c6bbe3sm1258053466b.118.2025.07.03.05.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 05:59:49 -0700 (PDT) Message-ID: <46474fc9-cf31-400d-aa65-d7fc013e6274@redhat.com> Date: Thu, 3 Jul 2025 14:59:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Optimize mprotect() by PTE-batching To: Lorenzo Stoakes , Dev Jain Cc: Ryan Roberts , akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com References: <5900e978-6349-4a3d-a384-758889b678a0@lucifer.local> <3776ac82-4cd5-41e7-9b96-137a1ae6f473@arm.com> <64c2ec85-87ed-4793-b0e9-a68eac1a8020@lucifer.local> <61f50191-8bd0-4f25-b3b7-86605af8c0c6@lucifer.local> <3ce333ae-dae2-4341-83c5-39877b6f2bd4@lucifer.local> <1d1312e8-325f-404c-9ea4-03b38ed7b1e1@arm.com> <9c7a0541-219a-4ea7-a7d8-83aaee992b1a@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9c7a0541-219a-4ea7-a7d8-83aaee992b1a@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MAViO6Ee3uckV3YT156RIPvhsmO3B1GxoNxJkA9qfDk_1751547591 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B1E1E40006 X-Stat-Signature: xmww6dtnpeuwxa1s56wcp1ej19ea9kqn X-HE-Tag: 1751547595-845992 X-HE-Meta: U2FsdGVkX19oy0Z2LyVaCH5IwLcLSvMr+x0U7cS7efGMIv48pdZHdv6helUqpY1g5xYVm+oSF0BzrvH7tVrQUY5n+h/25iN7Pu97q15rBHIomZgDk0y79J5Ts1YKobe1Wcef7rHD2eXZ3DgKbIKQT1A/XsapbsfW0VuieqxAHaLTtgDQMuMtqrZqkLbOWa/kbpENKiV1w/UPWSh+YHEutkYphSHYbcw8cjunPBjlysY43UhN2W25UteFGUdNEMO6luhSjwbdYOYNZOFHT8gVhsBW+qR4u5NEgNo1zkKFiOOniLIa9acBTbyLDUvmn1zOel9qSPnwoIxinlst9wbfcJPpCTZRY+oP0I1MNeV2MI3jqbJDINW5l3YnWhhi3jzmXyi9rc2664UdoIsrMWjN9s4CMzi/ISzdhfCmz4tFnqU7jHuCtSOITDfpXpj58d4IXNPyCjY992u+UC9Rt/2DQf3xpyDplu9+farfM7hEMKt0NebsBDmtPCcFg8hLFy+7o8Wh+Kt0+YaMosnxnSY7+xQFxiuJI9GdhNHysxAWrNgtcHffFdPakJNdoX63hpB9uEciGkSfQ/oCbHeGT2iA6seN+rCUFRJ2J7RKXb07RDhG8jURyuSBpvzPvzdTKvfBhFtbK7KY5OSY4XZu+TwuOIgQ1ItrjBe65IsBBV8CZQsNNON+F7a5nRTs9D9MP9dvLXBQL+THpHzf6tyFvu34mt0T0YMTQeqZNdwqjv3Eg7KPAjQ4d7oCQCJVbQVMOrH5ScnRhRJ4lDD+m2BbcVJCYAz0xYm+QQzE5bu6+yTIF338aD1npFVzuKYYeX32K5OEyf5GDDWJNOM6sbekNKMFEVHXsbVthT/SoHe3e3eXnWRcWBeujE5/lQqkXJlY67P3FMB5qI+Y7kJAnrzeiPkTUK9XA11G8lC6yEsWzfWvf/tRgVueoCwFJiEKM1sp7P5+i4O3dAz/kuSsFjVBiBx wT+bIWAn fJ64Q6+/LTVVpHvuA8DdfOpkIGB/RZGLiIL4KQvoT9mMpYMJlnQB18XC4PVn4z4u3y70TmahdnOd74KiHBMg6wKTpMuMQ36TNZi64mONGQ3oUOiZVxxfFO1u6OiTB+83ZVOA6tDVujk+qe5qhbFydXKW9p6uHPtBvbnlbQtRwetv9y5O+U+NPPXOwK6fAv6pRJgGFEpHMhwaoF/3bMJkjfus7xGRj9qE6d8+Mmjn/syQk0qjDS1GdK1dd9wb0E0i7JvXZtWMLN8wowV3PHcVAcsMjqVptsoEq8v9sRhuLTgYQS6M5JY8SVv37Tx3g9sKhJ9k7ac4hnAARWBS83l5pPK8QJnc+SwuW3Wx79t3s7+dvZ9Myefv9QdO9vNctfOFtlp+lQnBQ7JOszwINJr7TEpdodjWAhlEH9nf0CYSaxR2YJ8m5DTzqQBDHxIuw46V2/E6/Y0PRgsNM/uaffA2SOnx1fTukBVkt2kTwBEa6SOu9qUgjJzMKbQItGQkkPqR9cA5k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 17:22, Lorenzo Stoakes wrote: > On Wed, Jul 02, 2025 at 08:33:39PM +0530, Dev Jain wrote: >> >> On 02/07/25 4:02 pm, Lorenzo Stoakes wrote: >>> On Tue, Jul 01, 2025 at 02:40:14PM +0100, Lorenzo Stoakes wrote: >>>> Let me fiddle with this code and see if I can suggest something sensible. >>> OK this is _even more fiddly_ than I thought. >>> >>> Dev - feel free to do a respin (once David's stuff's landed in mm-new, which I >>> think maybe it has now?), and we can maybe discuss a v6 with everything else in >>> place if this is still problematic. >>> >>> Ryan mentioned an iterator solution, which actually now seems sensible here, if >>> fiddly. Please do try to attack that in v5 to see if something's workable there. >>> >>> Why are computers so complicated... >> >> Sure! I'll be out next week so the mm list can take a breather from my patches : ) >> My brain exploded trying to understand your and Ryan's implementation conversation, >> will read it all and try to come up with something nice. >> > > No worries, it's actually genuinely annoyingly tricky this... :) we may need a > few more iterations to get there. > > Really the underlying issue (other than inherent complexity) is the poor > mprotect implementation in the first instance that makes the complexity here > less easy to integrate. > I haven't really scanned all the discussions yet, just something to keep in mind: In the common case, all PAE values will match. This is the case to optimize for. Having some PAE values not match is the corner case, that can be left suboptimal if it makes the code nicer. -- Cheers, David / dhildenb