From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23DD0C02197 for ; Mon, 20 Jan 2025 08:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACCB66B0085; Mon, 20 Jan 2025 03:14:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C3B6B0088; Mon, 20 Jan 2025 03:14:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CF4D6B0089; Mon, 20 Jan 2025 03:14:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6C5DB6B0085 for ; Mon, 20 Jan 2025 03:14:22 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E4E46C2890 for ; Mon, 20 Jan 2025 08:14:20 +0000 (UTC) X-FDA: 83027117880.29.330F246 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 68F371A0013 for ; Mon, 20 Jan 2025 08:14:18 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UWCTN+cp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737360858; a=rsa-sha256; cv=none; b=z7n6uKOxvc76Zk9eC+rGsE9teD9utsFvHfR5GszD6K9u/BuwvwcDKLgNhHcujE6oFchxsV WnlGZdwjbGcC4ha4E0ED3D4MyHWKva3yp4RWF2pSyfv+oOKdu1gDejXSYKze9WEeLBcPjH djMPnU1h9BFaWfQzCYLjXRpsbh6hS9I= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UWCTN+cp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737360858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cW2Gi+J77c0vHOkfEEqbnX4dRXqAlvckYtLF/O9IZ/0=; b=gKVfifvq8Rq3YUP+RHZv+LVIX1EBjFCZtcFLtobQEJgx6Zvtq3tKrj3/dhXsqeP5fNAaFF XDykJ+LevFvKtXt+HW11gXzYsAQlDam3QAnp1zfCy63oRzVUdBBWOwsW8JPP5oTYxuyHwd 23xm01G5RtnCwz5zZFrfsvC8uaO8+Kk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737360857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cW2Gi+J77c0vHOkfEEqbnX4dRXqAlvckYtLF/O9IZ/0=; b=UWCTN+cpAMtPcClGIbCbZ5dAa3fxOe73YJV3tvJTquvqwuDF+GIaNnqiaTk0+EjYCGhwxC T688MuM4Z2Or+c8dnSeypoLrU77Svp56cFpotQcw/PyCZTN4bJFbvPE7fLSMwzvu2rP8LK 5trleyXKkCLjuatWQp+rVq/3ljgolp8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-IF1kvSOaPf--2BHRPCUfzQ-1; Mon, 20 Jan 2025 03:14:16 -0500 X-MC-Unique: IF1kvSOaPf--2BHRPCUfzQ-1 X-Mimecast-MFC-AGG-ID: IF1kvSOaPf--2BHRPCUfzQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43631d8d9c7so20603315e9.1 for ; Mon, 20 Jan 2025 00:14:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737360855; x=1737965655; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cW2Gi+J77c0vHOkfEEqbnX4dRXqAlvckYtLF/O9IZ/0=; b=v5QQ36c13JuD2tEhZfGfaYlikFjhb23ArbiXys3vmQEmJlEAp18/2RLUy9DlAA4+rW hXWSEglfTdD1Izwuu+y4KYGYnL8issMRuJPk16Ks+6NV3aNVnmtyPoowlO6YV853ggxo lERINdsRcMwEQT3resyDxwsEJGzTiyjqYIxxrmzOeHFp+KX2jSYC8oXkmgkHpLdDKuDM qU7zp3gjRSdNqYetGentH2bmUBsJHK45jGq0YB0v53fVLEVJva48253AslHVLVzoMly8 PJrtAFJ1nJzMTspqCuYYxSa7H2bqf1sBvAAm197INmP0kDdI4bLJ+xPg2HWkzS094tXW SHYA== X-Gm-Message-State: AOJu0YziWP01ooiEWp647oY58ES6yCLw02eTur27O79bu9OdZ8bwTX2X Pvq1sXevF8MLUjmcuT/BenC0OEzKqdMCfDH6MvQ2xyI2bub52OAMAAM5pCYPsZiDOAjDBNLEeJa Fv49EME7MFIgXT1aMjoGma8+GswRj3OSFaU8X48glrpK6ruOZ X-Gm-Gg: ASbGncvOwqSXrAS9zGVmlrQGX+p0t4OUUeOwR6PvkTCYLexUCXwxVRN15qcsQjjgt6K V7RU4NzFZ9CxXOlVhvz6fh43aM4ZT2SdfY9yQkiw/HGkJHgZkV6frfz+a7wLu0tkrqi6Ra+Ep34 niLWCD1mhocSBzhtp4n4HBjfQpxLv2PI9SmrVyVF711vbIwjuGtWMD8uC/qPyNAZaDmVIVi9ijl HtRD92Qbq2jeyatLDL8jDTOz7vpszP4HYXOJacKW8MwTRgz12yjPQP4kmdXWTfJVS9Ax+JReeNW i+qw1f5mmoRDJNJyMekGpyOyORNYJyYqWNMjQmopnYMy6h2HCPqBJIklDsb5cPOmyMdYzU0u9jj c4hpqA+8daz9WM2RHpbDrQg== X-Received: by 2002:a05:600c:698c:b0:434:f9ad:7222 with SMTP id 5b1f17b1804b1-438918d3bdcmr103622325e9.7.1737360855189; Mon, 20 Jan 2025 00:14:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IH83HJn0BkZebhHj3O50ulPRplGoaes/qduKZvA5bScXkTrvMCEkR2bt6ZqeXFW2YXNz5LhUQ== X-Received: by 2002:a05:600c:698c:b0:434:f9ad:7222 with SMTP id 5b1f17b1804b1-438918d3bdcmr103621825e9.7.1737360854750; Mon, 20 Jan 2025 00:14:14 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf321508esm9785961f8f.10.2025.01.20.00.14.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 00:14:13 -0800 (PST) Message-ID: <463eb421-ac16-435c-b0a0-51a6a92168f6@redhat.com> Date: Mon, 20 Jan 2025 09:14:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: mm: CMA reservations require 32MiB alignment in 16KiB page size kernels instead of 8MiB in 4KiB page size kernel. To: Zi Yan , Barry Song <21cnbao@gmail.com>, Juan Yescas Cc: linux-mm@kvack.org, muchun.song@linux.dev, rppt@kernel.org, osalvador@suse.de, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, Jann Horn , Liam.Howlett@oracle.com, minchan@kernel.org, jaewon31.kim@samsung.com, charante@codeaurora.org, Suren Baghdasaryan , Kalesh Singh , "T.J. Mercier" , Isaac Manjarres , iamjoonsoo.kim@lge.com, quic_charante@quicinc.com References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BVHK5ZoiMQBCh7TxmSkt5TG9q3mMULGFF9epfZZd6YQ_1737360855 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 68F371A0013 X-Rspamd-Server: rspam10 X-Stat-Signature: rsyxd66ncodjhbh5x67p95gr7untrzga X-HE-Tag: 1737360858-319388 X-HE-Meta: U2FsdGVkX1/SvfCujAPGT1lEL+AU2yjuDmwxJycpVeflWB1NflG9sGmNfy//lYPZvGpjgvJOfjtl7LpTSUigH1NDN+2TrOcCKqqUJfjAmnyjZyoti3WFnyCQ6NkuKWUNe3ON3uRudm7ITUvwjF91VhhzESRcvDp5kaEoHFCBRl3X/u9eS0p6ywXt642Uk+GNopA9g1om3QWQCGu2FRtgKOe07oRn4zQ5BW0uKrvLRgkf+LZpDxEt0sc459uZmYV3Ppo+PJ01vKfqjYhJjqAwmDgTEZ8W5jKo/ZAG3K4Z1P/W/MlgZ2PRKGYrvuD76k2NT6Dmn8Lg2SRYXKIM1a7yTtCL6jrlmw3wj5xVvHmNARQZD2N9ZnEDFmLzKklO/xtdcEj4DLoTQ6NCdVlm0mBnzokOiOnx7QaGrFHxy1YF9+Ozn0JKyA4zC7UUX7urUJ97qD+2Xj/E3cMWjCD1mtp1HbrMewxfebqB1UDOl/E+fKr851FFZ8I9G7oisWHSNHaE8/Z4qjIqNzp6QfIXDAMd2bwAIQ6ei0wwAORh00itscamznzvrBFtyKXUw6B4xOKDnerzj7SMbHz3VRUF5Z5Ij7Mc0dE0KENUYe8aa0tnQUNLHvrOUcZBKZg+nlpPvn26RZHRuYSY9cHdPVOLiHecCQH4iUAm0mULhCIQiioG1wNMuJTaUwm3epwbkZJKWivp8joZ8M6TwqSr0c49N5AaTLcPzPpJjCsnzyPPyTQNunQ6no+vH+LlGW0dcAQAyDohsqOPZw3TPQ0w/r1NXvkm4KW5u3a6MPcKleVj/IPgnCeAuBJ2Hr0wNGUWAez7o++ARckJkxya9GUWiRrzTCs7Lo+WQklmAzuaWj5aNT11Rwp6q4cXtAyODmfAge18QfTn4OokF6WJ03eLlEQvEhHLY5QhX7m0oS5Z4CEcE6QbJ03Dw6ARezi6LkOfl8pQXUcZk+fqt3hK6fJfUt0zwEP Z1IdeF9g hdMfQj4O272hfpCdacyHzvim/eqie5UOQQlrJUn+fMkfCi4+FVyghsuRZ3tB1Nam3lbKiFYYBYsJD37BrZBMNQIHM+nJ1DD1wzCSErlDs4Y9fvIqctCC342QxXw1Ja28hJo1i7Jr0iF4Jm9In4C0UWRJWCZHFguMzZCweZoercGpTUHq4aDEqxFRIKDQuD7VAro4+dz0cnKgtu1TnkwlSymdGZ/DikG+Ot7G3JlitqhbLOI/ynrbcnTdb4AFGgBtx5VfhusmqEX+2jZxdXvaw1F5W70fNWjelIws0RzFKr9qQXNZg4fvJO/H7aIwHy+jYmtuP72U+drIahubo0TdRxuhyM0JzD7D0I82r1taWQAtB0ZF7Wns/blF6kPEwf7epHD9JL+OOdc7sJLs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 01:39, Zi Yan wrote: > On Sun Jan 19, 2025 at 6:55 PM EST, Barry Song wrote: > >>>>>> >>>>>> >>>>>> However, with this workaround, we can't use transparent huge pages. >>>>>> >>>>>> Is the CMA_MIN_ALIGNMENT_BYTES requirement alignment only to support huge pages? >>> No. CMA_MIN_ALIGNMENT_BYTES is limited by CMA_MIN_ALIGNMENT_PAGES, which >>> is equal to pageblock size. Enabling THP just bumps the pageblock size. >> >> Currently, THP might be mTHP, which can have a significantly smaller >> size than 32MB. For >> example, on arm64 systems with a 16KiB page size, a 2MB CONT-PTE mTHP >> is possible. >> Additionally, mTHP relies on the CONFIG_TRANSPARENT_HUGEPAGE configuration. >> >> I wonder if it's possible to enable CONFIG_TRANSPARENT_HUGEPAGE >> without necessarily >> using 32MiB THP. If we use other sizes, such as 64KiB, perhaps a large >> pageblock size wouldn't >> be necessary? > > I think this should work by reducing MAX_PAGE_ORDER like Juan did for > the experiment. But MAX_PAGE_ORDER is a macro right now, Kconfig needs > to be changed and kernel needs to be recompiled. Not sure if it is OK > for Juan's use case. IIRC, we set pageblock size == THP size because this is the granularity we want to optimize defragmentation for. ("try keep pageblock granularity of the same memory type: movable vs. unmovable") However, the buddy already supports having different pagetypes for large allocations. So we could leave MAX_ORDER alone and try adjusting the pageblock size in these setups. pageblock size is already variable on some architectures IIRC. We'd only have to check if all of the THP logic can deal with pageblock size < THP size. This issue is even more severe on arm64 with 64k (pageblock = 512MiB). -- Cheers, David / dhildenb