From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABDB4C001B0 for ; Mon, 24 Jul 2023 14:07:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A21C8E0008; Mon, 24 Jul 2023 10:07:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 251FE8E0002; Mon, 24 Jul 2023 10:07:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 119E88E0008; Mon, 24 Jul 2023 10:07:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03C708E0002 for ; Mon, 24 Jul 2023 10:07:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A7BAF80A9F for ; Mon, 24 Jul 2023 14:07:18 +0000 (UTC) X-FDA: 81046682556.15.233BAD4 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf21.hostedemail.com (Postfix) with ESMTP id C81EA1C0012 for ; Mon, 24 Jul 2023 14:05:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=OhYIFmLi; spf=pass (imf21.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690207533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WhFXcb6ti0iORGbpD9zt6mN2a0Mp7yrFl3s155ggPqc=; b=cqbG7i6Ilix4fYPKiU/2kGhLwCjgXfQVflxH3s5Mp+geDMAHCZskSN3Eli+uWqcVALnuXL OBmEEzYrolFZcAd3i49loDDG/hzx3GBoiLJN5qsjvsBstpiubccpvtFRRWfjt2vISjDVrd 5iAqBNFWsawptCWD/2kpXxBg+QTXXP0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=OhYIFmLi; spf=pass (imf21.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690207533; a=rsa-sha256; cv=none; b=Y5e+FV7VPfkE5pIjJZH/ME/WP/sKZJmHm0441QahAjGQJ98Gn01VpjTeUtRJBshe9u3/z0 Idg9UX5hR23miSp2dEZ5r+PwZ+F9T04YV9A3WxUmGeyQrQaESgjLy7I/fVEfKgqxLfyDfQ IP1vaXb2Yf+fLKR8K9vsID1MWj03C9Q= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-307d20548adso3115979f8f.0 for ; Mon, 24 Jul 2023 07:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690207531; x=1690812331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WhFXcb6ti0iORGbpD9zt6mN2a0Mp7yrFl3s155ggPqc=; b=OhYIFmLihZeWDk7cucsyJsh5vQP6M3nPyAsi5bBLFaIJ2abGfAFbdwhmQQpuGiH2VT j7XFQcR6ocH6vKYzQ9+Lwy5UXbJFVb8kaIRBftgLgosLqkqAdpeE74Yb3diJG4ZUemY/ i5Kjn/bCMwDssMHJ2L2Ekf0xuiEF8gk1ka8HH7W5O7Ezn3WCcfOidAowrITXwnjD2wUf wjE+VgVQ3xqO5AVcpgfLb43tjbdsZV+56CcewqmDOLy+TCB1ceepKIh/Vq3kQ5Amr31k avky5PFSorvvZ3U/psgBI703GASUxI13PcNaA8pDfLnyRmQ10t34x0Au0UuBO0NRdPjP Liqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690207531; x=1690812331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WhFXcb6ti0iORGbpD9zt6mN2a0Mp7yrFl3s155ggPqc=; b=IRkkMERI1x5IM1ka62j+Fx8lVpevujTR37k2CvvpRjI6KDs2A2XCA3qd1CKvzjPenv 3jPBI7nMy7hVWNFXfe/LTdDCnRtNfMLP1K+O9s7xAy11NlqYGMFhPQVPxMp6bFK5BsAS Nx4In3KG9nOqXZRBDWuNvEMt/MTPA3Xik2n88S5jfGPMWAtVX5wroXUo26thuorTD049 TVU2Qa7+GWUCqJA47dX5cyT03h7Bw3jXdEz9aF3sD07AGPjNyFnMTyL/2IiytC9P3y7T X2nWkBl6yfqzwjYJuBLwGhEFNCH3l6FmlmtqXIeJ3XWtLVUd4UuGLwcGKoPgYIaEt5L3 Eo0w== X-Gm-Message-State: ABy/qLZc8HQuUWEVcI2Xz7Q2lG6DKz+MOw5QUZ5W0ryrhhSsRmnT6x32 eXSNgRlKEfrKTfa8UwXLlWuziYYINANqFcCw59E= X-Google-Smtp-Source: APBJJlGK+fFGQ5T2oZ/hj4adgGgh9yz4i19TLptnTE//fHvORYyxZpRQL+GNVvbbRKmleRi2QxJIiQ== X-Received: by 2002:a05:6000:4c9:b0:315:a34f:b520 with SMTP id h9-20020a05600004c900b00315a34fb520mr5889640wri.71.1690207530907; Mon, 24 Jul 2023 07:05:30 -0700 (PDT) Received: from ?IPV6:2a02:6b6a:b465:0:d7c4:7f46:8fed:f874? ([2a02:6b6a:b465:0:d7c4:7f46:8fed:f874]) by smtp.gmail.com with ESMTPSA id q7-20020adffec7000000b003143c532431sm12906253wrs.27.2023.07.24.07.05.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 07:05:30 -0700 (PDT) Message-ID: <463c960e-1d3b-edc0-edbb-d5ecbf7fc3b1@bytedance.com> Date: Mon, 24 Jul 2023 15:05:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [External] Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB To: Mike Rapoport , songmuchun@bytedance.com, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com References: <20230207114456.2304801-1-usama.arif@bytedance.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C81EA1C0012 X-Rspam-User: X-Stat-Signature: chufiken3zcc1ga93i3hrs7yz76e5uck X-Rspamd-Server: rspam01 X-HE-Tag: 1690207532-991415 X-HE-Meta: U2FsdGVkX18ytI3Xv2pWktYuWiA0LNjbY+zkxv7jj9khtZ57GKxKEu920RYsHVlrWp898ndRwQpluysy/jNoe0VUy7YMRehUK80JDANoiynCafBTv0x311DDdH2QcytWaFEPzZ8UJvpJtLbH42eQzWEb95VdydESKIsXzACNkImP+pbM8KNwQsJfCvO1elkAZGARnnxvdp8jnJh32sASDK5f5qafenXP0560KTH0pZnyf13ij0HfLKpZ8T8FKDgT+tLQZrImEry3icLBhKAAOWZorGGVitHqA+sk+qc+AH1y+aGHepAHJKC166hh23Iv0UPJAHesPm+HcOTaU+clDW+jlAUOr1CdF04Dp1zYvg6O2qugJuDvjXs+yK67L+T84fJhi/bWXz/5WRRRZPpC4eT0J1+890Is1xS4Q3r+ymSh3o7jq1aMS8+ndrs+6uuXWfdGMs2M0O8CGoLGRdR8tG0nd0L0n+PUFmVrUZbaN5MFGcN2lt2SrBrYKmXSu6UPo6bdMCoSpV4xQdbMkh0RdnwATCe4se2M83x9yESTqO2jJX/jTNxPooKXs2Kek1xEhTKcCBQ3knDihAcY/cYHO2DD9s8ukPjl2hg7gAq45x2rZNB0/C4zjDvxQHw8QTXywhoUAqv0g6V86Hfxsb0koYKka5xF0cg13xMW4VIux0Zv1VUnpXD+OuSs/qAOn8K4sGPYtHY4Mv0HbRG0GwAvNgUJ9WqVAwJAT2r5kKFa8SRlKPQYF8joGiYhxm30Dj6QE9P803r8qV6CBJEC/eppnrHl5srKfGhu/rN6I9Vxq/SOgwtsaBbuu+q4zHCSzjVT73d29R78u0GjnaS4NObJfIF/np5nyVTe4H6AaIAUBuiZ2v64DAtR1OA0qsF0IdOQuWxzi4lnvnLQ14c/oJ76p+KOrwLy/pV80m9lQromu/Wx1yI26ev+phyckEtfVTol89qlazGhNmRh0vjcq/b gkxLUCQ+ 6a575Mp7n6S7OFPbyLO6FRJP5Xmt0Xm0oe+Ex5KAoDrLp6a+zGTRHfugHEpu30ISsKkKLkdCYg0BiTAcziPYNQZDQGiFYhq72tQ7TRbPMN+jfR/vng+6CKGVK06WSUnCeSeHK6Z4Bv6T1Ph+xBHQcK9uvlSO3S7oXak97SqGSilpqUqj//CMsxR7VxJDgYavXxZmFYz/y3mKa26MBVCewj7d7vdo0DRVGOlBQlg7HHJNLXrvjtb9NRaMflVQrB1CrAkg0gU+m45s7ic6BF7oFQPmbegmj54mGOhVcRVMfF+vDplraQg1vaUs2bx3qhGgiS/lud6XSoR+gF5b+jnT5Qqs85J0uqM6kt9mCeLlHhKBc7gJRxu+lJvFBK81ibb4ghatuNQFAxtUYBcZ/hTfnuCHNqrinhb6QwuFAuDF/7qvOcwZrBplE1lcbgddatd1toOMKD4mgW3CAKROsKsNdNjL9Cp3U9Wb1oBVpd6YS9jP84RAyxo4IrIWaVKMiFc281n8kO+VgJZGrS9BsfRNLPpqlkrpv7+seQRYs/9m1kMUmlu6dd8XAza/DCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.068809, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/02/2023 09:51, Mike Rapoport wrote: > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: >> 1GB HugeTLB page consists of 262144 base pages. >> >> Signed-off-by: Usama Arif > > Acked-by: Mike Rapoport (IBM) > >> --- >> Documentation/mm/vmemmap_dedup.rst | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst >> index a4b12ff906c4..689a6907c70b 100644 >> --- a/Documentation/mm/vmemmap_dedup.rst >> +++ b/Documentation/mm/vmemmap_dedup.rst >> @@ -1,3 +1,4 @@ >> + >> .. SPDX-License-Identifier: GPL-2.0 >> >> ========================================= >> @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many >> architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more >> details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are >> currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page >> -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. >> +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. >> For each base page, there is a corresponding ``struct page``. >> >> Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to >> -- >> 2.25.1 >> > Hi, Was just reading vmemmap_dedup.rst for something and realized that its still 4096 pages for 1G, maybe this patch got missed? Thanks, Usama